[Bug 37598] New: Ability to use the BCC field for sending notices to multiple addresses, rather than the To field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Bug ID: 37598 Summary: Ability to use the BCC field for sending notices to multiple addresses, rather than the To field Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Bug 12802 allows libraries to select a list of email address fields to use when sending notices to patrons. You would check all of the email addresses you want to use in a new system preference EmailFieldSelection and Koha will send the notice to all of those addresses. However, all of those addresses do go through in the To field. They are not in the BCC field. It would be good to enable the option to use the BCC field for the email addresses rather than the To field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |aleisha@catalyst.net.nz |ity.org | Status|NEW |ASSIGNED Depends on| |12802 Change sponsored?|--- |Sponsored Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12802 [Bug 12802] Send notices using several email addresses -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170249&action=edit Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170250&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37623 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 [Bug 37623] t/db_dependent/Letters.t tests fail to consider EmailFieldPrimary syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170249|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170254&action=edit Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170250|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170255&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 170256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170256&action=edit Bug 37598: Tests for t/db_dependent/Letters.t WIP -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170254|0 |1 is obsolete| | --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 171112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171112&action=edit Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170255|0 |1 is obsolete| | --- Comment #7 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 171113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171113&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170256|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 171114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171114&action=edit Bug 37598: Tests for t/db_dependent/Letters.t To test: 1. Apply patches and update database, restart services 2. Go to Koha administration -> system preferences, search for EmailFieldPrimary 3. Change EmailFieldPrimary to 'selected addresses' 4. Make a selection in the EmailFieldSelection system preference 5. Notice the new EmailRecipientField system preference, it should be set to "To" by default. 6. Have a patron with different addresses in the email fields, depending on the selection you made in EmailFieldSelection: - primary email - alternate email - secondary email 7. Test the new EmailRecipientField system preference using the Welcome email, found by going to the Patron, clicking More, then choosing "Send Welcome notice" 8. In the command line, go to the database `sudo koha-mysql <instancename>` and look at the message_queue to see who the emails are sent to `select * from message_queue\G`. The to_address will contain all the selected email addresses. 9. In the command line, run `misc/cronjobs/process_message_queue.pl` 10. Confirm that the to_address and cc_address are set appropriately based on EmailRecipientField 12. Repeat steps 7-9, testing with different values of EmailRecipientField. When testing EmailRecipientField with bcc, confirm that the to_address is just the first valid email address. Unfortunately we can't test bcc without actually sending the email. 13. Confirm tests pass t/db_dependent/Letters.t Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Emmanuel Bétemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |e.betemps@gmail.com --- Comment #9 from Emmanuel Bétemps <e.betemps@gmail.com> --- Hi, Applying: Bug 37598: Add EmailRecipientField syspref Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171112|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 180425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180425&action=edit Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171113|0 |1 is obsolete| | --- Comment #11 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 180426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180426&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171114|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 180427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180427&action=edit Bug 37598: Tests for t/db_dependent/Letters.t To test: 1. Apply patches and update database, restart services 2. Go to Koha administration -> system preferences, search for EmailFieldPrimary 3. Change EmailFieldPrimary to 'selected addresses' 4. Make a selection in the EmailFieldSelection system preference 5. Notice the new EmailRecipientField system preference, it should be set to "To" by default. 6. Have a patron with different addresses in the email fields, depending on the selection you made in EmailFieldSelection: - primary email - alternate email - secondary email 7. Test the new EmailRecipientField system preference using the Welcome email, found by going to the Patron, clicking More, then choosing "Send Welcome notice" 8. In the command line, go to the database `sudo koha-mysql <instancename>` and look at the message_queue to see who the emails are sent to `select * from message_queue\G`. The to_address will contain all the selected email addresses. 9. In the command line, run `misc/cronjobs/process_message_queue.pl` 10. Confirm that the to_address and cc_address are set appropriately based on EmailRecipientField 12. Repeat steps 7-9, testing with different values of EmailRecipientField. When testing EmailRecipientField with bcc, confirm that the to_address is just the first valid email address. Unfortunately we can't test bcc without actually sending the email. 13. Confirm tests pass t/db_dependent/Letters.t Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #13 from David Cook <dcook@prosentient.com.au> --- Comment on attachment 180426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180426 Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses Review of attachment 180426: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=37598&attachment=180426) ----------------------------------------------------------------- ::: C4/Letters.pm @@ +1516,5 @@
); return; } + + my $bcc_address = C4::Context->preference('NoticeBcc');
Wouldn't it make sense to put the following into its own function and then unit test that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #14 from David Cook <dcook@prosentient.com.au> --- This is an interesting one. We don't use multi email addresses with Koha at this point, but I have been thinking how it would be nice to be able to use BCC instead of To at times... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #15 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Cook from comment #13)
Wouldn't it make sense to put the following into its own function and then unit test that?
The function it's in is already a hidden one, so I'm not sure that would add much more value or clarity at the moment? But happy to be told I'm wrong, just trying to use our sponsorship wisely here :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am sorry Aleisha, we are hitting soft feature freeze today, please leave use of of the keyword to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #17 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #16)
I am sorry Aleisha, we are hitting soft feature freeze today, please leave use of of the keyword to me.
Sorry, I didn't realise. The sponsoring library had been hoping this would be pushed by now and I wasn't sure how else to bump it. No worries :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- If we can get this through QA by the end of next week I'd still be open to push it. Hard feature freeze is on 13th. But since it effect all emails being sent, I think we'd need a good round of testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Bug 37598 depends on bug 37623, which changed state. Bug 37623 Summary: t/db_dependent/Letters.t tests fails to consider EmailFieldPrimary system preference https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37623 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180425|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190636&action=edit Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180426|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190637&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180427|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 190638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190638&action=edit Bug 37598: Tests for t/db_dependent/Letters.t To test: 1. Apply patches and update database, restart services 2. Go to Koha administration -> system preferences, search for EmailFieldPrimary 3. Change EmailFieldPrimary to 'selected addresses' 4. Make a selection in the EmailFieldSelection system preference 5. Notice the new EmailRecipientField system preference, it should be set to "To" by default. 6. Have a patron with different addresses in the email fields, depending on the selection you made in EmailFieldSelection: - primary email - alternate email - secondary email 7. Test the new EmailRecipientField system preference using the Welcome email, found by going to the Patron, clicking More, then choosing "Send Welcome notice" 8. In the command line, go to the database `sudo koha-mysql <instancename>` and look at the message_queue to see who the emails are sent to `select * from message_queue\G`. The to_address will contain all the selected email addresses. 9. In the command line, run `misc/cronjobs/process_message_queue.pl` 10. Confirm that the to_address and cc_address are set appropriately based on EmailRecipientField 12. Repeat steps 7-9, testing with different values of EmailRecipientField. When testing EmailRecipientField with bcc, confirm that the to_address is just the first valid email address. Unfortunately we can't test bcc without actually sending the email. 13. Confirm tests pass t/db_dependent/Letters.t Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #22 from David Nind <david@davidnind.com> --- The patches no longer apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190636|0 |1 is obsolete| | --- Comment #23 from David Nind <david@davidnind.com> --- Created attachment 193605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193605&action=edit Bug 37598: Add EmailRecipientField syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190637|0 |1 is obsolete| | --- Comment #24 from David Nind <david@davidnind.com> --- Created attachment 193606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193606&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190638|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 193607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193607&action=edit Bug 37598: Tests for t/db_dependent/Letters.t To test: 1. Apply patches and update database, restart services 2. Go to Koha administration -> system preferences, search for EmailFieldPrimary 3. Change EmailFieldPrimary to 'selected addresses' 4. Make a selection in the EmailFieldSelection system preference 5. Notice the new EmailRecipientField system preference, it should be set to "To" by default. 6. Have a patron with different addresses in the email fields, depending on the selection you made in EmailFieldSelection: - primary email - alternate email - secondary email 7. Test the new EmailRecipientField system preference using the Welcome email, found by going to the Patron, clicking More, then choosing "Send Welcome notice" 8. In the command line, go to the database `sudo koha-mysql <instancename>` and look at the message_queue to see who the emails are sent to `select * from message_queue\G`. The to_address will contain all the selected email addresses. 9. In the command line, run `misc/cronjobs/process_message_queue.pl` 10. Confirm that the to_address and cc_address are set appropriately based on EmailRecipientField 12. Repeat steps 7-9, testing with different values of EmailRecipientField. When testing EmailRecipientField with bcc, confirm that the to_address is just the first valid email address. Unfortunately we can't test bcc without actually sending the email. 13. Confirm tests pass t/db_dependent/Letters.t Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #26 from David Nind <david@davidnind.com> --- Managed to fix the merge conflict! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #27 from David Nind <david@davidnind.com> --- I have failed QA as the tests don't pass: t/db_dependent/Letters.t .. Dubious, test returned 1 (wstat 256, 0x100) All 105 subtests passed Test Summary Report ------------------- t/db_dependent/Letters.t (Wstat: 256 (exited 1) Tests: 106 Failed: 1) Failed test: 106 Non-zero exit status: 1 Parse errors: Bad plan. You planned 105 tests but ran 106. Files=1, Tests=106, 6 wallclock secs ( 0.03 usr 0.00 sys + 3.91 cusr 1.66 csys = 5.60 CPU) Result: FAIL However, I also couldn't get any email address to appear in the CC address (cc_address) in the actual emails, only in the To address (to_address). I tried various combinations without any luck. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #28 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. To actually send emails, I set up an SMS server using a Google account. 2. To test sending emails using a Google account: 2.1 Set up an App password for your Google Account 2.3 Configure a new 'SMTP Server' under 'Administration > SMTP servers' using these settings, where `User name` = your Google email address and `Password` = your APP password, not your Google account password: Host: smtp.gmail.com Port: 587 Timeout: 5 SSL: STARTTLS User name: GOOGLEACCOUNTUSER Password: GOOGLEAPPPASSWORD 2.3 Set this server as default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Jennifer Sutton <jennifersutton@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #193605|0 |1 is obsolete| | Attachment #193606|0 |1 is obsolete| | Attachment #193607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #29 from Jennifer Sutton <jennifersutton@catalyst.net.nz> --- Created attachment 201225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201225&action=edit Bug 37598: Add EmailRecipientField syspref Patch from commit 3f6d8e1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #30 from Jennifer Sutton <jennifersutton@catalyst.net.nz> --- Created attachment 201226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201226&action=edit Bug 37598: Use EmailRecipientField for 'to', 'cc' or 'bcc' when sending notices to selected addresses Patch from commit c58ad5c -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #31 from Jennifer Sutton <jennifersutton@catalyst.net.nz> --- Created attachment 201227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201227&action=edit Bug 37598: Tests for t/db_dependent/Letters.t To test: 1. Apply patches and update database, restart services 2. Go to Koha administration -> system preferences, search for EmailFieldPrimary 3. Change EmailFieldPrimary to 'selected addresses' 4. Make a selection in the EmailFieldSelection system preference 5. Notice the new EmailRecipientField system preference, it should be set to "To" by default. 6. Have a patron with different addresses in the email fields, depending on the selection you made in EmailFieldSelection: - primary email - alternate email - secondary email 7. Test the new EmailRecipientField system preference using the Welcome email, found by going to the Patron, clicking More, then choosing "Send Welcome notice" 8. In the command line, go to the database `sudo koha-mysql <instancename>` and look at the message_queue to see who the emails are sent to `select * from message_queue\G`. The to_address will contain all the selected email addresses. 9. In the command line, run `misc/cronjobs/process_message_queue.pl` 10. Confirm that the to_address and cc_address are set appropriately based on EmailRecipientField 12. Repeat steps 7-9, testing with different values of EmailRecipientField. When testing EmailRecipientField with bcc, confirm that the to_address is just the first valid email address. Unfortunately we can't test bcc without actually sending the email. 13. Confirm tests pass t/db_dependent/Letters.t Sponsored-by: Pymble Ladies' College -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 Jennifer Sutton <jennifersutton@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |jennifersutton@catalyst.net | |.nz --- Comment #32 from Jennifer Sutton <jennifersutton@catalyst.net.nz> --- I tested sending some emails with KTD’s SMTP server, and the To, Cc, and Bcc fields appeared to be used correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #33 from David Nind <david@davidnind.com> --- I've Failed QA, as the tests are failing for me. Apologies for taking so long to re-test. Am also having trouble getting this to work as expected, I can't get the To address to follow EmailFieldPrecedence when CC and BCC are used for EmailRecipientField: 1. Email addresses: - Primary email = email (david.nind@gmail.com) - Secondary email = emailpro (david@davidnind.com) - Alternate address - Email = B_email (davidnind@yahoo.co.nz) 2. Settings: - EmailFieldPrecedence: email|emailpro|B_email - EmailFieldPrimary: selected addresses 3. With only one option selected for EmailFieldSelection and Copy (CC) set for EmailRecipientField, things work as expected: - alternate email: to_address and cc_address use B_email (as expected, as only one selected and this should be used for both) - primary email: to_address and cc_address both use email (as expected) - secondary email: to_address and cc_address use emailpro (as expected) 4. Repeating step 3 with two addresses selected (alternative address (B_email) and secondary address (emailpro)) does not work as expected: - to_address = davidnind@yahoo.co.nz (B_email) (not as expected, should have been emailpro (david@davidnind.com) as it comes before B_email in EmailFieldPrecedence) - cc_address = davidnind@yahoo.co.nz,david@davidnind.com (as expected) 5. With: - EmailFieldPrimary set to [All selected] - EmailRecipientField set to Copy (CC) Result = . to_address: davidnind@yahoo.co.nz (not as expected, should have been email (david.nind@gmail.com) as this is first in EmailFieldPrecedence) . cc_address: davidnind@yahoo.co.nz,david.nind@gmail.com,david@davidnind.com (as expected) . So it is sending to B_email in the To address, when it should be email 6. I didn't test BCC at this stage. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37598 --- Comment #34 from David Nind <david@davidnind.com> --- Test failures - I haven't included the full output: ... # Looks like you failed 1 test of 106. t/db_dependent/Letters.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/106 subtests Test Summary Report ------------------- t/db_dependent/Letters.t (Wstat: 256 (exited 1) Tests: 106 Failed: 1) Failed test: 106 Non-zero exit status: 1 Files=1, Tests=106, 9 wallclock secs ( 0.03 usr 0.01 sys + 6.16 cusr 1.66 csys = 7.86 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org