http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Display all 700, 710 and 711’s with a subfield i as Related Works (full display) Related Works: Television adaptation of (work): Kerman, Piper. Orange is the new black. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Any of these fields marked with second indicator 2 represent works that are contained by the title so maybe: Display all 700, 710 and 711’s with a second indicator 2 as Contained Works (full display) Contained Works: Adams, Douglas. Hitchikers guide to the galaxy | Adams, Douglas. The restaurant at the end of the universe ... -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Be careful, if there is an $e to display, you will want to ignore $4 in that case. I am not sure about using | as a separator, it looks quite uncommon. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know that currently for records in our union catalog both are used simultanously - so it would be an issue for our libraries. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wsalesky@gmail.com --- Comment #8 from Winona Salesky <wsalesky@gmail.com> --- Any thoughts on where in the record display you would like to see the additional 700 information (Related works for 700$i and Contained works 700@ind2=2). Perhaps following the "Other Title" display? Another question about the contained work display: How should s field be treated with a indicator 2 = 2 and a subfield i? Output twice? Once as Related Work, once as Contained Work? Just once as Contained Work? <datafield tag="700" ind1="1" ind2="2"> <subfield code="i">Television adaptation of (work):</subfield> <subfield code="a">Kerman, Piper.</subfield> <subfield code="t">Orange is the new black.</subfield> </datafield> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #10 from Nick Clemens <nick@quecheelibrary.org> ---

Any thoughts on where in the record display you would like to see the additional 700 information (Related works for 700$i and Contained works 700@ind2=2). Perhaps following the "Other Title" display?

I would support that, getting it out of the 'Additional authors' section is really what I would like to see

How should s field be treated with a indicator 2 = 2 and a subfield i?

I would say the presence of an $i would trump the second indicator

I agree with Katrin that the vertical bar doesn't appear very attractive or common, but don't necessarily have a better option.

What about the use of a double hyphen -- ? This is what is used in the 505 field to separate contents and seems to work visually -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Amber Hunt <amber@marlboro.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amber@marlboro.edu --- Comment #12 from Amber Hunt <amber@marlboro.edu> ---

What about the use of a double hyphen -- ? This is what is used in the 505 field to separate contents and seems to work visually

The vertical bar (|) is used to separate subject headings and I think works quite nicely. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

I am not sure about using | as a separator, it looks quite uncommon.

Still not sure, but not opposed :) Maybe if we would put it in a span with a class <span class="separator>|</span> - so that changing it to whatever is really easy later and also the color can be changed etc. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #16 from Winona Salesky <wsalesky@gmail.com> --- This sounds like a good resolution. Thanks! -Winona -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #17 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 35613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35613&action=edit Bug 13382: RDA 700s This patch updates the visibility of the 7xx fields in the XSLT display in the staff and OPAC. To test: * Search the opac for a title with 7xx fields * Click the title * Make sure the fields display properly * Repeat for a few more titles * Repeat in the Staff Client -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #18 from Nick Clemens <nick@quecheelibrary.org> --- This wasn't marked 'Needs signoff' but I tested the patch just to see. Only issue I saw on first glance through was that a 710 with second indicator two and presence of subfield i triggered an empty 'Contained works:' line. The info in the field itself was correctly listed as "Related work" When I deleted the 710 the empty entry dissappeared Attaching a screenshot for "Orange is the new black" to illustrate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #21 from Nick Clemens <nick@quecheelibrary.org> --- The only issue I see is that when displaying at a 'Contained Work' the last character of the field preceding the relator terms is clipped. When displaying contributors all looks fine. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #24 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 36515 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36515&action=edit MARC record with contained works When displaying the contained works with this patch the last character is chopped. Presumably this is to remove punctuation, but for an incorrectly punctuated field or field ending in ')' this could be problematic. In the attached record the first 700 contained work is badly punctuated and the word orchestra is trimmed, for others a comma is trimmed and replaced with a ';' separator. When testing it seems to be any character in the last field displayed AFAIK subject fields will trim a '.' on display, but not a ')' so maybe just ensure only certain punctuation is trimmed if possible Probably contained works should be separated by the '|' character as other fields are for consistency throughout -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #27 from Nick Clemens <nick@quecheelibrary.org> --- Trying to check everything this time around, here are the few things I see: 1 - For related or contained works subfields n & p are not displaying 2 - 710/711 with subfield i appear in Contributors and not Related Works 3 - 710/711 with subfield i and 2nd indicator 2 do not appear -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #31 from Winona Salesky <wsalesky@gmail.com> --- Thanks Nick for catching all of those. This patch should address the following issues: 1 - For related or contained works subfields n & p are not displaying 2 - 710/711 with subfield i appear in Contributors and not Related Works 3 - 710/711 with subfield i and 2nd indicator 2 do not appear -Winona (In reply to Winona Salesky from comment #30)

Created attachment 37448 [details] [review] Bug 13382 - RDA: 700/710/711 display in XSLT

Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37448|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 37591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37591&action=edit Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac search results and record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #34 from Winona Salesky <wsalesky@gmail.com> --- Yes, they are. Although, now that I am looking back through the code, I only handle multiple $e, if there are multiple $4 it only displays 1. Should I change that, or is that unlikely to be an issue? -Winona (In reply to rgravel from comment #33)

With our systems librarian on leave, I'm not able to do a done of patch testing, but I wonder: Are multiple relator terms displaying with the patch, like in the below example? Thanks!

Contributor(s): Nolan, Christopher, 1970­ [film producer, screenwriter, director]

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think they would match up - I can and find out beginning next week. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #38 from Winona Salesky <wsalesky@gmail.com> --- Okay, I will need to add that for the multiple $e. Will try to get to it tonight. Thanks, -Winona (In reply to Katrin Fischer from comment #37)

I have checked with my coworkers, there will be mulitple $e and multiple $e, appearing in pairs, where the sequence in the field matters.

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #40 from Winona Salesky <wsalesky@gmail.com> --- Thanks I will do that. However, I think this bug and 13383, introduce some contradictory logic. I will push this one first, once it gets signed off and is pushed to master I will rework #13383 so they play nicely together. -Winona (In reply to Katrin Fischer from comment #39)

With the other patches pushed, this one does no longer apply. Please fix your patch and switch back to 'signef off' again!

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Winona Salesky <wsalesky@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37591|0 |1 is obsolete| | --- Comment #41 from Winona Salesky <wsalesky@gmail.com> --- Created attachment 38299 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38299&action=edit Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38299|0 |1 is obsolete| | --- Comment #42 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 38501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38501&action=edit [SIGNED OFF] Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38501|0 |1 is obsolete| | --- Comment #43 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 39843 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39843&action=edit [PASSED QA] Bug 13382 - RDA: 700/710/711 display in XSLT Test Plan: 1) Apply this patch 2) Ensure you are using the default XSLT setting for the staff and opac record details 3) Find or create a record with MARC tags 700,710,711 4) Perform an opac search that would show the record in the search results. 5) Click title to review record. 6) Note the fields updates 700,710,711 to show subfields a, b, c, d, e, f, g, h, i, k, l, m, n, o, p, r, s, t, u, x. Multiple fields are separated by span class=separator |. Adds Related and Contained Works as new headings. 7) Repeat steps 4 - 6 for the staff interface Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch causes several problems: 1) Repeated 7xx are not correctly displayed. Example with 3 700: Contributor(s): Wiesflecker, HermannNovotny, Alexander [ed.]Pickl, Othmar [ed.] | Missing separators and spaces between names. 2) There is always a pipe appearing at the end of the "Contributors". 3) Also, the little icon to the authority record is broken by this patch. Please fix asap. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Winona, I think best to add a new bug and link it to this one - that way there will be no confusion about the status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 --- Comment #49 from Winona Salesky <wsalesky@gmail.com> --- Sorry for the delay, had some git bz issues this morning. See new patch: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 (In reply to Katrin Fischer from comment #48)

And thx for the quick reply :)

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicole@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14359 | --- Comment #50 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 14359 has been marked as a duplicate of this bug. *** Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14359 [Bug 14359] RDA: 700/710/711 display in XSLT Bug fix for Contributors -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13382 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Templates |MARC Bibliographic data | |support -- You are receiving this mail because: You are watching all bug changes.