http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39487 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39487&action=edit Bug 13972: Include fields from subscription and serial table in serial notification email Currently it's not possible to include information about which issue has arrived in the serial notification notice the patron can subscribe to from the OPAC. The patch makes the fields from the subscription and serial table available to the notice template. In order to be able to print information about the correct issue, the GetAlert has been modified to expext the serialid as externalid when the module is issue. git grep SendAlerts (only call with 'issue' is in Serial.pm) To test: - Add a subscription, select a patron notification template - Search for the record in the OPAC - Go to the subscription tab - More details - Subscribe to the notification - Edit the notice template you selected for the subscription - add fields from subscription - add fields from serial (serial.serialseq has the issue information) - Receive an issue for the subscription - Check that you have received the notification and that all information has been printed correctly NOTE: notice is sent directly, not through the message_queue -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39489&action=edit Bug 13972: Follow-up - Add unit tests for changed parts of SendAlerts To test: - prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39489|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39490 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39490&action=edit Bug 13972: Follow-up - Add unit tests for changed parts of SendAlerts To test: - prove t/db_dependent/Letters.t -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 40021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40021&action=edit [Signed-off] Bug 13972: Include fields from subscription and serial table in serial notification email Currently it's not possible to include information about which issue has arrived in the serial notification notice the patron can subscribe to from the OPAC. The patch makes the fields from the subscription and serial table available to the notice template. In order to be able to print information about the correct issue, the GetAlert has been modified to expext the serialid as externalid when the module is issue. git grep SendAlerts (only call with 'issue' is in Serial.pm) To test: - Add a subscription, select a patron notification template - Search for the record in the OPAC - Go to the subscription tab - More details - Subscribe to the notification - Edit the notice template you selected for the subscription - add fields from subscription - add fields from serial (serial.serialseq has the issue information) - Receive an issue for the subscription - Check that you have received the notification and that all information has been printed correctly NOTE: notice is sent directly, not through the message_queue Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #39487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40021|0 |1 is obsolete| | Attachment #40022|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40273&action=edit Bug 13972: Include fields from subscription and serial table in serial notification email Currently it's not possible to include information about which issue has arrived in the serial notification notice the patron can subscribe to from the OPAC. The patch makes the fields from the subscription and serial table available to the notice template. In order to be able to print information about the correct issue, the GetAlert has been modified to expext the serialid as externalid when the module is issue. git grep SendAlerts (only call with 'issue' is in Serial.pm) To test: - Add a subscription, select a patron notification template - Search for the record in the OPAC - Go to the subscription tab - More details - Subscribe to the notification - Edit the notice template you selected for the subscription - add fields from subscription - add fields from serial (serial.serialseq has the issue information) - Receive an issue for the subscription - Check that you have received the notification and that all information has been printed correctly NOTE: notice is sent directly, not through the message_queue Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13972 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Serials |Notices -- You are receiving this mail because: You are watching all bug changes.