https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 110756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110756&action=edit Bug 26537: Fix search when no term in value_builder/unimarc_field_4XX.pl Cataloguing plugin value_builder/unimarc_field_4XX.pl has an itemtype filter. It does not work when used without a search term. Test plan : 1) Be sure search on itemtype return some results 2) Use cataloguing plugin unimarc_field_4XX.pl 3) Enter no search term and select an itemtype 4) Check you get correct results 5) Enter a search term and dont select an itemtype 6) Check you get correct results 7) Enter a search term and select an itemtype 8) Check you get correct results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #3 from Alex Arnaud <alex.arnaud@biblibre.com> --- When searching term and item type, the ES query looks like this: "query":"(:jean and itemtype:LIVR)" My opinion is that we should use QueryBuilder to make the query. Counter patch is coming. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #5 from Alex Arnaud <alex.arnaud@biblibre.com> --- @frido, can you test the last patch ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Maybe rename $es_query into $search_query, it's not specific to ES -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- - $to = $from + $resultsperpage ; + $to = $startfrom * $resultsperpage + $resultsperpage ; I dont understand this change. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers@biblibre.co |alex.arnaud@biblibre.com |m | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |thibaud.guillot@biblibre.co | |m Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #10 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128931&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #12 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128933&action=edit Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128934|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|0 |1 is obsolete| | --- Comment #14 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 128937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128937&action=edit Bug 26537 : (follow-up) fix paging of results -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111049|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #18 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 129647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129647&action=edit Bug 26537: (follow-up) fix paging of results Also I renamed "es_query" variable for better understanding (this script works with Elastic search but also Zebra) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25616 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The patch doesn't apply, I believe the fix is probably simple but don't want to mess with it: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query Using index info to reconstruct a base tree... M cataloguing/value_builder/unimarc_field_4XX.pl Falling back to patching base and 3-way merge... Auto-merging cataloguing/value_builder/unimarc_field_4XX.pl CONFLICT (content): Merge conflict in cataloguing/value_builder/unimarc_field_4XX.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 26537: use QueryBuilder in unimarc_field_4XX plugin to make query hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-26537-use-QueryBuilder-in-unimarcfield4XX-plug-sBlXav.patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129647|0 |1 is obsolete| | --- Comment #23 from Thibaud Guillot <thibaud.guillot@biblibre.com> --- Created attachment 144859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144859&action=edit Bug 26537: (follow-up) fix paging of results Also I renamed "es_query" variable for better understanding (this script works with Elastic search but also Zebra) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Amaury GAU <amaury.gau@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amaury.gau@bulac.fr Status|Needs Signoff |Failed QA --- Comment #24 from Amaury GAU <amaury.gau@bulac.fr> --- Test plan : 0) Use ES 1) Add a new record 2) Use cataloguing plugin unimarc_field_4XX.pl 3) Enter no search term and select an itemtype 4) Expect internal server error 5) Apply patch 6) retry 7) Expected no error but there was Did we do well testing this way and can this be added to the patch ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144859|0 |1 is obsolete| | --- Comment #26 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 186011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186011&action=edit Bug 26537: (follow-up) fix paging of results Also I renamed "es_query" variable for better understanding (this script works with Elastic search but also Zebra) Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | Status|Signed Off |Failed QA --- Comment #27 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- [FAIL] cataloguing/value_builder/unimarc_field_4XX.pl SKIP spelling FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl cataloguing/value_builder/unimarc_field_4XX.pl` FAIL valid "my" variable $search masks earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #28 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 188550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188550&action=edit Bug 26537: (follow-up) Fix vars and tidiness -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 --- Comment #30 from Fridolin Somers <fridolin.somers@biblibre.com> --- Patches changes : - $to = $from + $resultsperpage; + $to = $from * $resultsperpage; Is this correct ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26537 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.