[Bug 21908] New: Add biblio_metadata to rebuild_zebra.pl tables
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Bug ID: 21908 Summary: Add biblio_metadata to rebuild_zebra.pl tables Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. It is missing biblio_metadata to allow filtering on MARCXML with ExtractValue. Also when using table=items we should use DISTINCT(biblionumber) to avoid indexing several times the same biblio record when it has several items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 82723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82723&action=edit Bug 21908: Add biblio_metadata to rebuild_zebra.pl tables Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. It is missing biblio_metadata to allow filtering on MARCXML with ExtractValue. Test plan : 1) Be sur you have a biblio record with biblionumber 1 2) Run misc/migration_tools/rebuild_zebra.pl -h 3) You see : --table specify a table (can be items, biblioitems, biblio, biblio_metadata) to retrieve biblionumber to index. 4) Run misc/migration_tools/rebuild_zebra.pl -v -b --table biblio_metadata --where="biblio_metadata.biblionumber=1" 5) Check you dont have SQL errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 82724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82724&action=edit Bug 21908: Add DISTINCT biblionumber to rebuild_zebra.pl Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. When using table=items we should use DISTINCT(biblionumber) to avoid indexing several times the same biblio record when it has several items. This patch adds DISTINCT(biblionumber) in all cases it does not harm if its already unique. Test plan : 1) Be sur you have a biblio record with biblionumber 1 with 3 items 2) Run misc/migration_tools/rebuild_zebra.pl -v -b --table items --where="biblionumber=1" 3) Without patch you see "Records exported: 3", with patch only one 4) Check indexing works well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17196 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17196 [Bug 17196] Move marcxml out of the biblioitems table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82723|0 |1 is obsolete| | --- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82817&action=edit Bug 21908: Add biblio_metadata to rebuild_zebra.pl tables Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. It is missing biblio_metadata to allow filtering on MARCXML with ExtractValue. Test plan : 1) Be sur you have a biblio record with biblionumber 1 2) Run misc/migration_tools/rebuild_zebra.pl -h 3) You see : --table specify a table (can be items, biblioitems, biblio, biblio_metadata) to retrieve biblionumber to index. 4) Run misc/migration_tools/rebuild_zebra.pl -v -b --table biblio_metadata --where="biblio_metadata.biblionumber=1" 5) Check you dont have SQL errors -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault@inlibr | |o.com Attachment #82817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82723|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82723|0 |1 is obsolete| | --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82818&action=edit Bug 21908: Add biblio_metadata to rebuild_zebra.pl tables Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. It is missing biblio_metadata to allow filtering on MARCXML with ExtractValue. Test plan : 1) Be sur you have a biblio record with biblionumber 1 2) Run misc/migration_tools/rebuild_zebra.pl -h 3) You see : --table specify a table (can be items, biblioitems, biblio, biblio_metadata) to retrieve biblionumber to index. 4) Run misc/migration_tools/rebuild_zebra.pl -v -b --table biblio_metadata --where="biblio_metadata.biblionumber=1" 5) Check you dont have SQL errors Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82724|0 |1 is obsolete| | --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> --- Created attachment 82819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82819&action=edit Bug 21908: Add DISTINCT biblionumber to rebuild_zebra.pl Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. When using table=items we should use DISTINCT(biblionumber) to avoid indexing several times the same biblio record when it has several items. This patch adds DISTINCT(biblionumber) in all cases it does not harm if its already unique. Test plan : 1) Be sur you have a biblio record with biblionumber 1 with 3 items 2) Run misc/migration_tools/rebuild_zebra.pl -v -b --table items --where="biblionumber=1" 3) Without patch you see "Records exported: 3", with patch only one 4) Check indexing works well Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Pierre-Marc Thibault <pierre-marc.thibault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82818|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 82952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82952&action=edit Bug 21908: Add biblio_metadata to rebuild_zebra.pl tables Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. It is missing biblio_metadata to allow filtering on MARCXML with ExtractValue. Test plan : 1) Be sur you have a biblio record with biblionumber 1 2) Run misc/migration_tools/rebuild_zebra.pl -h 3) You see : --table specify a table (can be items, biblioitems, biblio, biblio_metadata) to retrieve biblionumber to index. 4) Run misc/migration_tools/rebuild_zebra.pl -v -b --table biblio_metadata --where="biblio_metadata.biblionumber=1" 5) Check you dont have SQL errors Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82819|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 82953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82953&action=edit Bug 21908: Add DISTINCT biblionumber to rebuild_zebra.pl Zebra indexing script misc/migration_tools/rebuild_zebra.pl as a table arg to allow filtering. When using table=items we should use DISTINCT(biblionumber) to avoid indexing several times the same biblio record when it has several items. This patch adds DISTINCT(biblionumber) in all cases it does not harm if its already unique. Test plan : 1) Be sur you have a biblio record with biblionumber 1 with 3 items 2) Run misc/migration_tools/rebuild_zebra.pl -v -b --table items --where="biblionumber=1" 3) Without patch you see "Records exported: 3", with patch only one 4) Check indexing works well Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault@inLibro.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 82954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82954&action=edit Bug 21908: (QA follow-up) Remove useless parentheses in query Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add biblio_metadata to |biblio_metadata is missing |rebuild_zebra.pl tables |from the rebuild_zebra.pl | |tables list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.05 for 18.05.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21908 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org