[Bug 21778] New: Sorting is inconsistent on patron search based on permissions
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Bug ID: 21778 Summary: Sorting is inconsistent on patron search based on permissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When searching for patrons the results are sorted by surname, firstname if CAN_user_tools_manage_patron_lists otherwise they are sorted by cardnumber This seems to be a confusion in the template - the checkbox column is only hidden if the user cannot edit patrons or add them to a list, however, the sorting assumes it is hidden if they cannot add patrons to a list -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 82015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82015&action=edit Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons To test: 1 - Create four users: 1 superlibrarian (or with both edit patrons and manage patron lists) 1 with only edit patrons and catalogue 1 with only add to list and catalogue 1 with catalogue but neither edit patrons or manage patron lists 2 - Search patrons signed in as each user 3 - Note different sorting 4 - Apply patch 5 - Try searching with each patron 6 - Results should always be sorted by surname, firstname 7 - Only in the case of neither extra permission should the checkboxes be absent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Margaret <margaret@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret@bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82015|0 |1 is obsolete| | --- Comment #2 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 82768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82768&action=edit Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons To test: 1 - Create four users: 1 superlibrarian (or with both edit patrons and manage patron lists) 1 with only edit patrons and catalogue 1 with only add to list and catalogue 1 with catalogue but neither edit patrons or manage patron lists 2 - Search patrons signed in as each user 3 - Note different sorting 4 - Apply patch 5 - Try searching with each patron 6 - Results should always be sorted by surname, firstname 7 - Only in the case of neither extra permission should the checkboxes be absent It worked as described. Signed-off-by: Devinim <kohadevinim@devinim.com.tr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21923 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Nick, if we want the sorting to be always consistant, why not to even remove the whole condition? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- if they have neither of those permissions there won't be the extra column, we will sort by the first column so we need the test to know if we wort on index 1 or 2 if we can name the column using class or something for sort instead of using the index that could avoid the conditions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82768|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 82876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82876&action=edit Bug 21778: Sort user list by surname,firstname unless user cannot manage patron lists OR edit patrons To test: 1 - Create four users: 1 superlibrarian (or with both edit patrons and manage patron lists) 1 with only edit patrons and catalogue 1 with only add to list and catalogue 1 with catalogue but neither edit patrons or manage patron lists 2 - Search patrons signed in as each user 3 - Note different sorting 4 - Apply patch 5 - Try searching with each patron 6 - Results should always be sorted by surname, firstname 7 - Only in the case of neither extra permission should the checkboxes be absent Signed-off-by: Devinim <kohadevinim@devinim.com.tr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.01 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 18.05.x for 18.05.08 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21778 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.14 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org