[Bug 36032] New: The "Next" pagination button has a double instead of a single angle
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Bug ID: 36032 Summary: The "Next" pagination button has a double instead of a single angle Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: raphael.straub@kit.edu Reporter: raphael.straub@kit.edu QA Contact: testopia@bugs.koha-community.org The "Next" pagination button in the OPAC result list has a double angle. It should have a single angle as the "Previous" button. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 --- Comment #1 from Raphael Straub <raphael.straub@kit.edu> --- Created attachment 161878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161878&action=edit Bug 36032: Use a single angle in the "Next" button The "Next" pagination button in the OPAC result list has a double angle whereas the "Previous" button only has a single angle. This patch fixes that error. To test: 1) Do a search in the OPAC with more than one page of results. 2) Observe that the "Next" button has a double angle whereas the "Previous" button has only a single angle. 3) Apply the patch. 4) Repeat steps 1 and 2. 5) Verify that the "Next" button now has a single angle. Sponsored-by: Karlsruhe Institute of Technology (KIT) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Raphael Straub <raphael.straub@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161878|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 161927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161927&action=edit Bug 36032: Use a single angle in the "Next" button The "Next" pagination button in the OPAC result list has a double angle whereas the "Previous" button only has a single angle. This patch fixes that error. To test: 1) Do a search in the OPAC with more than one page of results. 2) Observe that the "Next" button has a double angle whereas the "Previous" button has only a single angle. 3) Apply the patch. 4) Repeat steps 1 and 2. 5) Verify that the "Next" button now has a single angle. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |barbara.johnson@bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #161927|0 |1 is obsolete| | --- Comment #3 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 162325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162325&action=edit Bug 36032: Use a single angle in the "Next" button The "Next" pagination button in the OPAC result list has a double angle whereas the "Previous" button only has a single angle. This patch fixes that error. To test: 1) Do a search in the OPAC with more than one page of results. 2) Observe that the "Next" button has a double angle whereas the "Previous" button has only a single angle. 3) Apply the patch. 4) Repeat steps 1 and 2. 5) Verify that the "Next" button now has a single angle. Sponsored-by: Karlsruhe Institute of Technology (KIT) Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov --- Comment #4 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Good catch! Thanks for the fix. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |5287 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Introduced by Bug 5287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5287 [Bug 5287] Add floating toolbar to search results in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like there is the same issue in opac-authoritiessearchresultlist.tt : https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e48451... Can you also fix please ? Or open a new report. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 --- Comment #8 from Raphael Straub <raphael.straub@kit.edu> --- (In reply to Fridolin Somers from comment #7)
Looks like there is the same issue in opac-authoritiessearchresultlist.tt :
https://git.koha-community.org/Koha-community/Koha/src/commit/ 5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/ modules/opac-authoritiessearchresultlist.tt#L33
I already saw this, but I don't know where this is used or if this is used at all. If I search for authorities I get a result list that uses the other pagination bar: https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e48451... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|24.05.00 |24.05.00,23.05.10 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for 23.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Version(s)|24.05.00,23.05.10 |24.05.00,23.11.04,23.05.10 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Phil Ringnalda <phil@chetcolibrary.org> --- This was pushed for 23.11.04 back in March, so it has been pushed to everything above and including the present oldoldstable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 --- Comment #11 from Phil Ringnalda <phil@chetcolibrary.org> --- (In reply to Fridolin Somers from comment #7)
Looks like there is the same issue in opac-authoritiessearchresultlist.tt :
https://git.koha-community.org/Koha-community/Koha/src/commit/ 5a188651e484517f28367e44183b680fa77ad77b/koha-tmpl/opac-tmpl/bootstrap/en/ modules/opac-authoritiessearchresultlist.tt#L33
Can you also fix please ? Or open a new report.
Dead code reintroduced in a rebase failure, filed bug 38462 for removing it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36032 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldoldstable |RESOLVED --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org