https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|856 label is inconsistent |856 label is inconsistent |between detail page and |between detail page and |search results |search results in XSLTs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #2)

For me 'online resources' is the broader term which I think would be a better fit since currently we show all links together, not differentiating between full text and other links (covers, TOCs, reviews, etc.).

Sounds good to me! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This updates the default release notes| |staff interface and OPAC | |XSLT files so that "Online | |resources" is used as the | |label in search results for | |filed 856 - Electronic | |Location and Access, | |instead of "Online access". | |This matches the label used | |in the detail page for a | |record. Patch complexity|--- |String patch Assignee|koha-bugs@lists.koha-commun |david@davidnind.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Legend! I was just thinking how I needed to get around to this, so thanks for taking care of it :). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #8 from David Nind <david@davidnind.com> ---

From what I can tell, no update for UNIMARC is required.

-- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159514|0 |1 is obsolete| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 159562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159562&action=edit Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159562|0 |1 is obsolete| | --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Created attachment 159565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159565&action=edit Bug 35410: Use "Online resources" label in search results Update the staff interface and OPAC XSLT files to use "Online resources" as the label in search results, instead of "Online access". This matches the label used in the detail page for a record. Test plan: 1. Search for perl in the staff interface and OPAC (or add to an existing record a URL to 856$u with 4 for the first indicator). 2. For any search result that displays the "Online access" label, view the detail page for the record. 3. Note that the detail page uses the label "Online resources". 4. Apply the patch and restart_all. 5. Repeat steps 1 and 2. 6. Note that the search result pages now show "Online resources" for the label, matching the detail page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #11 from David Nind <david@davidnind.com> --- Thanks Lucas for the sign-off and David for the QA! David -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This updates the default |This updates the default release notes|staff interface and OPAC |staff interface and OPAC |XSLT files so that "Online |XSLT files so that "Online |resources" is used as the |resources" is used as the |label in search results for |label in search results for |filed 856 - Electronic |field 856 - Electronic |Location and Access, |Location and Access, |instead of "Online access". |instead of "Online access". |This matches the label used |This matches the label used |in the detail page for a |in the detail page for a |record. |record. | | |It also adjusts |It also adjusts |the CSS class so OPAC and |the CSS class so OPAC and |staff interface both use |staff interface both use |online_resources. |online_resources. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 --- Comment #15 from David Cook <dcook@prosentient.com.au> --- (In reply to Katrin Fischer from comment #13)

Note: I like the consistency of the change to the class, but it could have some side effects for existing CSS. I decided to push, because the change is in the staff interface, not in the OPAC.

I was thinking the same thing. Initially, I thought we should've kept the existing class and added the new one, but then I figured since it's the staff interface people can just update on upgrade as needed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35410 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.