[Bug 29585] New: "Go to field" in cataloguing alerts is not translatable
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Bug ID: 29585 Summary: "Go to field" in cataloguing alerts is not translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Depends on: 28450 koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt var subfield=tagsubfieldid.substr(3,1); StrAlert += "<li>"+_("Tag %s subfield %s %s in tab %s").format(tag, subfield, formatFieldName( tabflag[tagsubfieldid][1] ), tabflag[tagsubfieldid][2]) + ' <a class="linkfield btn btn-link" href="#" data-tab="' + tabflag[tagsubfieldid][2] + '" data-field="' + tabflag[tagsubfieldid][3] + '"><i class="fa fa-arrow-right" aria-hidden="true"></i> Go to field</a></li>'; Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 [Bug 28450] Make Account summary print tables configurable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|28450 |28694 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28450 [Bug 28450] Make Account summary print tables configurable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28694 [Bug 28694] Check alert in cataloguing should be a static message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128066&action=edit Bug 29585: Fix unstranslatable strings in addbiblio.tt This patch makes 'Go to field' and 'Errors' strings translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- How can I test this? I thought this would work as I've tested things before for Owen, for example bug 26257. But those were for js strings. Before applying the patch ~~~~~~~~~~~~~~~~~~~~~~~~~ 1. View misc/translator/po/de-DE-staff-prog.po . search for "Go to field" (without the ") . no occurrences found 2. Install the language: . cd misc/translator . perl translate install de-DE 3. Change the staff interface language (System preferences > I18N/L18N > enable language. 4. Change interface to the language. 5. Create a new record. 6. Save. 7. The "Go to field" for the error messages is in English. After applying the patch ~~~~~~~~~~~~~~~~~~~~~~~~ 1. Update the language files: perl translate install de-DE 2. misc/translator/po/de-DE-staff-prog.po should have a translatable string (already translated) for "Go to field". 3. Install the language files: perl translate install de-DE 4. Try creating and saving a record again - the "Go to field" should be in German. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128066|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 128723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128723&action=edit Bug 29585: Fix unstranslatable strings in addbiblio.tt This patch makes 'Go to field' and 'Errors' strings translatable Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi David, thx for trying to test this!
After applying the patch ~~~~~~~~~~~~~~~~~~~~~~~~
1. Update the language files: perl translate install de-DE
This step will install de-DE again, but the po file won't have been updated to have the string yet. So you need to follow the instructions here first: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_... Then you should be able to verify, that the string appeared in the po files and you can edit them to translate them if you want. As this one is an easy fix, I am taking the liberty to move it straight to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Katrin for the link and how to make his work! Noted for any future bug testing... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the 'Go to release notes| |field' and 'Errors' strings | |in the basic MARC editor to | |make them translatable. | |(This is a follow-up to bug | |28694 that changed the way | |validation error messages | |are displayed when using | |the basic MARC editor in | |cataloging.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can this please be pushed before next string freeze? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.05.00 |22.05.00,21.11.03 released in| | Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29585 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |andrew@bywatersolutions.com Status|Pushed to stable |RESOLVED --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Missing dependency, not backported to 21.05 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org