[Bug 37604] New: Give skip_open_orders checkbox an ID in batch record deletion template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Bug ID: 37604 Summary: Give skip_open_orders checkbox an ID in batch record deletion template Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl This is so that clicking on the label will put the cursor focus on the checkbox. At the moment the label and the checkbox are not semantically 'linked' without an ID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy, accessibility Depends on| |27893 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27893 [Bug 27893] Deleting a bibliographic record should warn about attached acquisition orders and cancel them -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Aman <amanpilgrim@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 --- Comment #1 from Aman <amanpilgrim@catalyst.net.nz> --- Created attachment 184260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184260&action=edit Bug 37604 - Give skip_open_orders checkbox an ID in batch record deletion template To Test: 1. Navigate to Home > Cataloging > Batch record deletion 2. Click 'Skip bibliographic records with open acquisition orders' to toggle the Record type checkbox -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Aman <amanpilgrim@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amanpilgrim@catalyst.net.nz |ity.org | CC| |amanpilgrim@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 184275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184275&action=edit Bug 37604: Add an ID to the batch record deletion "Skip biblio...." checkbox This patch adds an ID to the "Skip bibliographic records with open acquisition orders" checkbox on the batch record deletion page (Cataloging > Batch editing > Batch record deletion". This is required so that when selecting or unselecting the checkbox, the focus remains on the checkbox. Test plan: 1. Navigate to Home > Cataloging > Batch record deletion 2. Click 'Skip bibliographic records with open acquisition orders' to toggle the Record type checkbox (selected by default). 3. Inspect the page (right click the page, select Inspect, and look at the values in the checheckbox input field): . before the patch there is no id for the field . after the patch there is an id="skip_open_orders" for the checkbox field Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #184260|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an ID release notes| |to the "Skip bibliographic | |records with open | |acquisition orders" | |checkbox on the batch | |record deletion page | |(Cataloging > Batch editing | |> Batch record deletion"). | | | |This is required so that | |when selecting or | |unselecting the checkbox, | |the focus remains on the | |checkbox. [This needs | |updating to reflect the | |problem it solves.] --- Comment #3 from David Nind <david@davidnind.com> --- Thanks for the patch Aman! I've signed off the patch, as it does add an ID to the checkbox. However, I don't exactly understand what is changed or why (I didn't notice any change in behavour) - probably reflecting my lack of accessibility related knowledge! I also updated the commit message (see the commit message guidelines https://wiki.koha-community.org/wiki/Commit_messages). I changed the format of the title and added a description - it should describe what problem the patch solves. I've also added a draft release note. This should be updated to reflect what the problem is that it solves. David Nind -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184275|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184276&action=edit Bug 37604: Add an ID to the batch record deletion "Skip biblio...." checkbox This patch adds an ID to the "Skip bibliographic records with open acquisition orders" checkbox on the batch record deletion page (Cataloging > Batch editing > Batch record deletion". This is required so that when selecting or unselecting the checkbox, the focus remains on the checkbox. Test plan: 1. Navigate to Home > Cataloging > Batch record deletion 2. Click 'Skip bibliographic records with open acquisition orders' to toggle the Record type checkbox (selected by default). 3. Inspect the page (right click the page, select Inspect, and look at the values in the checheckbox input field): . before the patch there is no id for the field . after the patch there is an id="skip_open_orders" for the checkbox field Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 --- Comment #5 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #3)
However, I don't exactly understand what is changed or why (I didn't notice any change in behavour) - probably reflecting my lack of accessibility related knowledge!
Thanks David - I half explained it in the description but could be more clear! Adding an ID to semantically link the label to the checkbox is important for those using screen readers or keyboard navigation to interact reliably with the form. Many users will be able to look at the label and checkbox and see that they are laid out next to each other and assume they are related. However, adding the input "id" to match the label "for" tells machines that they are related. Hope that makes sense! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds an ID |This enhancement adds an ID release notes|to the "Skip bibliographic |to the "Skip bibliographic |records with open |records with open |acquisition orders" |acquisition orders" |checkbox on the batch |checkbox on the batch |record deletion page |record deletion page |(Cataloging > Batch editing |(Cataloging > Batch editing |> Batch record deletion"). |> Batch record deletion"). | | |This is required so that |This is required so that |when selecting or |when selecting or |unselecting the checkbox, |unselecting the checkbox, |the focus remains on the |the focus remains on the |checkbox. [This needs |checkbox. The ID |updating to reflect the |semantically links the |problem it solves.] |checkbox to its label so | |machines (screenreaders and | |computers) can tell they | |are related elements. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37604 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #10 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org