[Bug 40647] New: "dictionary" misspelled in rep_dictonary class
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Bug ID: 40647 Summary: "dictionary" misspelled in rep_dictonary class Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 38521 On bug 38521 I misspelled "dictionary" in the class for the Reports Dictionary. It's missing the second "i" To observe: - go to /cgi-bin/koha/reports/reports-home.pl - inspect the label "Reports dictionary" - see that it has the class "rep_dictonary" Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38521 [Bug 38521] Add classes to reports homepage -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 --- Comment #1 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 185378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185378&action=edit Bug 40647: Spell dictionary correctly To test: 1 - go to reports home 2 - inspect Reports dictionary 3 - see that it has class rep_dictonary 4 - apply patch, reload page 5 - see that class is now rep_dictionary -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman@koha-suomi. | |fi Status|Needs Signoff |Signed Off --- Comment #2 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I tested this in a Bywater's sandbox but signing off did not work there so I'll just confirm here that the class was correct after I applied the batch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #3 from Anneli Österman <anneli.osterman@koha-suomi.fi> --- I asked in Mattermost (https://chat.koha-community.org/koha-community/pl/wweqmk9ap7ys3miu67kwjdhziy) about the error I got and Katrin recommended to set this bug as Patch does not apply. The error while trying to sign of was: Saved working directory and index state WIP on main: 8d31c2e067 Bug 40608: (QA follow-up) Delete notice in test, adjust about.tt /bin/sh: 1: Ãsterman: not found fatal: It looks like 'git am' is in progress. Cannot rebase. On branch main Your branch is up to date with 'origin/main'. You are in the middle of an am session. (fix conflicts and then run "git am --continue") (use "git am --skip" to skip this patch) (use "git am --abort" to restore the original branch) Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) [31mmodified: koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt[m no changes added to commit (use "git add" and/or "git commit -a") Dropped refs/stash@{0} (815c81d5a813e5b61b1246fa5dcffbd86f9fad4c) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Bug 40647 depends on bug 38521, which changed state. Bug 38521 Summary: Add classes to reports homepage https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38521 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185378|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 185405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185405&action=edit Bug 40647: Spell dictionary correctly To test: 1 - go to reports home 2 - inspect Reports dictionary 3 - see that it has class rep_dictonary 4 - apply patch, reload page 5 - see that class is now rep_dictionary Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a spelling error release notes| |in the class name on the | |reports home page in the | |staff interface: | |"rep_dictonary" to | |"rep_dictionary". Patch complexity|--- |Trivial patch CC| |david@davidnind.com Status|Patch doesn't apply |Needs Signoff --- Comment #5 from David Nind <david@davidnind.com> --- Hi Anneli. There must be something wrong with the sandboxes today - I tried and had issues. However, in a local development environment (KTD) things work fine. I've added a sign-off line with your details to the patch. If you can change the status to signed off, you will get the credit on the dashboard. David Nind -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |andrew@bywatersolutions.com |ity.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Anneli Österman <anneli.osterman@koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185405|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 185437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185437&action=edit Bug 40647: Spell dictionary correctly To test: 1 - go to reports home 2 - inspect Reports dictionary 3 - see that it has class rep_dictonary 4 - apply patch, reload page 5 - see that class is now rep_dictionary Signed-off-by: Anneli Österman <anneli.osterman@koha-suomi.fi> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 --- Comment #7 from David Nind <david@davidnind.com> --- Looks good to me (and something I can QA). QA script is happy as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |david@davidnind.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate --- Comment #9 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Please backport to 25.05 to save users from my poor spelling :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.03 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 --- Comment #10 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #11 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de Keywords|rel_25_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #12 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40647 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #13 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org