[Bug 38657] New: Previewing cover images from OPAC search results - image obscured by the search results menu bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Bug ID: 38657 Summary: Previewing cover images from OPAC search results - image obscured by the search results menu bar Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org With cover images enabled, if you click on the cover image in the OPAC search results, the image preview is partially hidden behind the search results menu bar. This may depend a little on the size of the image uploaded or returned from the cover image service. To replicate: 1. Enable LocalCoverImages and OPACLocalCoverImages system preferences. 2. Add a cover image to a record. 3. In the OPAC: 3.1 Do a search that will return the record with the cover image in the search results 3.2 Click on the cover image in the search results list 3.3 Note that the image is partially obscured behind the search results menu bar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 175328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175328&action=edit Screenshot: cover image preview from OPAC search results partially obscured by the menu bar Screenshot showing the image preview being partially obscured by the search results menu bar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 175329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175329&action=edit Bug 38657: Prevent cover image from being from being obscured by the search results toolbar On the OPAC search results page we're including the Chocolat image viewer CSS after our global CSS file. This means that rules which are intended to override the default Chocolat CSS aren't working. The fix is to move the line which includes the Chocolat CSS. To test, apply the patch and enable the LocalCoverImages and OPACLocalCoverImages system preferences. - If necessary, add a local cover image to a bibliographic record. - Go to the OPAC and perform a search which will return multiple record including the record with the cover image. - Click the cover image to trigger the image viewer. - The image viewer should not appear to be "behind" the search results toolbar. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 [Bug 26933] Improve handling of multiple covers on catalog search results in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175329|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 175330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175330&action=edit Bug 38657: Prevent cover image from being from being obscured by the search results toolbar On the OPAC search results page we're including the Chocolat image viewer CSS after our global CSS file. This means that rules which are intended to override the default Chocolat CSS aren't working. The fix is to move the line which includes the Chocolat CSS. To test, apply the patch and enable the LocalCoverImages and OPACLocalCoverImages system preferences. - If necessary, add a local cover image to a bibliographic record. - Go to the OPAC and perform a search which will return multiple record including the record with the cover image. - Click the cover image to trigger the image viewer. - The image viewer should not appear to be "behind" the search results toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |cover images in the OPAC - | |the image viewer was | |appearing behind the search | |results toolbar, partially | |obscuring the cover image. Summary|Previewing cover images |Previewing cover images |from OPAC search results - |from OPAC search results - |image obscured by the |image obscured by the |search results menu bar |search results toolbar --- Comment #4 from David Nind <david@davidnind.com> --- Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Bug 38657 depends on bug 26933, which changed state. Bug 26933 Summary: Improve handling of multiple covers on catalog search results in the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26933 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175330|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175590&action=edit Bug 38657: Prevent cover image from being from being obscured by the search results toolbar On the OPAC search results page we're including the Chocolat image viewer CSS after our global CSS file. This means that rules which are intended to override the default Chocolat CSS aren't working. The fix is to move the line which includes the Chocolat CSS. To test, apply the patch and enable the LocalCoverImages and OPACLocalCoverImages system preferences. - If necessary, add a local cover image to a bibliographic record. - Go to the OPAC and perform a search which will return multiple record including the record with the cover image. - Click the cover image to trigger the image viewer. - The image viewer should not appear to be "behind" the search results toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Previewing cover images |Image obscured by the |from OPAC search results - |search results toolbar when |image obscured by the |previewing cover images |search results toolbar |from OPAC search results -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- not backporting to 24.05.x unless requested - dependency not in 24.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.05.00 |25.05.00,24.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Pushed to 24.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38657 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #10 from David Nind <david@davidnind.com> --- Bug fix, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org