[Bug 30713] New: Patron entry should limit date of birth selection to dates in the past
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Bug ID: 30713 Summary: Patron entry should limit date of birth selection to dates in the past Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com In the patron entry form, the calendar widget lets the user pick dates in the future. It should require dates in the past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134753&action=edit Bug 30713: Patron entry should limit date of birth selection to dates in the past This patch adds to the configuration of the date of birth field in the patron entry form so that the calendar widget prohibits the selection of a date in the future. To test, apply the patch and open a patron record for editing. Try to select a birth date in the future using the calendar widget. You should be limited to a selection of yesterday or before. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Hi Owen. This does change the calendar widget, but clicking on 'Yesterday' clears an existing date in the input field and doesn't put yesterday's date in for both an existing patron and a new patron (tried in both Firefox Developer Edition and Google Chrome). I can select the date from the date picker, and future dates are not shown. I'm hoping this is something to do with the timezone set for koha-testing-docker and my desktop. David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk Status|Needs Signoff |Failed QA --- Comment #3 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I used a sandbox and get the same result as David. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134753|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 134816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134816&action=edit Bug 30713: Patron entry should limit date of birth selection to dates in the past This patch adds to the configuration of the date of birth field in the patron entry form so that the calendar widget prohibits the selection of a date in the future. To test, apply the patch and open a patron record for editing. Try to select a birth date in the future using the calendar widget. You should be limited to a selection of today or before. Confirm that clicking the "Yesterday" and "Today" shortcuts in the calendar widget works correctly. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> ---
This does change the calendar widget, but clicking on 'Yesterday' clears an existing date in the input field and doesn't put yesterday's date
Further investigation shows that this is a bug in our Flatpickr implementation, not with the change I've made to this particular template. See the "Patrons with no checkouts" report (/cgi-bin/koha/reports/borrowers_out.pl) which has a similarly-configured date picker. While debugging this I did see that I'd missed one of the options Jonathan implemented in Flatpickr: a "pastinclusive" option which limits to dates in the past OR today. This is both more correct for this situation and working correctly, so I have resubmitted with this change. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134816|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 134836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134836&action=edit Bug 30713: Patron entry should limit date of birth selection to dates in the past This patch adds to the configuration of the date of birth field in the patron entry form so that the calendar widget prohibits the selection of a date in the future. To test, apply the patch and open a patron record for editing. Try to select a birth date in the future using the calendar widget. You should be limited to a selection of today or before. Confirm that clicking the "Yesterday" and "Today" shortcuts in the calendar widget works correctly. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 --- Comment #7 from David Nind <david@davidnind.com> --- Thanks Owen for fixing - I wasn't sure I had originally tested it correctly (thanks also Sally for testing and confirming as well!). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134836|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134950&action=edit Bug 30713: Patron entry should limit date of birth selection to dates in the past This patch adds to the configuration of the date of birth field in the patron entry form so that the calendar widget prohibits the selection of a date in the future. To test, apply the patch and open a patron record for editing. Try to select a birth date in the future using the calendar widget. You should be limited to a selection of today or before. Confirm that clicking the "Yesterday" and "Today" shortcuts in the calendar widget works correctly. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the date of release notes| |birth field for the patron | |entry form so that the | |calendar widget does not | |let you select a date in | |the future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30713 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org