[Bug 30864] New: Patron category form - no validation for password expiration field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Bug ID: 30864 Summary: Patron category form - no validation for password expiration field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com When creating a patron category or editing an existing one, there is no validation for the "Password expiration" field. If letters or other characters are entered, there is no error message and if not a number whatever is entered is not saved. To replicate: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Add a new patron category (or edit an existing category). 3. For the "Password expiration" field, enter letters or characters such as L$%. 4. For the "Age required" field, enter letters or characters. 5. Note that for the "Age required" field you are prompted to "Please enter only digits", but for "Password expiration" there is no validation error message. 6. If you save with letters or other characters in the "Password expiration" field, it is shown as a "-" on the patron categories list and is blank when you edit the category. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29924 Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com CC| |jonathan.druart+koha@gmail. | |com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29924 [Bug 29924] Introduce password expiration to patron categories -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 135539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135539&action=edit Bug 30864: Add validation to password_expiry_days When creating a patron category or editing an existing one, there is no validation for the "Password expiration" field. If letters or other characters are entered, there is no error message and if not a number whatever is entered is not saved. To test: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Add a new patron category (or edit an existing category). 3. For the "Password expiration" field, enter letters or characters such as L$%. => Note that you are prompted to "Please enter only digits" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135539|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 135555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135555&action=edit Bug 30864: Add validation to password_expiry_days When creating a patron category or editing an existing one, there is no validation for the "Password expiration" field. If letters or other characters are entered, there is no error message and if not a number whatever is entered is not saved. To test: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Add a new patron category (or edit an existing category). 3. For the "Password expiration" field, enter letters or characters such as L$%. => Note that you are prompted to "Please enter only digits" Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #135555|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 135676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135676&action=edit Bug 30864: Add validation to password_expiry_days When creating a patron category or editing an existing one, there is no validation for the "Password expiration" field. If letters or other characters are entered, there is no error message and if not a number whatever is entered is not saved. To test: 1. Go to Administration > Patrons and circulation > Patron categories. 2. Add a new patron category (or edit an existing category). 3. For the "Password expiration" field, enter letters or characters such as L$%. => Note that you are prompted to "Please enter only digits" Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This adds validation to the release notes| |"Password expiration" field | |on the patron category | |form. If letters or other | |characters were entered, | |there was no error message. | |If what was entered was not | |a number, then it was not | |saved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30864 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.03 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org