[Bug 10145] New: The acquisition details block is badly placed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Bug ID: 10145 Summary: The acquisition details block is badly placed Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com CC: colin.campbell@ptfs-europe.com Bug 5335 introduced a new "Acquisition details" block on the subscription details page. It is placed between to tabs and causes an ergonomic issue. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |serials/subscription-detail | |.pl?subscriptionid= -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 17787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17787&action=edit Bug 10145: The acquisition details block is badly placed. Bug 5335 introduced a new "Acquisition details" block on the subscription details page. It is placed between to tabs and causes an ergonomic issue. Test plan: - Order a subscription. - Go on the subscription detail page and select a tab. - The "Acquisition details" block is moved from the bottom to the top of the table. - Apply the patch - The "Acquisition details" block is always on the bottom of the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Component|Serials |Templates Assignee|jonathan.druart@biblibre.co |oleonard@myacpl.org |m | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can we get a sign off for this? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17787|0 |1 is obsolete| | --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Created attachment 17863 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17863&action=edit [SIGNED OFF] Bug 10145: The acquisition details block is badly placed. Bug 5335 introduced a new "Acquisition details" block on the subscription details page. It is placed between to tabs and causes an ergonomic issue. Test plan: - Order a subscription. - Go on the subscription detail page and select a tab. - The "Acquisition details" block is moved from the bottom to the top of the table. - Apply the patch - The "Acquisition details" block is always on the bottom of the table. Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook@prosentient.com.au --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Works great. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #17863|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 17866 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17866&action=edit [PASSED QA] Bug 10145: The acquisition details block is badly placed. Bug 5335 introduced a new "Acquisition details" block on the subscription details page. It is placed between to tabs and causes an ergonomic issue. Test plan: - Order a subscription. - Go on the subscription detail page and select a tab. - The "Acquisition details" block is moved from the bottom to the top of the table. - Apply the patch - The "Acquisition details" block is always on the bottom of the table. Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Fixes display problem, passes all tests. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master and 3.12.x. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Doesn't apply to 3.10.x please rebase if it is needed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10145 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |5343 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to comment #7)
Doesn't apply to 3.10.x please rebase if it is needed
Not needed for 3.10.x In fact, it depends on bug 5343, not 5335. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org