[Bug 10199] New: Move fields type, options and explanation from systempreferences table?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Bug ID: 10199 Summary: Move fields type, options and explanation from systempreferences table? Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: In Discussion Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl CC: gmcharlt@gmail.com Currently, only local use preferences use the fields options and explanation. The normal preferences ignore these fields; they come from the YAML file now (.pref file). The use of type is somewhat hybrid. There are still some references in the code (especially for YesNo), but the preferences script again looks at the YAML file. My question is: Saving a pref file for the local use prefs does not seem an option (at least from the web interface). But could we move them elsewhere? Separate table? Another idea? If you would delete a regular pref from the yaml file now, but not from the database, it will popup without an explanation or an older one and perhaps without options or older options in the local use tab. How do you think that we should resolve this situation best? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9998 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, I am not sure what we would win by dividing local use preferences and normal preferences. Both need a table for the value set to be saved, so 2 tables seem more error prone to me than having one with a few columns unused? I am sorry, but I don't understand the point about deleting the pref from your description. Could you give an example where this is a problem? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10199 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to comment #1)
I am not sure what we would win by dividing local use preferences and normal preferences. Both need a table for the value set to be saved, so 2 tables seem more error prone to me than having one with a few columns unused? Hi Katrin, I agree. If(..) we should move the unused columns, we should leave what we do use in systempreferences. So no completely separate table for local use prefs. Maybe a joined table for options and explanation to remove redundancy? But then we still face this problem: You have local use pref A. Then it becomes a real pref so now its description comes from yaml. But we still have an old description in the joined table..
I am sorry, but I don't understand the point about deleting the pref from your description. Could you give an example where this is a problem? This is only a fictive problem. If you would delete a regular pref (remove it from the preferences file), but somehow not delete if from the table (the dbrev did not work out?). In this case you got a local use pref falling back to the old columns.
-- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org