[Bug 10473] New: Max length should be 2 digit for adding multiple copies in add items page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Bug ID: 10473 Summary: Max length should be 2 digit for adding multiple copies in add items page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: amitddng135@gmail.com CC: m.de.rooy@rijksmuseum.nl I have recently encountered this case in Mysore University. Someone tried to add multiple copies around 50,000. So in this case max digit allow should 2 digit length. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |mtj@kohaaloha.com Assignee|gmcharlt@gmail.com |amitddng135@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #1 from Amit <amitddng135@gmail.com> --- Created attachment 19030 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19030&action=edit Max length should be 2 digit for adding multiple copies in add items page. Test Plan. 1) Create a bibliographic record. 2) Create a item record click on Add multiple copies button a text box appear please enter number of copies you want to add it will not take more than 99. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta@osslabs.biz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P1 - high -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |magnus@enger.priv.no --- Comment #2 from Magnus Enger <magnus@enger.priv.no> --- I disagree with this patch, since I know libraries that need to add more than 99 items at a time. In fact, the library that sponsored the "multiple items" feature in the first place sometimes need to add more than 99 items at a time. If the functionality to set a max number of items is desired, I think it should be made a syspref, so it can be more flexible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Robin Sheat <robin@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin@catalyst.net.nz --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- Another option might be adding a confirmation step if more than 99 are to be added. I imagine that this is an unusual but not unknown case, so adding a single click to "You're adding 31,416 items, please confirm this is correct" might be useful. It wouldn't significantly slow down normal work, but does add a bit of validation. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #4 from Amit <amitddng135@gmail.com> --- Hi Magnus Enger, I think system preference is a right option. User can give the max digit value according to there requirement. Can you please tell me what is the default max digit value? so i can recreate the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #5 from Robin Sheat <robin@catalyst.net.nz> --- IMO, a syspref is a bad idea for a few reasons. 1) Now you're removing flexibility and making things more awkward for that time when you do need to exceed a pre-defined limit, 2) You're attempting to have people make decisions on the sorts of errors that other people are likely to make. They have no reference on this, so won't really be able to do anything meaningful with it, 3) We already have lots of system preferences and adding a new one for something that doesn't really do anything (except interfere, as in #1) seems like the wrong approach. Validate by all means, but make it a soft validation. There's no point having a hard limit. We're just trying to stop typos really. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #6 from Liz Rea <liz@catalyst.net.nz> --- I agree with Robin on this - validate the field, don't force people to set hard limit. Liz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #7 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #5)
Validate by all means, but make it a soft validation. There's no point having a hard limit. We're just trying to stop typos really.
I agree with Robin too! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- I was thinking. Use the biblio with the most items multipled by 10 as an upper limit for items to be added? If a library has 1 item per biblio for everything in their library, what are the odds they will suddenly stock 10 items of the same biblio? You could use a quick check of the number of records in biblioitems as an upper limit. No one is going to double the size of their library in one step, except at the beginning of data entry. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P1 - high |P3 CC| |gmcharlt@gmail.com Severity|major |normal --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to M. Tompsett from comment #8)
You could use a quick check of the number of records in biblioitems as an upper limit. No one is going to double the size of their library in one step, except at the beginning of data entry.
... until we run into a user that wants to create a few thousand items for their photography collection or something. It could happen! I agree with Robin. A hard-coded soft limit to catch typos is fine; IMO we'd need to see a lot more evidence that this is a problem that folks run into often before we get any fancier. I also don't think it is a major bug, so I'm resetting the severity accordingly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19030|0 |1 is obsolete| | --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 31722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31722&action=edit Bug 10473 - Max length should be 2 digit for adding multiple copies in add items page As per the discussion, a prompt on a hard coded soft-limit is far more acceptable as a solution. TEST PLAN --------- 0) Back up your DB. -- because a backup is always good! 1) Log in to staff client 2) Navigate to any biblio details (e.g. cgi-bin/koha/catalogue/detail.pl?biblionumber=#####) 3) Click the 'Edit' dropdown button. 4) Click 'Edit items'. 5) Click 'Add multiple items' 6) Enter a crazy high number (e.g. 999) 7) Click 'Add' -- Koha just adds it! YIKES! 8) Apply patch 9) Repeat steps 5-7 10) Click 'Cancel' -- Koha does not add the items. 11) Repeat steps 5-7 12) Click 'Ok' -- Koha does add the items. 13) run koha QA test tools 14) Restore your DB. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Max length should be 2 |Prompt for confirmation if |digit for adding multiple |more than 99 items are |copies in add items page |being added -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@ptfs-europe.com --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Patch tested with a sandbox, by Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31722|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 31780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31780&action=edit Bug 10473 - Max length should be 2 digit for adding multiple copies in add items page As per the discussion, a prompt on a hard coded soft-limit is far more acceptable as a solution. TEST PLAN --------- 0) Back up your DB. -- because a backup is always good! 1) Log in to staff client 2) Navigate to any biblio details (e.g. cgi-bin/koha/catalogue/detail.pl?biblionumber=#####) 3) Click the 'Edit' dropdown button. 4) Click 'Edit items'. 5) Click 'Add multiple items' 6) Enter a crazy high number (e.g. 999) 7) Click 'Add' -- Koha just adds it! YIKES! 8) Apply patch 9) Repeat steps 5-7 10) Click 'Cancel' -- Koha does not add the items. 11) Repeat steps 5-7 12) Click 'Ok' -- Koha does add the items. 13) run koha QA test tools 14) Restore your DB. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org --- Comment #13 from Nick Clemens <nick@quecheelibrary.org> --- Just adding the comment that I, personally, don't like the placeholder '3' and find it confusing for the general user. I don't think it fails for that though. I also didn't run QA tools as was on sandbox -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #14 from M. Tompsett <mtompset@hotmail.com> --- I'm willing to remove the placeholder, if you prefer, Nick. I just thought by putting a single digit number, it might help unconsciously lead people to type smaller, more valid numbers. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #15 from Nick Clemens <nick@quecheelibrary.org> --- Fair enough, I was just thinking of the questions I anticipated from librarians in the system about why they were seeing a number there. It seemed unusual to me for Koha to suggest a value in a field, I almost wondered if it was a new default of 3 at first glance. I think it could go either way, my opinion is definitely not always the common one, or even the correct one :) Leave it for QA to weigh in? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- I am not fond of the placeholder neither. Magnus, Robin, Liz and Galen, can we have your point of view on this new patch? IMO it is a good compromise: it only alerts the user that he entered a huge number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #17 from Magnus Enger <magnus@enger.priv.no> --- (In reply to Jonathan Druart from comment #16)
I am not fond of the placeholder neither.
Magnus, Robin, Liz and Galen, can we have your point of view on this new patch? IMO it is a good compromise: it only alerts the user that he entered a huge number.
THe warning/alert sounds good to me. I'd vote to get rid of the placeholder. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31780|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31889 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31889&action=edit Bug 10473 - Max length should be 2 digit for adding multiple copies in add items page As per the discussion, a prompt on a hard coded soft-limit is far more acceptable as a solution. TEST PLAN --------- 0) Back up your DB. -- because a backup is always good! 1) Log in to staff client 2) Navigate to any biblio details (e.g. cgi-bin/koha/catalogue/detail.pl?biblionumber=#####) 3) Click the 'Edit' dropdown button. 4) Click 'Edit items'. 5) Click 'Add multiple items' 6) Enter a crazy high number (e.g. 999) 7) Click 'Add' -- Koha just adds it! YIKES! 8) Apply patch 9) Repeat steps 5-7 10) Click 'Cancel' -- Koha does not add the items. 11) Repeat steps 5-7 12) Click 'Ok' -- Koha does add the items. 13) run koha QA test tools 14) Restore your DB. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31890 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31890&action=edit Bug 10473: Get rif of the placeholder This placeholder is not really relevant here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- I let the RM to decide about the placeholder. I think the commit message should be rewrite too. Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|amitddng135@gmail.com |mtompset@hotmail.com QA Contact| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33577 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33577&action=edit Bug 10473: (RM followup) small wording change Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10473 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org