[Bug 11169] New: Display an acquisition details tab
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Bug ID: 11169 Summary: Display an acquisition details tab Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Component|OPAC |Acquisitions Assignee|oleonard@myacpl.org |jonathan.druart@biblibre.co | |m Summary|Display an acquisition |OPAC: Display an |details tab |acquisition details tab -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #1 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22594 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22594&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22595 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22595&action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Depends on| |5336 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11847 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25654 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25654&action=edit MT12445: Hide the date_due column The date due information is useless for in order items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25654|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25657&action=edit Bug 11169: Hide the date_due column The date due information is useless for in order items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #5 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- he sandbox you've requested is not ready. Some problems occurred applying patches from bug 11169: <h1>Something went wrong !</h1>Applying: Bug 11169: Display acquition details at the OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Auto-merging opac/opac-detail.pl CONFLICT (content): Merge conflict in opac/opac-detail.pl Failed to merge in the changes. Patch failed at 0001 Bug 11169: Display acquition details at the OPAC When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11169 - OPAC: Display an acquisition details tab 22594 - Bug 11169: Display acquition details at the OPAC 22595 - Bug 11169: [Bootstrap] Display acquition details at the OPAC 25657 - Bug 11169: Hide the date_due column Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-11169-Display-acquition-details-at-the-OPAC-CZbyQZ.patch . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22594|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26082&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22595|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26083&action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25657|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26084&action=edit Bug 11169: Hide the date_due column The date due information is useless for in order items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- Tests made with : - AcqCreateItems pref to 'receiving' ok, we can retrieve the title in OPAC with a tab "acquitision details" indicating the number of items in the order. (just a comment : when there's only one item, we can see "1 items are on order" : can you put it singular ?) it's the same whatever the basket is open, closed, in a basketgroup or not. If there's a partial receipt, the number of order decrease of the right number. When all items have been received, the tab disappears. After a transfer of command it's also ok. When you cancel a receipt, the tab reappears with the right number to be received.(But It's a pity that the items stay the items stays in tab "Holdings".) - AcqCreateItems pref to 'ordering' ok, we can retrieve the title in OPAC with a tab "acquitision details", with a table of the items in order. it's the same whatever the basket is open, closed, in a basketgroup or not. If there's a partial receipt, only the item in order stay in the table. When all items have been received, the tab disappears. After a transfer of command it's also ok. When you cancel a receipt, the tab reappears with the good number to be received. But, there's something I don't see in the master, so I wonder that's introduced by this patch : if you do a partial receipt, You can't cancel the first items you received. You can only cancel the last one. I changed in "failed QA" for this. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Koha Team Lyon 3 from comment #9)
But, there's something I don't see in the master, so I wonder that's introduced by this patch : if you do a partial receipt, You can't cancel the first items you received. You can only cancel the last one. I changed in "failed QA" for this.
It is not introduced by this patch. It looks the same issue that bug 11744. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 jmbroust <jean-manuel.broust@univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jean-manuel.broust@univ-lyo | |n2.fr --- Comment #11 from jmbroust <jean-manuel.broust@univ-lyon2.fr> --- <h1>Something went wrong !</h1>Applying: Bug 11169: Display acquition details at the OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Acquisition.pm CONFLICT (content): Merge conflict in C4/Acquisition.pm Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Failed to merge in the changes. Patch failed at 0001 Bug 11169: Display acquition details at the OPAC When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 11169 - OPAC: Display an acquisition details tab 26082 - Bug 11169: Display acquition details at the OPAC 26083 - Bug 11169: [Bootstrap] Display acquition details at the OPAC 26084 - Bug 11169: Hide the date_due column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26082|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26330&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26083|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26331 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26331&action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26084|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26332 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26332&action=edit Bug 11169: Hide the date_due column The date due information is useless for in order items. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26331|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26332|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #16 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26343 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26343&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #17 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26344 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26344&action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #18 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 26345 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26345&action=edit Bug 11169: Hide the date_due column The date due information is useless for in order items. Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |imingchan@yahoo.com.au --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 11984 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26343|0 |1 is obsolete| | --- Comment #20 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27018 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27018&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new tab 'Acquisition detail' on the OPAC detail page. A syspref (OPACAcquisitionDetails) permits to turn on this feature. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the right number of items which is in order. - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the "acquitision details" tab contains the list of items which is in order. - receive the items. - verify the received items don't appear anymore in the table. Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26344|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27019 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27019&action=edit Bug 11169: [Bootstrap] Display acquition details at the OPAC Patch for the bootstrap theme. Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26345|0 |1 is obsolete| | --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27020 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27020&action=edit Bug 11169: Hide the date_due column The date due information is useless for in order items. Signed-off-by: Broust <jean-manuel.broust@univ-lyon2.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |gmcharlt@gmail.com --- Comment #23 from Galen Charlton <gmcharlt@gmail.com> --- Is a separate tab really necessary? If the goal is to give patron information that new items are coming, I think it sufficient to: - display an on-order status in the OPAC holdings tab if items are creating during ordering - display a statement saying "X items are on order" (or "X items are on order as of $date" to take bug 11847 into account). Setting to in discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #24 from Iming Chan <imingchan@yahoo.com.au> --- Hi Galen, I don't believe a separate tab is really necessary. It should be provided like "holds" (reservations). I like your idea just to give acquisition information in the OPAC holdings tab ** AND ** display a date when X item(s) is/are on order. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #25 from David Cook <dcook@prosentient.com.au> --- (In reply to Galen Charlton from comment #23)
Is a separate tab really necessary?
If the goal is to give patron information that new items are coming, I think it sufficient to:
- display an on-order status in the OPAC holdings tab if items are creating during ordering - display a statement saying "X items are on order" (or "X items are on order as of $date" to take bug 11847 into account).
Setting to in discussion
Agreed. I think that this or something similar would be all that is necessary. Furthermore, I don't really like the idea of having an "acquisitions details" tab as it doesn't seem very user centred in design. As a library patron, I might not understand or want to understand anything related to "acquisitions". I just want to know if an item is on order, and when it's going to arrive/when the order was placed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathsabypro@gmail.com --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 9441 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27018|0 |1 is obsolete| | Attachment #27019|0 |1 is obsolete| | Attachment #27020|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28045 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28045&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new system preference 'OPACAcquisitionDetail'. If it is enabled, information about items on order will be displayed on the OPAC detail page. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "Holdings" tab contains the line "X item are on order." (at the bottom of the table containing the item list). - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the item list contains the items with the "on order" status. - receive the items. - verify the received items don't have anymore the "on order" status. To test completely this feature, you should verify there is no regression on the pref OpacMaxItemsToDisplay, OpacSeparateHoldings and OpacSeparateHoldingsBranch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #28 from Jonathan Druart <jonathan.druart@biblibre.com> --- I rewrote this patch. I removed the new tab and added the information about items on ordered into the Holdings tab. Note that I dropped the support for the prog theme. Back to Needs Signoff. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |paola.rossi@cineca.it --- Comment #29 from Paola Rossi <paola.rossi@cineca.it> --- I test against 3.15.00.052 When I go to the opac, and I select the opac detail page of a biblio, the system answers: Software error: Undefined subroutine &C4::Acquisition::SearchOrders called at /var/root-koha/bug-11169/opac/opac-detail.pl line 603. So I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28045|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28419&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new system preference 'OPACAcquisitionDetail'. If it is enabled, information about items on order will be displayed on the OPAC detail page. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "Holdings" tab contains the line "X item are on order." (at the bottom of the table containing the item list). - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the item list contains the items with the "on order" status. - receive the items. - verify the received items don't have anymore the "on order" status. To test completely this feature, you should verify there is no regression on the pref OpacMaxItemsToDisplay, OpacSeparateHoldings and OpacSeparateHoldingsBranch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #31 from Paola Rossi <paola.rossi@cineca.it> --- I apply the patch against master 3.15.00.052 --------------------------------------------------------------- 1) About the preference "AcqCreateItem" set to 'receiving an order', the manual 3.16 says: If you choose to add the item when 'receiving an order' you will be asked for item record information when you're receiving orders in acquisitions. At step 3 the plan requires: create some orders on 1 or more items So, if I add x (1 or more) items to the biblio, before creating the order for the biblio, the step 4 is OK: on OPAC opac-details, I see: Holdings (x) [table of items] x items are on order. But, if the plan at step 3 means (according the manual): create some orders _of_ 1 or more items [for a biblio without items] the step 4 is not OK: on OPAC opac-details, I see this tab for the biblio: Holdings (0) No physical items for this record and no "X item are on order". -------------------------------------------------------------- 2) At step 9, preference "AcqCreateItem" set to 'placing an order': for an order of x items, the item list contains 2x items: x items in "Available" status, and x items in "on order" status. After receiving (step 11), the items in "on order" status disappear. -------------------------------------------------------------- I beg your pardon if I'm wrong. I pass the patch to "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #32 from Paola Rossi <paola.rossi@cineca.it> --- Against the master 3.17.00.001 the patch needs to be rebased: Applying: Bug 11169: Display acquition details at the OPAC Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Failed to merge in the changes. Patch failed at 0001 Bug 11169: Display acquition details at the OPAC So I pass the patch from "Failed QA" status (please see comment n.31) to "Patch doesn't apply" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28419|0 |1 is obsolete| | --- Comment #33 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28483 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28483&action=edit Bug 11169: Display acquition details at the OPAC This patch adds a new system preference 'OPACAcquisitionDetail'. If it is enabled, information about items on order will be displayed on the OPAC detail page. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "Holdings" tab contains the line "X item are on order." (at the bottom of the table containing the item list). - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the item list contains the items with the "on order" status. - receive the items. - verify the received items don't have anymore the "on order" status. To test completely this feature, you should verify there is no regression on the pref OpacMaxItemsToDisplay, OpacSeparateHoldings and OpacSeparateHoldingsBranch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #31)
I beg your pardon if I'm wrong. I pass the patch to "Failed QA" status.
No, you were right. That was completely buggy! Good catch. The last patch should solve these issues. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. I apply against master 3.17.00.007 Everything's OK, except for regression of OpacSeparateHoldingsBranch. On master, "Separate"-ing on "Home library" selects and lists in the first tab the items whose home (alias permanent) library is the user's login (i.e. patron's) library. On the contrary, if I'm not wrong, the patch selects and lists in the first tab the items whose current library is the patron's library. NB. On OPAC, the items' "permanent library" is not shown: the column is the "Current location", I mean the current library. So the items' permanent library is not able to be seen on OPAC. I hope to be right, otherwise I beg your pardon. I pass the patch the "Failed QA" status. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28511 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28511&action=edit Bug 11169: Fix branch name -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #37 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Paola Rossi from comment #35) Paola, I am not sure to understand the problem. I provided a patch, but I am not sure it will fix what you described. If not, could you please detail step by step how to reproduce it? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #38 from Paola Rossi <paola.rossi@cineca.it> --- Thanks, Jonathan. I beg your pardon, yesterday I didn't realize that on OPAC the "MARC view" shows all locations of an item. So I became confused about the matches I annotate below. NB. The option "home library" of pref "OpacSeparateHoldingsBranch" corresponds to "a-Permanent location" content of an item (additem.pl intranet). And the other option "holding library" corresponds to the following "b-Current location" content of an item. In advanced search, at tab "Holdings" of a biblio on catalogue/details.pl, the columns show mixed names. --------------------------------------------- Today I apply against master 3.17.00.007 I check again the only first patch about the regression. Everything's OK. So I pass the first patch "Display acquisition details at tha OPAC" to the "Signed Off" status. The second patch "Fix branch name" is not needed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28483|0 |1 is obsolete| | Attachment #28511|0 |1 is obsolete| | --- Comment #39 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 28512 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28512&action=edit Bug 11169: Display acquition details at the OPAC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28512|0 |1 is obsolete| | --- Comment #40 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28522&action=edit Bug 11169: Display acquisition details in the OPAC This patch adds a new system preference 'OPACAcquisitionDetail'. If it is enabled, information about items on order will be displayed on the OPAC detail page. Test plan: - switch on the OPACAcquisitionDetails pref. - set the AcqCreateItems pref to 'receiving'. - create some orders on 1 or more items. - go to the opac detail page and verify the "Holdings" tab contains the line "X item are on order." (at the bottom of the table containing the item list). - receive the items. - verify the number of items has decreased. - set the AcqCreateItems pref to 'ordering'. - create some orders on 1 or more items. - go to the opac detail page and verify the item list contains the items with the "on order" status. - receive the items. - verify the received items no longer have the the "on order" status. To test completely this feature, you should verify there is no regression on the pref OpacMaxItemsToDisplay, OpacSeparateHoldings and OpacSeparateHoldingsBranch. Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Galen Charlton <gmc@esilibrary.com> Also removed some blank lines from the original patch and bumped up the DBRev. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #41 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28523&action=edit Bug 11169: (follow-up) add more unit tests This patch adds direct unit tests of the new biblionumber filter for SearchOrders. It also moves the ordernumber filter test to the rest of the SearchOrders tests. To test: [1] Verify that prove -v t/db_dependent/Acquisition.t passes. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #42 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28524&action=edit Bug 11169: (follow-up) only count orders that have been placed This patch ensures that only orders that have been placed (i.e., orders whose basket is closed) are counted in the OPACAcquisitionsDetails display. To test: [1] Turn on OPACAcquisitionsDetails and set AcqCreateItem to 'ordering'. [2] Create an order for a record, but do not close the basket. [3] View the record in the OPAC. It should not display any order count. [4] Close the bakset. [5] View the record in the OPAC again. This time, it should display the count of items on order. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer CC| |chris@bigballofwax.co.nz --- Comment #43 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to MM-OPAC/bug_11169 Please merge at your leisure -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master CC| |tomascohen@gmail.com --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Jonathan and Galen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@pttk.fi --- Comment #45 from paxed <pasi.kallinen@pttk.fi> ---
From i18n viewpoint, hard-coded plural forms are not good:
[% IF acquisition_details.total_quantity == 1 %] 1 item is on order. [% ELSE %] [% acquisition_details.total_quantity %] items are on order. [% END %] See also: http://www.gnu.org/savannah-checkouts/gnu/gettext/manual/html_node/Plural-fo... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #46 from Nicole C. Engard <nengard@gmail.com> --- I am writing this up for the manual but can't seem to make it work. I have the preference set to 'display' but on the titles that have items on order I do no see the acquisitions tab. Will it only work for items ordered after you turn the preference on? Does it depend on another preference? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC: Display an |OPAC: Display an |acquisition details tab |acquisition details --- Comment #47 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Nicole C. Engard from comment #46)
I am writing this up for the manual but can't seem to make it work. I have the preference set to 'display' but on the titles that have items on order I do no see the acquisitions tab. Will it only work for items ordered after you turn the preference on? Does it depend on another preference?
Hi Nicole, Sorry for the delay! Actually in the pushed version, there is no tab! You must have AcqCreateItem != "ordering" to see the information "X items are on order". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #48 from Nicole C. Engard <nengard@gmail.com> --- (In reply to Jonathan Druart from comment #47)
Hi Nicole, Sorry for the delay! Actually in the pushed version, there is no tab! You must have AcqCreateItem != "ordering" to see the information "X items are on order".
Oh! Okay. That makes sense. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #49 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 33522 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33522&action=edit no acq note Hmm, I still don't see it. I set OPACAcquisitionDetails =display and AcqCreateItem = cataloging the item and I placed a new order and the opac looks like the attached image. I don't see the note. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|OPAC: Display an |OPAC: Display acquisition |acquisition details |details -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11169 --- Comment #50 from Paola Rossi <paola.rossi@cineca.it> --- I've created the case of comment 49 against master 3.17.00.054. I hope the following steps be the right ones, and all needed. 1 - I set the syspref "OPACAcquisitionDetails" to "Display" 2 - I set the syspref "AcqCreateItem" to "cataloguing the record" as required 3 - I created a new vendor, with a basket. 4 - I ordered a book from an external source, setting the quantity to X 5 - I closed the basket [either with or without closing also the basketgroup] 6 - [I reindexed zebra to find the book on OPAC] On OPAC I saw "X items are on order. " below the "Holdings ( 0 )" tag of the book. Then I also repeated 1,2,3,5 changing the 4-th step with this one: 4B - I catalogued another book without items, [I reindexed zebra], and I ordered this book "From an existing record", setting the quantity to Y. Again, on OPAC I saw "Y items are on order. " below the "Holdings ( 0 )" tag of the second book. NB. if I reopened the basket, or if I didn't close it, on OPAC I saw "No physical items for this record". -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org