[Bug 12820] New: SIP2 does not send rental charge fee!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Bug ID: 12820 Summary: SIP2 does not send rental charge fee! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Koha's SIP2 implementation has facilities to send the fee amount ( BV ) for checking out a given item, but in our code, the fee amount is never set! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31136&action=edit Bug 12820 - SIP2 does not send rental charge fee! Koha's SIP2 implementation has facilities to send the fee amount ( BV ) for checking out a given item, but in our code, the fee amount is never set! Test Plan: 1) Check out an item with a rental fee via SIP2. 2) Note the BV field is missing. 3) Apply this patch, restart your SIP2 server. 4) Repeat step 1. 5) Note the BV field is now set to the correct value. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31136|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 31153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31153&action=edit Bug 12820 - SIP2 does not send rental charge fee! Koha's SIP2 implementation has facilities to send the fee amount ( BV ) for checking out a given item, but in our code, the fee amount is never set! Test Plan: 1) Check out an item with a rental fee via SIP2. 2) Note the BV field is missing. 3) Apply this patch, restart your SIP2 server. 4) Repeat step 1. 5) Note the BV field is now set to the correct value. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Should we not be using C4::Circulation::GetIssuingCharges to get the amount? This returns the rental fee but also calculates the discount if one is applicable, that step is omitted in this patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Colin, thank you for taking a look. I think you are correct, it won't apply the correct rental charge. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33901 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33901&action=edit Bug 12820 [QA Followup] - Let Koha calculate fee for Checkout -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33901|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33902 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33902&action=edit Bug 12820 [QA Followup] - Let Koha calculate fee for Checkout -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Is this really a follow up or a new patch? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31153|0 |1 is obsolete| | Attachment #33902|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33911 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33911&action=edit Bug 12820 - SIP2 does not send rental charge fee! Koha's SIP2 implementation has facilities to send the fee amount ( BV ) for checking out a given item, but in our code, the fee amount is never set! It's even more complicated than that. If there is a fee, the sip server checks to see if BO ( fee acknowledged ) is set to Y. If it is not, the SIP server is supposed to block the checkout and send a screen message with the fee amount. If it is, the checkout proceeds as usual. Test Plan: 1) Apply the patch for bug 13159 2) Set a checkout fee for an itemtype 3) Find an item of the itemtype 4) Run the SIP cli utility: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_user_password> -l <location> --patron <patron_cardnumber> -m checkout --item <item_barcode> 5) Note the server returns an AF field describing the fee and doesn't check out the item. 6) Rerun step 4 with the addition of the -fa flag 7) Note the item checks out to the patron this time -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13159 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33911|0 |1 is obsolete| | --- Comment #9 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 33994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33994&action=edit Signed Off Patch Tested that with patch applied charge was blocked until fee was submitted and that charge could proceed after acknowledgement. Also tested that issue of items without fees proceeded as expected -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Updated status to signed off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #11 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I tried using the patch on a site and it didnt accept the fee acknowledgement. I've got a fixed patch which a site is testing with some 3M machines, will upload if they dont find any further probs -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33994|0 |1 is obsolete| | Assignee|kyle@bywatersolutions.com |colin.campbell@ptfs-europe. | |com --- Comment #12 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 35878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35878&action=edit Revised Patch Revised patch. Found some problems with earlier patch, i.e. it was not allowing the checkout once the fee was acknowledged (it was bailing out of the routine too early). Also it didnt handle the scenario in renew (renew in MsgType was aware of the field but called routines that ignored it). Have handled it in a way that is consistent with how Renew originally intended. Patch functionality has been tested at Chshire Libraries in the UK who are now live with it -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35878|0 |1 is obsolete| | --- Comment #13 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36155&action=edit Bug 12820: Handle rental fees in Sip issue and renew Implement correct handling of fees associated with checking out an item. This is associated with fee acknowledged field (BO) To quote from the Sip2 document " If this field is N in a Checkout message and there is a fee associated with checking out the item, the ACS should tell the SC in the Checkout Response that there is a fee, and refuse to check out the item. If the SC and the patron then interact and the patron agrees to pay the fee, this field will be set to Y on a second Checkout message, indicating to the ACS that the patron has acknowledged the fee and checkout of the item should not be refused just because there is a fee associated with the item" So there are two Checkout requests the first with BO not set to Y is rejected but the fee amount is returned. The Second Checkout with BO set to Y should succeed. Added a debug log message indicating why we block a checkout when we dont otherwise indicate Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> I tested with telnet and generated sip messages to get response. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36155|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37038&action=edit [PASSED QA] Bug 12820: Handle rental fees in Sip issue and renew Implement correct handling of fees associated with checking out an item. This is associated with fee acknowledged field (BO) To quote from the Sip2 document " If this field is N in a Checkout message and there is a fee associated with checking out the item, the ACS should tell the SC in the Checkout Response that there is a fee, and refuse to check out the item. If the SC and the patron then interact and the patron agrees to pay the fee, this field will be set to Y on a second Checkout message, indicating to the ACS that the patron has acknowledged the fee and checkout of the item should not be refused just because there is a fee associated with the item" So there are two Checkout requests the first with BO not set to Y is rejected but the fee amount is returned. The Second Checkout with BO set to Y should succeed. Added a debug log message indicating why we block a checkout when we dont otherwise indicate Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 37039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37039&action=edit Bug 12820 [QA Followup] - Tab and whitespace cleanup Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks for making SIP support better Colin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.6 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | --- Comment #18 from Mason James <mtj@kohaaloha.com> --- Pushed to 3.16.x, will be in 3.16.10 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on| |7904 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12820 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #19 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Note that this patch was pushed in 3.16.10, whereas 7904 was pushed only in 3.16.11. We noticed SIP checkouts does not work on a 3.16.10. So upgrade is mandatory for SIP users. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org