http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 33369 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33369&action=edit Added Charts to issues report -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 33371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33371&action=edit Added line/bar switch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please add a test plan to make this easier to test! :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This could be a good one for the catalyst academy to extend upon :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Shoudl this be needs sign-off? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Failed QA --- Comment #10 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Hey, nice graphs :) There are some easy to fix tabs, but don't know what to do with this FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_stats.tt FAIL forbidden patterns forbidden pattern: console.log (line 301) OK tt_valid OK valid_template FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt FAIL forbidden patterns forbidden pattern: console.log (line 323) OK tt_valid OK valid_template -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- (In reply to Martin Renvoize from comment #11)

This was more a code example than a submission to be honest ;)

However, the console log lines could be easily removed to clean up the qa warns.. they're only browser logging to show what's going on so someone might take the example code and apply it to more guided reports.

Wan't me to tidy it up a bit?

No problem :) I'll remove tabs and logs. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33369|0 |1 is obsolete| | --- Comment #14 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39778&action=edit [SIGNED-OFF] Bug 13219: Added Charts to issues report http://bugs.koha-community.org/show_bug.cgi?id=13219 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33371|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39780 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39780&action=edit [SIGNED-OFF] Bug 13219: Added line/bar switch http://bugs.koha-community.org/show_bug.cgi?id=13219 Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 39782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39782&action=edit Bug 13219: (followup) remove tabs and console messages To make koha-qa happy Tested, nice graphics. Nice feature to play with :) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13219 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |Failed QA --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comments: 1/ New JS lib is not added to the about page 2/ The version 1.0.2 of Chart is released (after first submission), not need to include a beta version :) 3/ If there is no result, there is no graph. But the canvas is created => 1000x400px is blank on top of the page. Moreover the button ("Click to change to...") is displayed. 4/ There is no way not to hardcode the canvas size? 1000 could be too wide on small screens. 5/ Maybe it could be better to display the graph under the table (?) 6/ Commented code in js (//circChart.update();) 7/ IMO the colors should not be defined in the pl code but in tt. Moreover the get_colors subroutine is defined twice (c/p is bad ;)) Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.