[Bug 33997] New: Borrowers.updated_on should not be updated by track_login
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Bug ID: 33997 Summary: Borrowers.updated_on should not be updated by track_login Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently borrowers.updated_on is updated by track_login even though a login is not an update to the patron record. This update needs to be blocked so that the updated_on field accurately reflects updates to the patron. Logins are supposed to be tracked by borrowers.lastseen which track_login already does. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 152294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152294&action=edit Bug 33997: Stop track_login from updating borrowers.updated_on This patch blocks the update to borrowers.updated_on when track_login is called Test plan: 1) Enable syspref 'TrackLastPatronActivity' 2) Log into the OPAC 3) Check the database for the patron/account used and observe that the timestamps for updated_on and lastseen match 4) reset_all 5) Apply patch 6) Repeat steps one to three, the updated_on timestamp should not have changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #152294|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 152321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152321&action=edit Bug 33997: Stop track_login from updating borrowers.updated_on This patch blocks the update to borrowers.updated_on when track_login is called Test plan: 1) Enable syspref 'TrackLastPatronActivity' 2) Log into the OPAC 3) Check the database for the patron/account used and observe that the timestamps for updated_on and lastseen match 4) reset_all 5) Apply patch 6) Repeat steps one to three, the updated_on timestamp should not have changed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15504 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Please provide a test. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 152342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=152342&action=edit Bug 33997: (QA follow-up) Add unit test This patch adds a unit test prove -v t/db_dependent/Members.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Matt Blenkinsop from comment #0)
Currently borrowers.updated_on is updated by track_login even though a login is not an update to the patron record. This update needs to be blocked so that the updated_on field accurately reflects updates to the patron. Logins are supposed to be tracked by borrowers.lastseen which track_login already does.
I am not so sure if this statement is true. A timestamp should reflect a change on the record. And a change to lastseen is also a change of the patron record. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Should this be yet another system preference then Marcel? We felt this change, along with bug 15504, significantly clarified how updated_on and lastseen complimented each other and worked. I'd like some librarian opinions on this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6)
Should this be yet another system preference then Marcel? We felt this change, along with bug 15504, significantly clarified how updated_on and lastseen complimented each other and worked. I'd like some librarian opinions on this.
YASP: Yet another sys pref :) Not necessarily. Could we think of fields in the borrowers table that are not really part of your patron record definition like lastseen and move them to a separate table perhaps ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have to admit I had the same feeling as Marcel when I saw this bug. Moving to a separate table seems a bit of overkill. What is the use case that triggered this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- We had a customer who were trying to run a report to remove patrons who had been inactive for more than 5 years. They were trying to run this based on borrowers.updated_on rather than borrowers.lastseen which seems more practical for this scenario. Essentially my assumption was that updated_on was for updates to patron record details and lastseen was more for activity tracking so updated_on being updated by a login didn't seem to fit with that logic. I'm not clued up on the history behind these two fields though so that assumption is open for correction. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We have more and more customers using the REST API's and the 'updated_on' field is consistently presumed to actually signify a change to the patrons record... filtering upon it and finding you're results include lots and lots of records where no change has really taken place is both a performance issue and a confusion for end users of the API's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd also argue that perhaps login_attempts shouldn't update the updated_on field either... but that's for another day. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- I still think that if we need a specific timestamp for selected changes, than we should add a new field for that. And leave updated_on to what it is or even should be ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #13 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Mailing QA team -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #14 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #12)
I still think that if we need a specific timestamp for selected changes, than we should add a new field for that. And leave updated_on to what it is or even should be ?
(In reply to Martin Renvoize from comment #10)
We have more and more customers using the REST API's and the 'updated_on' field is consistently presumed to actually signify a change to the patrons record... filtering upon it and finding you're results include lots and lots of records where no change has really taken place is both a performance issue and a confusion for end users of the API's.
I started out agreeing with Martin, but now agree with Marcel. We should maybe have an 'edited_on' field for "changes" to the record If 'updated_on' is used for syncing to outside systems, and those systems use lastseen then they will want to update those patrons - e.g. an outside email service for contacting only recently active patrons, or one that does stats for a library on 'active' patrons - we wouldn't capture patrons active only on overdrive or other services if we don't see a patron as having been 'updated' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15504 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 [Bug 15504] Track Patron's Last Activity -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- We're removing the dependency on this from bug 15504 as this is holding everything up and that's an important bug for us. I don't think it's a great idea having two synonym fields, edited_on and updated_on, and personally I think 'updated_on' really does suggest it's actual record updates and not a timestamp for any and all, unrelated, changes. I'd rather see fields split out of borrowers and properly database normalised if we're going down this path. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15504 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35508 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Irene <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33997 Donna <bwsdonna@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna@gmail.com --- Comment #16 from Donna <bwsdonna@gmail.com> --- Now that "last seen on" is displaying in the patron record, we are basically showing the same data twice. From talking with a number of library staff, updated on is understood as "when is the last time the INFORMATION in the patron record was edited/ updated." This is critical information to have for staff so they know immediately whether they need to ask provide/verify current personal information. Can we please either have updateon reflect the last time the patron's account was edited, or replace updateon in the patron display with "edited on" or something? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org