https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us --- Comment #2 from Rebecca Coert <rcoert@arlingtonva.us> --- We'd like to have Claims Returned (CR) be a separate category. An item can be both checked out, Overdue, or Lost (i.e.: Lost, Long Overdue (Lost)) and CR at the same time; however, they are currently sharing the "Lost Status" field. We view the claim as separate from an item's status. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Ashley Johnson <ajohnson@jcls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ajohnson@jcls.org --- Comment #4 from Ashley Johnson <ajohnson@jcls.org> --- Agreed. Our library system has wrestled with this as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 hebah@bywatersolutions.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hebah@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I'm broadly in favor of this change. It seems like divorcing CR from Lost would allow more flexibility in how CR works. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33292 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 [Bug 33292] Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #10 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- (In reply to Lisette Scheer from comment #7)

If an item is marked long overdue lost, then is claimed returned, then is returned, the lost fine won't be refunded, even if the circulation rules say it should be.

I cannot recreate this behavior on main. I checked out an item, marked it lost and confirmed the creation of a charge, marked it claimed, and checked it in. Koha gave me its standard "A refund for the lost item charge has been applied ..." message and cleared the charge. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #13 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Everything in this test plan worked as described. With this patch, an item "can be both checked out, Overdue, or Lost (i.e.: Lost, Long Overdue (Lost)) and CR at the same time" as described by Rebecca in comment 2. This patch does not address the issue raised by Lisette in comment 8. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #15 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 167527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167527&action=edit Bug 27919: Update syspref description -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #16 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- While this does allow for retaining original lost status when marking an item claims returned, it doesn't allow staff to see the return claim beyond the patrons checkout page. On the details page: We show only the Lost status - we need to alert if there is a claim as well On the items tab: We show only the lost status - we need to alert if there is a claim as well For items in the claimed return status, I cannot change the lost value For items with a claim and another lost status, I can alter the lost status We need to reconcile this behavior This feels a bit like a bandaid - can you elaborate on the other options that made this worse?I am not blocking, but I think displaying the claim if not reflected in the lost status would be a requirement here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #17 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 168309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168309&action=edit Bug 27919: (QA follow-up): Add alerts to the UI to show there are return claims This patch adds info to the UI to show when there is a return claim. It also reconciles the behaviour for allowing the lost status to be changed. Previously the lost status could not be changed if there was a return claim. This is now possible and a message is shown highlighting the fact that there is a return claim as well as the new lost status. Test plan: 1) Add a return claim to an item. 2) Check the holdings table on the record page and observe that the "Status" column now shows that there is a return claim 3) Click on the barcode for that item in the table to get to the item editing page 4) Observe that the select for the item lost status is not disabled 5) Change the status and save - the form should save correctly and display both the new status as well as a message showing that there is a return claim. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #19 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- (In reply to Nick Clemens (kidclamp) from comment #16)

While this does allow for retaining original lost status when marking an item claims returned, it doesn't allow staff to see the return claim beyond the patrons checkout page.

On the details page: We show only the Lost status - we need to alert if there is a claim as well

Done

On the items tab: We show only the lost status - we need to alert if there is a claim as well

Done

For items in the claimed return status, I cannot change the lost value For items with a claim and another lost status, I can alter the lost status We need to reconcile this behavior

The default behaviour currently is that you can't change the lost status if there is a return claim. I've changed this so you can now change it even when a return claim exists. The alerts above will be visible to show the return claim if it the status is changed

This feels a bit like a bandaid - can you elaborate on the other options that made this worse?I am not blocking, but I think displaying the claim if not reflected in the lost status would be a requirement here.

I initially started down the process of completely stripping the return claims feature out of the lost status entirely and using a method to check for both lost status and any return claims to determine the item status. That became incredibly complicated as there are 100s of instances of 'itemlost' that would need refactoring to now use this logic and would probably introduce technical debt as most community devs might not be aware of this new method when writing code down the line. Amending how return claims govern the lost status seemed like the best method to allow the two to co-exist without completely re-writing the entire concept. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167496|0 |1 is obsolete| | Attachment #167527|0 |1 is obsolete| | Attachment #168309|0 |1 is obsolete| | Attachment #168310|0 |1 is obsolete| | --- Comment #20 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171833&action=edit Bug 27919: Return claims shouldn't change lost status if already set This patch prevents a return claim from changing the lost status if it has already been set. Test plan: 1) In system preferences, set the ClaimReturnedLostValue syspref to any value 2) Checkout an item to a patron 3) Set that item as lost, using a different status to the one you set in step 1 4) Create a return claim on the item 5) Check the item's lost status, it should now have been set to the value you set in step 1 6) Apply patch 7) reset_all 8) Repeat steps 1-5, this time the status should remain at the value you set in step 3 and not be overwritten by the return claim 9) Repeat steps 1,2,4 and 5 - this time the lost status should be set to the value you set in step 1 as we didn't have a pre-existing lost status Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #22 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 171835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171835&action=edit Bug 27919: (QA follow-up): Add alerts to the UI to show there are return claims This patch adds info to the UI to show when there is a return claim. It also reconciles the behaviour for allowing the lost status to be changed. Previously the lost status could not be changed if there was a return claim. This is now possible and a message is shown highlighting the fact that there is a return claim as well as the new lost status. Test plan: 1) Add a return claim to an item. 2) Check the holdings table on the record page and observe that the "Status" column now shows that there is a return claim 3) Click on the barcode for that item in the table to get to the item editing page 4) Observe that the select for the item lost status is not disabled 5) Change the status and save - the form should save correctly and display both the new status as well as a message showing that there is a return claim. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lisette Scheer from comment #8)

(In reply to Lisette Scheer from comment #7)

...

If an item is marked long overdue lost, then is claimed returned, then is returned, the lost fine won't be refunded, even if the circulation rules say it should be.

Another example:

If an item is marked as claim returned and then changed to a different lost status when it isn't found, it doesn't charge the patron because it's already in a lost status.

Hi Liz, never thanked you for these! Thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) Translatability We have untranslatable strings again: + nodes += '<span class="claimed_returned">(Claimed returned)</span>'; For JavaScript inside a .tt or .inc, you need to use the _() syntax. 2) Feature/workflow question For testing, I did the following: * Check out an item * Make the "claim returns" column visible in the checkouts table via table config * Click the button => Nothing happens * Set ClaimReturnedLostValue to a LOST status * Button started working Question: Is this the intended behavior? It looks like this allows to keep an existing lost status, but it still forces you to pick and set one if the item was not lost before. I am happy if that's how it's intended, just bringing it up as a question. * I removed the lost status from the now unlocked item tab form. Question: The item now shows as available in the staff client and the OPAC, although the claim hasn't been resolved in the patron account. Should it be possible to remove the lost status like that or should we only be able to replace it? I am still pushing this, but I am trusting to get some replies and a speedy follow-up for 1)! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thanks Matt! Keeping the keyword for the workflow questions. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #30 from David Cook <dcook@prosentient.com.au> --- Looks like this causes a regression: bug 38248 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *ByWater release notes| |Solutions* and *PTFS | |Europe* -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *ByWater |**Sponsored by** *ByWater release notes|Solutions* and *PTFS |Solutions* and *PTFS |Europe* |Europe* and *Cuyahoga | |County Public Library* -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 carthur@slolibrary.org <carthur@slolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carthur@slolibrary.org -- You are receiving this mail because: You are watching all bug changes.