[Bug 33292] New: Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Bug ID: 33292 Summary: Claim Return doesn't refund lost item charge when MarkLostItemsAsReturned includes "When marking an item as a return claim" and "Refund lost item fee" is on Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: lisette.scheer@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com When using Claim Return, if an item has already been charged as Long Overdue (lost) it does not get refunded when a claim is made, even if lost item fee refund on return policy is set to "Refund" and MarkLostItemsAsReturned includes "When marking an item as a return claim" Since the library is not actually checking the item in it doesn't refund automatically. The library could check the item in and not resolve the claim, but that's an extra step and may not work with all workflows. Having the option to refund the lost fee on claim would be helpful for many libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27919 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org --- Comment #1 from Michelle Spinney <mspinney@clamsnet.org> --- "Having the option to refund the lost fee on claim would be helpful for many libraries." I agree with Lisette, ALL of our libraries would appreciate this. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27919 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27919 [Bug 27919] Split claims return from LOST -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kkrueger@cuyahogalibrary.or | |g -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #2 from Michelle Spinney <mspinney@clamsnet.org> --- I still agree with Lisette. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- I have written a patch for this bug but I'm holding off submitting it until a way forward is agreed for bug 27919, currently awaiting QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #4 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171966&action=edit Bug 33292: Add a checkbox to refund a lost fee on return claim -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #5 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171967&action=edit Bug 33292: Add logic to handle refunding a lost fee This patch allows the return claims endpoint to handle the refunding of a lost fee for the item if the checkbox is checked -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #6 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 171968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171968&action=edit Bug 33292: Add unit tests Test plan: 1) In KTD, set ClaimReturnedLostValue to any value 2) Checkout an item to a patron 3) Add a manual invoice to that patron's account against that item barcode 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 8) Run the unit tests prove t/db_dependent/Circulation/ReturnClaims.t prove t/db_dependent/api/v1/return_claims.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Do you happen to have any partners keen to test this for us Lisette? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #8 from Kristi <kkrueger@cuyahogalibrary.org> --- If this can be done in a sandbox rather than KTD, I could give it a try. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #9 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Steps 1 - 7 should be fine to run in a sandbox (sandboxes are generally just KTD instances) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #10 from Kristi <kkrueger@cuyahogalibrary.org> --- What would happen with step 8 then? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #11 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- That could be covered at QA stage or we can ask someone to add another sign-off line for the tests. If you're happy to do steps 1 - 7 it would be good to prove the concept works :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171968|0 |1 is obsolete| | --- Comment #12 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 172269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172269&action=edit Bug 33292: Add unit tests Test plan: 1) In KTD, set ClaimReturnedLostValue to any value 2) Checkout an item to a patron 3) Add a manual invoice to that patron's account against that item barcode 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 8) Run the unit tests prove t/db_dependent/Circulation/ReturnClaims.t prove t/db_dependent/api/v1/return_claims.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #13 from Kristi <kkrueger@cuyahogalibrary.org> --- Test plan: 1) In KTD, set ClaimReturnedLostValue to any value -- I Used 'Lost' 2) Checkout an item to a patron -- I used 39999000012392 3) Add a manual invoice to that patron's account against that item barcode I used patron with card number 23529000318858 and added a 1.50 charge. 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 This all worked as expected. Screenshots of the "refund previous lost fee" popup and the account lines will be attached. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #14 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 172270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172270&action=edit Popup Refund Fee Shows popup window for refund previous lost fee option on claims return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #15 from Kristi <kkrueger@cuyahogalibrary.org> --- Created attachment 172271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172271&action=edit Account Lines Claims Return Refund Shows the account line added when fee is refunded on claims return. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Kristi <kkrueger@cuyahogalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Version|unspecified |Main Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171966|0 |1 is obsolete| | --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172673&action=edit Bug 33292: Add a checkbox to refund a lost fee on return claim Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171967|0 |1 is obsolete| | --- Comment #17 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172674&action=edit Bug 33292: Add logic to handle refunding a lost fee This patch allows the return claims endpoint to handle the refunding of a lost fee for the item if the checkbox is checked Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172269|0 |1 is obsolete| | --- Comment #18 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 172675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172675&action=edit Bug 33292: Add unit tests Test plan: 1) In KTD, set ClaimReturnedLostValue to any value 2) Checkout an item to a patron 3) Add a manual invoice to that patron's account against that item barcode 4) In the patron's checkouts table, click the Claim returned button 5) The checkbox will have the option to "Refund previous lost fee" 6) Tick this box and submit 7) Have a look at the patron's transactions. There will now be a new line refunding the lost fee from step 3 8) Run the unit tests prove t/db_dependent/Circulation/ReturnClaims.t prove t/db_dependent/api/v1/return_claims.t Signed-off-by: Kristi Krueger <kkrueger@cuyahogalibrary.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Claim Return doesn't refund |Claim return doesn't refund |lost item charge when |lost item charge when |MarkLostItemsAsReturned |MarkLostItemsAsReturned |includes "When marking an |includes "When marking an |item as a return claim" and |item as a return claim" and |"Refund lost item fee" is |"Refund lost item fee" is |on |on -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Should this be "normal" instead of "enhancement"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Sponsored by** *ByWater release notes| |Solutions* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Laura O'Neil <laura@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *ByWater |**Sponsored by** *ByWater release notes|Solutions* |Solutions* and *Cuyahoga | |County Public Library* CC| |laura@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #21 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Enhancement, no 24.05.x backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Sponsored by** *ByWater |This allows to refund the release notes|Solutions* and *Cuyahoga |lost charge when a return |County Public Library* |claim is resolved. For this | |a new checkbox labelled | |'Refund previous lost fee' | |is added to the return | |claim modal. | | | |**Sponsored | |by** *ByWater Solutions* | |and *Cuyahoga County Public | |Library* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39094 [Bug 39094] Adjust system preferences to account for new option to refund the previous lost fee when marking an item Claims returned -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33292 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org