[Bug 7375] New: The web installer asks for the wrong Perl version
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Bug #: 7375 Summary: The web installer asks for the wrong Perl version Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (web-based installer) AssignedTo: magnus@enger.priv.no ReportedBy: magnus@enger.priv.no QAContact: ian.walls@bywatersolutions.com CC: gmcharlt@gmail.com koha-tmpl/intranet-tmpl/prog/en/modules/installer/step1.tt: 52 <li>Your perl version seems to be obsolete. 53 Please upgrade to a newer version of Perl (at least Version 5.006001).</li> This should say at least version 5.10. How should the version number be formatted? Is a simple "5.10" enough or should it be something like "5.010001"? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-12-22 08:54:10 UTC --- perl -v says with me: This is perl, v5.10.0 built for x86_64-linux-thread-multi So I would go for a simple 5.10 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|The web installer asks for |Update minimum version of |the wrong Perl version |Perl to 5.10 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-12-22 09:15:55 UTC --- Oops, I just assumed that the installer was actually checking for 5.10, but it seems it does not: 62 unless ( $] >= 5.008008 ) { # Bug 4505 63 $template->param( problems => 1, perlversion => 1, checkmodule => 0 ); I have changed the name of this bug to reflect the broader scope of this bug. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-12-22 10:00:14 UTC --- Created attachment 6922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6922 Proposed patch - Change the installer script to look for at least 5.10/5.010000 - Change the template to ask for the correct version To test: - Run through the webinstaller on 5.10 or newer and check that there are no errors. - Ideally: Run through the webinstaller on an older version than 5.10 and check that there *is* an error, asking for 5.10 or newer. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6922|0 |1 is obsolete| | --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-12-22 19:22:02 UTC --- Created attachment 6926 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6926 Bug 7375 - Update minimum version of Perl to 5.10 - Change the installer script to look for at least 5.10/5.010000 - Change the template to ask for the correct version To test: - Run through the webinstaller on 5.10 or newer and check that there are no errors. - Ideally: Run through the webinstaller on an older version than 5.10 and check that there *is* an error, asking for 5.10 or newer. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2012-01-09 20:38:38 UTC --- Simple change to version numbers, one in a comparison, other in a string. Marking Passed QA (as 5.10 is indeed the minimum version at this time) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |paul.poulain@biblibre.com Version|master |rel_3_6 Patch Status|Passed QA |Patch Pushed --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2012-01-13 10:42:56 UTC --- Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Included in the 3.6 branch prior to 3.6.4. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7375 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #8 from Magnus Enger <magnus@enger.priv.no> --- This has been in use for a while, without any complaints. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org