[Bug 6537] New: Simplified sysprefs for the web installer
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Bug #: 6537 Summary: Simplified sysprefs for the web installer Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: ASSIGNED Severity: enhancement Priority: P5 Component: Installation and upgrade (web-based installer) AssignedTo: magnus@enger.priv.no ReportedBy: magnus@enger.priv.no QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com http://wiki.koha-community.org/wiki/Simplified_syspref_handling_RFC -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #1 from Magnus Enger <magnus@enger.priv.no> 2011-06-28 16:31:48 UTC --- Created attachment 4524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4524 Proof-of-concept patc 1/3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #2 from Magnus Enger <magnus@enger.priv.no> 2011-06-28 16:32:19 UTC --- Created attachment 4525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4525 Proof-of-concept patch 2/3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #3 from Magnus Enger <magnus@enger.priv.no> 2011-06-28 16:32:55 UTC --- Created attachment 4526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4526 Proof-of-concept patch 3/3 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #4 from Magnus Enger <magnus@enger.priv.no> 2011-06-28 16:43:49 UTC --- Please note: The three attached patches are not a complete implementation of what I propose to do, but are meant as a "proof of concept" to see if this is the right way to do it. The changes are also available here: https://github.com/MagnusEnger/kohawork/commits/bug6537-sysprefs To test: - Apply the patches - Run through the web installer in English - Check that sysprefs work as expected - Install German translations - Run through the web installer in German - Check that sysprefs work as expected - Check that borrowerRelationship = Vater|Mutter and BorrowersTitles = Herr|Frau Questions: - Does this look like a feasible way of simplifying the handling of sysprefs for the web installer? - Should I delete unused columns (explanation, options?) from the systempreferences table while I'm at it? TODO - Create simplified syspres.sql files for all languages - See http://wiki.koha-community.org/wiki/Simplified_syspref_handling_RFC#Things_t... for more -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com AssignedTo|magnus@enger.priv.no |paul.poulain@biblibre.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4524|0 |1 is obsolete| | --- Comment #5 from Magnus Enger <magnus@enger.priv.no> 2011-08-06 01:18:22 UTC --- Created attachment 4875 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4875 Patch 1/5 - Make English sysprefs the default -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4525|0 |1 is obsolete| | --- Comment #6 from Magnus Enger <magnus@enger.priv.no> 2011-08-06 01:19:43 UTC --- Created attachment 4876 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4876 Patch 2/5 - Make web installer use default sysprefs file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4526|0 |1 is obsolete| | --- Comment #7 from Magnus Enger <magnus@enger.priv.no> 2011-08-06 01:21:21 UTC --- Created attachment 4877 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4877 Patch 3/5 - New, simplified sysprefs files for all the languages -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #8 from Magnus Enger <magnus@enger.priv.no> 2011-08-06 01:22:14 UTC --- Created attachment 4878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4878 Patch 4/5 - Remove syspref related tests in xt/ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #9 from Magnus Enger <magnus@enger.priv.no> 2011-08-06 01:29:06 UTC --- Created attachment 4879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4879 Patch 5/5 - Fix a problem in French syspref file -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff --- Comment #10 from Magnus Enger <magnus@enger.priv.no> 2011-08-06 01:31:40 UTC --- Changes are also available here: https://github.com/MagnusEnger/kohawork/commits/bug6537-sysprefs I'll send a proper "request to pull" to the patches list once I figure out how to do it (again)... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4875|0 |1 is obsolete| | Attachment #4876|0 |1 is obsolete| | Attachment #4877|0 |1 is obsolete| | Attachment #4878|0 |1 is obsolete| | Attachment #4879|0 |1 is obsolete| | --- Comment #11 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-09 11:55:31 UTC --- Created attachment 4903 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4903 proposed fix signed-off and squashed Works perfectly. I've tested with french setup, all sysprefs are here after install. Some are already translated if I checked the "update french unimarc syspref" in the last part of the installer (pre-load datas) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 --- Comment #12 from Paul Poulain <paul.poulain@biblibre.com> 2011-08-09 11:56:51 UTC --- Created attachment 4904 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4904 follow-up for french UNIMARC This follow-up just removes some lines that are not UNIMARC specific and have no reason to differ from the common/default setup -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4904|0 |1 is obsolete| | --- Comment #13 from Magnus Enger <magnus@enger.priv.no> 2011-08-09 12:10:42 UTC --- Created attachment 4905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4905 Signed off Paul's followup patch I can't speak to the French spellings or anything, but the followup patch from Paul does what it says and produces a valid SQL file in the end, so I'm signing off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|paul.poulain@biblibre.com |magnus@enger.priv.no -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #14 from Ian Walls <ian.walls@bywatersolutions.com> 2011-09-06 20:27:50 UTC --- The actual code of these patches is quite minimal, and has been verified to work. The bulk of the changes are moving data about; since what was the English file was just moved to the default file, and the differences in values taken and placed into update files. While I do not have the language skills to evaluate every language here, I can mark the mechanic as Passing QA; any language-specific issues that come up can be addressed as they're discovered. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> 2011-09-06 21:24:11 UTC --- Pushed, please test with a new install -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 MJ Ray (software.coop) <mjr@software.coop> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mjr@software.coop --- Comment #16 from MJ Ray (software.coop) <mjr@software.coop> --- I think this is in Stable now, isn't it? Related but maybe off-topic: should all Pushed to Master bugs become Pushed to Stable on a new major version release? Shall I try to identify and change likely suspects? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #17 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to comment #16)
I think this is in Stable now, isn't it?
Related but maybe off-topic: should all Pushed to Master bugs become Pushed to Stable on a new major version release? Shall I try to identify and change likely suspects?
That would be great, yes, this was in 3.6.0 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6537 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #18 from Magnus Enger <magnus@enger.priv.no> --- This has been in use for a while now, without any complaints. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org