https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89946&action=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89946|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 90092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90092&action=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90092|0 |1 is obsolete| | --- Comment #3 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 90242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90242&action=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Arthur Bousquet <arthur.bousquet@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90249|0 |1 is obsolete| | --- Comment #5 from Arthur Bousquet <arthur.bousquet@inlibro.com> --- Created attachment 90259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90259&action=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Current status: Signed Off Current patch-complexity: Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90259|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90267&action=edit Bug 22952: Markup error in OPAC suggestions template This patch makes a minor correction to the OPAC suggestions template in order to quiet an error returned by the HTML validator. To reproduce the problem you should have the 'suggestion' system preference turned on, and you should be logged in to the OPAC as a user who has submitted one or more suggestions. View the "your purchase suggestions" page in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch specifically addresses these errors: - "End tag div seen, but there were open elements." - "Unclosed element span." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Nadine Pierre <nadine.pierre@inLibro.com> Signed-off-by: Arthur Bousquet <arthur.bousquet@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22952 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.01 released in| | Status|Pushed to Master |Pushed to Stable --- Comment #9 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.