[Bug 22948] New: Markup error in OPAC bibliographic detail template
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Bug ID: 22948 Summary: Markup error in OPAC bibliographic detail template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Keywords: Academy Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Target Milestone: --- There are quite a few validation errors coming from the OPAC detail template (opac-detail.tt), but I would like to address one with this patch: - "The aria-labelledby attribute must point to an element in the same document." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 89943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89943&action=edit Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89943|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 90248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90248&action=edit Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Bin Wen <bin.wen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90248|0 |1 is obsolete| | --- Comment #3 from Bin Wen <bin.wen@inlibro.com> --- Created attachment 90257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90257&action=edit Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90257|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 90266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90266&action=edit Bug 22948: Markup error in OPAC bibliographic detail template This patch addresses one markup problem in opac-detail.tt which triggers a validation error. To reproduce the problem, view the normal bibliographic detail page for a record in the OPAC. Run the page through the W3C validation service: https://validator.w3.org. Either by pasting in the URL for the search results (if web accessible) or by viewing source, copying, and pasting into "Validate by Direct Input." This patch addresses one specific error: - "The aria-labelledby attribute must point to an element in the same document." To test, apply the patch and try again to reproduce the validation errors. Those errors should no longer be present. There should be no visible change to the page. Test the "Save record -> Dublin Core" menu item. It should trigger a modal window. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Bin Wen <bin.wen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe something for another day/bug: FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-detail-sidebar.inc OK filters FAIL forbidden patterns forbidden paattern: Contains old bootstrap style for buttons (see bug 16239) (line 93) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |Pushed to Stable Version(s)|19.11.00 |19.11.00,19.05.01 released in| | --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22948 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 18.11.x for 18.11.07 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org