[Bug 8383] New: Need test to check that Perl files will compile
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Priority: P1 - high Change sponsored?: --- Bug ID: 8383 Assignee: jcamins@cpbibliography.com Summary: Need test to check that Perl files will compile Severity: enhancement Classification: Unclassified OS: All Reporter: jcamins@cpbibliography.com Hardware: All Status: NEW Version: master Component: Test Suite Product: Koha We have t/00-load.t to make sure that C4 and Koha modules can be loaded, but right now there is no test to prevent the inclusion of a Perl script that does not compile in Koha. There should be one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 --- Comment #1 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10704 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10704&action=edit Bug 8383: Add test to check that Perl scripts compile This patch adds t/00-strict.pl which tests that all Perl scripts compile. I chose to use Test::Strict so that in the future we can also have the test check that "use strict" and "use warnings" are enabled. To test: 1. Run t/00-strict.pl. 2. Run around waving your arms in the air that we have a couple of scripts that don't compile. 3. Actually, that's about it. You could test my patch for bug 8384 next. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |chris@bigballofwax.co.nz --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- I like it, except this does more than check they will compile. eg not ok 28 - Syntax check acqui/modordernotes.pl # Failed test 'Syntax check acqui/modordernotes.pl' # at /usr/share/perl5/Test/Strict.pm line 305. # DBI connect('dbname=koha;host=localhost;port=3306','kohaadmin',...) failed: Access denied for user 'kohaadmin'@'localhost' (using password: YES) at C4/Context.pm line 758 Because they use C4::Context, to do a test like this we need a database, hence we need this script in t/db_dependent/ -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10704|0 |1 is obsolete| | --- Comment #3 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 10711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10711&action=edit Bug 8383: Add test to check that Perl scripts compile This patch adds t/db_dependent/00-strict.pl which tests that all Perl scripts compile. I chose to use Test::Strict so that in the future we can also have the test check that "use strict" and "use warnings" are enabled. To test: 1. Run t/db_dependent/00-strict.pl. 2. Run around waving your arms in the air that we have a couple of scripts that don't compile. 3. Actually, that's about it. You could test my patch for bug 8384 next. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Moved test to t/db_dependent -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10711|0 |1 is obsolete| | --- Comment #4 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 10723 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10723&action=edit Signed-off patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |frederic@tamil.fr -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #5 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #4)
Created attachment 10723 [details] Signed-off patch
QA comment... passing QA, patch applies and works perfect -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 QA Contact| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable Version|rel_3_10 |rel_3_8 Severity|enhancement |normal --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> --- Very useful test, pushing to 3.8.x -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Version|3.8 |master Resolution|FIXED |--- --- Comment #7 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #6)
Very useful test, pushing to 3.8.x
woops!, this patch missed out on getting pushed to master Jared, i'll attach a rebased patch for master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10723|0 |1 is obsolete| | --- Comment #8 from Mason James <mtj@kohaaloha.com> --- Created attachment 16900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16900&action=edit Bug 8383: Add test to check that Perl scripts This patch adds t/db_dependent/00-strict.pl which tests that all Perl scripts compile. I chose to use Test::Strict so that in the future we can also have the test check that "use strict" and "use warnings" are enabled. To test: 1. Run t/db_dependent/00-strict.pl. 2. Run around waving your arms in the air that we have a couple of scripts that don't compile. 3. Actually, that's about it. You could test my patch for bug 8384 next. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Moved test to t/db_dependent Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Mason James <mtj@kohaaloha.com> --- passing QA on this patch... -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8383 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |RESOLVED Resolution|--- |FIXED --- Comment #10 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch was pushed to master during the 3.10 release cycle. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org