[Bug 9881] New: Remove unused tablesorter plugin from offline circulation page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Bug ID: 9881 Summary: Remove unused tablesorter plugin from offline circulation page Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All URL: /cgi-bin/koha/offline_circ/list.pl OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org The offline circulation page which lists transactions ready to process includes the old tablesorter plugin even though it is unused. This reference should be removed. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|3.12 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16563 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16563&action=edit Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16563|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 16564 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16564&action=edit Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16564|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 16912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16912&action=edit [PASSED QA] Bug 9881 - Remove unused tablesorter plugin from offline circulation page The offline circulation list template doesn't need to include the tablesorter plugin, it's unused. This patch removes it. To test, submit some circulation transactions through the Firefox offline circulation addon. Load the offline circ page (offline_circ/list.pl). Confirm that there are no JavaScript errors, and that "check/uncheck all" links work correctly. Signoff comment: Test plan works as expected. Firebug and Chrome's builtin developer tool don't raise any errors. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> One line change, followed test plan, no negative consequences found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9881 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org