[Bug 32934] New: SIP checkouts using "no block" flag have a calculated due rather than the specified due date
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Bug ID: 32934 Summary: SIP checkouts using "no block" flag have a calculated due rather than the specified due date Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org SIP checkouts using the "no block" flag will cause the due date to wrongly be used as the transaction date, and the due date will instead be calculated using the circulation rules. In addition, the due date field in the SIP checkout response ( AH ) will be empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146450&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146450|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 146467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146467&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lmstrand@gmail.com --- Comment #3 from Lari Strand <lmstrand@gmail.com> --- Patch doesn't apply to master/23x. Applied it to 22.11 and seems to be working ok. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146467|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 162737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162737&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Could you provide a test plan? I'm not that familiar with SIP and need example commands. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to David Nind from comment #5)
Could you provide a test plan? I'm not that familiar with SIP and need example commands.
Test Plan ( assumes KTD with default data ): 1) Connect to SIP server via Telnet, send the following messages: 9300CNterm1|COterm1|CPCPL| 11YY20240411 14540120270411 145401AOCPL|AA23529001000463|AB39999000001259|ACterm1|BIN| 2) Check Edna's checkouts, not the checkout is not due in 2027 3) Apply this patch, restart the SIP server 4) Check in the item to remove it from Edna's record 5) Repeat step 1 6) The checkout is now due in 2027 as expected! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |blawlor@clamsnet.org --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- Is there something you need to do to start the SIP server in KTD? I read these docs: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup I tried running this command which appears to have done something: kohadev-koha@kohadevbox:koha(master)$ perl C4/S IP/SIPServer.pm /etc/koha/SIPconfig.xml & [1] 25565 But then when I try to connect via telnet it fails: $ telnet localhost 6001 Trying 127.0.0.1... telnet: Unable to connect to remote host: Connection refused I ran the telnet command from a different terminal because ktd doesn't seem to include telnet. I checked SIPconfig.xml and see the config for the user term1, and confirmed that user exists when I run KTD. I think I am missing a step or doing something wrong. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Brendan Lawlor from comment #7)
Is there something you need to do to start the SIP server in KTD?
I read these docs: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup
I tried running this command which appears to have done something: kohadev-koha@kohadevbox:koha(master)$ perl C4/S IP/SIPServer.pm /etc/koha/SIPconfig.xml & [1] 25565
But then when I try to connect via telnet it fails: $ telnet localhost 6001 Trying 127.0.0.1... telnet: Unable to connect to remote host: Connection refused
I ran the telnet command from a different terminal because ktd doesn't seem to include telnet.
I checked SIPconfig.xml and see the config for the user term1, and confirmed that user exists when I run KTD. I think I am missing a step or doing something wrong.
In KTD, you can run the bash alias "restart_all". That should do it for you! KTD does indeed not include telnet but you can install it by running "sudo apt update && sudo apt install -y telnet". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Thanks for the reply Kyle! Unfortunately I still can't connect after running restart_all kohadev-koha@kohadevbox:koha(master)$ telnet localhost 6001 Trying 127.0.0.1... Connection failed: Connection refused Trying ::1... telnet: Unable to connect to remote host: Cannot assign requested address I also tried using this sip emulator but also got denied: kohadev-koha@kohadevbox:koha(master)$ ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 \ -l CPL --patron 23529001000463 -m checkout --item 39999000001259 Attempting socket connection to 127.0.0.1:6001...failed! : Connection refused I am using WSL in case that's relevant. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Test Notes: Add port mapping to ktd docker-compose-lihgt.yml services: koha: ports: - "6001:6001" In ktd --shell install telnet sudo apt update && sudo apt install -y telnet Check that SIP server is running: sudo koha-sip --status kohadev Connect to SIP server and send messages: kohadev-koha@kohadevbox:koha(main)$ telnet localhost 6001 Trying ::1... Connection failed: Connection refused Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. 9300CNterm1|COterm1|CPCPL| 941 11YY20240411 14540120270411 145401AOCPL|AA23529001000463|AB39999000001259|ACterm1|BIN| 121NNY20240419 151631AOCPL|AA23529001000463|AB39999000001259|AJDream of fair to middling women /|AH| ^] 96 Connection closed by foreign host. Check Edna's checkouts, checkout date is 4/11/2027 and due date is 4/16/2027 Check the item in Apply patch. The patch applies without an error, but then there's an issue when you try to restart_all kohadev-koha@kohadevbox:koha(main)$ restart_all Restarting Apache httpd web server: apache2. Restarting Koha ILS: koha-commonStopping Plack daemon for kohadev:. Stopping Z39.50/SRU daemon for kohadev:. Stopping Koha worker daemon for kohadev (default):. Stopping Koha worker daemon for kohadev (long_tasks):. Stopping Koha indexing daemon for kohadev:. Successfully stopped all services for instance koha-common:. Starting Plack daemon for kohadev:. Starting Z39.50/SRU daemon for kohadev:Global symbol "$checkout" requires explicit package name (did you forget to declare "my $checkout"?) at /kohadevbox/koha/C4/Circulation.pm line 4307. Compilation failed in require at /kohadevbox/koha/Koha/Items.pm line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Items.pm line 27. Compilation failed in require at /kohadevbox/koha/Koha/Statistic.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Statistic.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/Statistics.pm line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Statistics.pm line 23. Compilation failed in require at /kohadevbox/koha/C4/Stats.pm line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Stats.pm line 22. Compilation failed in require at /kohadevbox/koha/C4/Accounts.pm line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Accounts.pm line 23. Compilation failed in require at /kohadevbox/koha/C4/Overdues.pm line 30. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Overdues.pm line 30. Compilation failed in require at /kohadevbox/koha/C4/Members.pm line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Members.pm line 27. Compilation failed in require at /kohadevbox/koha/C4/Letters.pm line 29. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Letters.pm line 29. Compilation failed in require at /kohadevbox/koha/Koha/Auth/TwoFactorAuth.pm line 23. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Auth/TwoFactorAuth.pm line 23. Compilation failed in require at /kohadevbox/koha/C4/Auth.pm line 40. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Auth.pm line 40. Compilation failed in require at /kohadevbox/koha/C4/Serials.pm line 37. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Serials.pm line 37. Compilation failed in require at /kohadevbox/koha/Koha/Biblio.pm line 29. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblio.pm line 29. Compilation failed in require at /kohadevbox/koha/Koha/Biblios.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Biblios.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/Libraries.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Libraries.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/Object/Limit/Library.pm line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Object/Limit/Library.pm line 22. Compilation failed in require at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 135. ...propagated at /usr/lib/x86_64-linux-gnu/perl-base/base.pm line 157. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/AuthorisedValue.pm line 25. Compilation failed in require at /kohadevbox/koha/Koha/AuthorisedValues.pm line 25. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/AuthorisedValues.pm line 25. Compilation failed in require at /kohadevbox/koha/C4/Koha.pm line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Koha.pm line 27. Compilation failed in require at /kohadevbox/koha/C4/Biblio.pm line 88. BEGIN failed--compilation aborted at /kohadevbox/koha/C4/Biblio.pm line 88. Compilation failed in require at /kohadevbox/koha/Koha/Z3950Responder.pm line 22. BEGIN failed--compilation aborted at /kohadevbox/koha/Koha/Z3950Responder.pm line 22. Compilation failed in require at /kohadevbox/koha/misc/z3950_responder.pl line 27. BEGIN failed--compilation aborted at /kohadevbox/koha/misc/z3950_responder.pl line 27. failed! Starting Koha worker daemon for kohadev (default):. Starting Koha worker daemon for kohadev (long_tasks):. Starting Koha indexing daemon for kohadev:. . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Lari Strand <lmstrand@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162737|0 |1 is obsolete| | --- Comment #11 from Lari Strand <lmstrand@gmail.com> --- Created attachment 172389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172389&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172389|0 |1 is obsolete| | --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 172399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172399&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #13 from Brendan Lawlor <blawlor@clamsnet.org> --- Test notes: Before applying the patch I got: Checked out on 04/11/2027 14:54 Due date 04/16/2027 After applying patch I got: Checked out on 10/04/2024 13:36 Due date 04/11/2027 14:54 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |lmstrand@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Kyle M Hall (khall) <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172399|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172566&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #15 from Kyle M Hall (khall) <kyle@bywatersolutions.com> --- Created attachment 172567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172567&action=edit Bug 32934: (QA follow-up) Tidy code for qa script Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is no explanation of the change in the commit message and there are no unit tests. Can you please improve? For me it's not clear right now what the correct behavior is: Should the due date if included in the SIP message only be processed if the block flag is set or always? I had assumed it should only use it when the flag is set. Please add some explanation! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Marion Durand <marion.durand@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marion.durand@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Ryan Henderson <ryan.henderson@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ryan.henderson@openfifth.co | |.uk --- Comment #17 from Ryan Henderson <ryan.henderson@openfifth.co.uk> --- Just to add to this, we've recently encountered this issue with one of our partners. For us the issue occurred where an offline transaction file was uploaded to the Koha server once the SIP2 service was brought online again. However, the SIP2 service would ignore the checkout date, and would instead take the due date as the checkout. This obviously caused a few head scratches, but whenever we applied these patches to our test server the SIP2 service started to honour the checkout date properly along with the due date. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183857&action=edit Bug 32934: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172566|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183858&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages **Problem:** When using SIP checkout messages with the "no block" flag, the specified due date was being ignored. Instead of honoring the provided due date, the system would: 1. Use the due date as the transaction timestamp (incorrect behavior) 2. Calculate a new due date based on circulation rules 3. Return an empty due date field (AH) in the SIP response This affected SIP2 integrations where external systems needed to specify exact due dates for checkouts, particularly for offline circulation scenarios. **Root Cause:** The `ProcessOfflineIssue` function in C4::Circulation was only returning a success/failure message, but the SIP checkout transaction needed access to the resulting checkout object to properly set the due date. The SIP Transaction::Checkout module was calling `ProcessOfflineIssue` but couldn't retrieve the checkout details to populate the transaction's due date field. **Solution:** 1. Modified `ProcessOfflineIssue` to return both the status message AND the checkout object: `return ( "Success.", $checkout );` 2. Updated `ProcessOfflineOperation` to handle the new return format by capturing only the message: `( $report ) = ProcessOfflineIssue( $operation );` 3. Modified SIP Transaction::Checkout to capture both return values and use the checkout object to set the proper due date via `duedatefromissue` 4. Fixed the timestamp parameter to use `dt_from_string` instead of the due date **Test Plan:** 1. **Unit Tests:** - Run `prove t/db_dependent/Circulation/OfflineCirculation.t` to verify ProcessOfflineIssue returns checkout object and respects due_date parameter - Run `prove t/db_dependent/SIP/Transaction.t` to verify SIP checkout honors no_block_due_date parameter 2. **Manual SIP Testing:** - Connect to SIP server via telnet on port 6001 - Send checkout message with no block flag and specific due date: `111YN20250115 18000120241201 180001AP|AO|AC|AD|AB<barcode>|AA<cardnumber>|` - Verify response contains correct due date in AH field - Verify checkout record in database has the specified due date 3. **Regression Testing:** - Verify normal SIP checkouts (without no block) still work correctly - Verify offline circulation operations continue to function - Verify ProcessOfflineOperation still processes queued operations correctly Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk Attachment #172567|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183857|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183869&action=edit Bug 32934: Unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183858|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183870&action=edit Bug 32934: Correctly honor the no block due date for SIP checkout messages **Problem:** When using SIP checkout messages with the "no block" flag, the specified due date was being ignored. Instead of honoring the provided due date, the system would: 1. Use the due date as the transaction timestamp (incorrect behavior) 2. Calculate a new due date based on circulation rules 3. Return an empty due date field (AH) in the SIP response This affected SIP2 integrations where external systems needed to specify exact due dates for checkouts, particularly for offline circulation scenarios. **Root Cause:** The `ProcessOfflineIssue` function in C4::Circulation was only returning a success/failure message, but the SIP checkout transaction needed access to the resulting checkout object to properly set the due date. The SIP Transaction::Checkout module was calling `ProcessOfflineIssue` but couldn't retrieve the checkout details to populate the transaction's due date field. **Solution:** 1. Modified `ProcessOfflineIssue` to return both the status message AND the checkout object: `return ( "Success.", $checkout );` 2. Updated `ProcessOfflineOperation` to handle the new return format by capturing only the message: `( $report ) = ProcessOfflineIssue( $operation );` 3. Modified SIP Transaction::Checkout to capture both return values and use the checkout object to set the proper due date via `duedatefromissue` 4. Fixed the timestamp parameter to use `dt_from_string` instead of the due date **Test Plan:** 1. **Unit Tests:** - Run `prove t/db_dependent/Circulation/OfflineCirculation.t` to verify ProcessOfflineIssue returns checkout object and respects due_date parameter - Run `prove t/db_dependent/SIP/Transaction.t` to verify SIP checkout honors no_block_due_date parameter 2. **Manual SIP Testing:** - Connect to SIP server via telnet on port 6001 - Send checkout message with no block flag and specific due date: `111YN20250115 18000120241201 180001AP|AO|AC|AD|AB<barcode>|AA<cardnumber>|` - Verify response contains correct due date in AH field - Verify checkout record in database has the specified due date 3. **Regression Testing:** - Verify normal SIP checkouts (without no block) still work correctly - Verify offline circulation operations continue to function - Verify ProcessOfflineOperation still processes queued operations correctly Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #22 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rescued -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #23 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 --- Comment #24 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | --- Comment #25 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #26 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #27 from David Nind <david@davidnind.com> --- Bug fix, no changes to manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32934 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org