[Bug 39452] New: Log cardnumber changes as distinct action within borrower logs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Bug ID: 39452 Summary: Log cardnumber changes as distinct action within borrower logs Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Depends on: 18626 Libraries find it useful to retain previous patron cardnumbers. Long ago, bug 18626 started retaining those old cardnumbers in the action logs. But action logs contain a lot of other data a library may not wish to retain indefinitely. Cleanup_database can specify deletion/retention of logs down to the action level, so making cardnumber changes a distinct action would make is easy to retain cardnumber changes in the logs without retaining other data. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18626 [Bug 18626] Add ability to track cardnumber changes for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 179703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179703&action=edit Bug 39452: Add CardnumberLog to track changes to cardnumbers This patch adds a new preference 'CardnumberLog' which allows libraries to track cardnumebr changes for patrons. While these changes are currently captured in the BorrowersLog, some libraries would like to keep cardnumber chanegs specifically, and for a longer period than other borrower modifications. To test: 1 - Apply patches, update database 2 - Ensure BorrowersLog and CardnumberLog are enabled 3 - Edit a borrower, not thier cardnuber 4 - Confirm in Modification Log only one entry is recorded 5 - Edit again, changing cardnumber only 6 - Confirm 2 modifications are recorded, a MODIFY and a MODIFY_CARDNUMBER 7 - Disable BorrowersLog 8 - Edit patron changing something other than cardnumber 9 - Confirm no log generated 10 - Edit borrowers cardnumber 11 - Confirm one MODIFY_CARDNUMBER recorded 12 - Disable CardnumberLog 13 - Edit patrons cardnumber and other fields 14 - Confirm no logs generated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179703|0 |1 is obsolete| | --- Comment #2 from Philip Orr <philip.orr@lmscloud.de> --- Created attachment 179904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179904&action=edit Bug 39452: Add CardnumberLog to track changes to cardnumbers This patch adds a new preference 'CardnumberLog' which allows libraries to track cardnumebr changes for patrons. While these changes are currently captured in the BorrowersLog, some libraries would like to keep cardnumber chanegs specifically, and for a longer period than other borrower modifications. To test: 1 - Apply patches, update database 2 - Ensure BorrowersLog and CardnumberLog are enabled 3 - Edit a borrower, not thier cardnuber 4 - Confirm in Modification Log only one entry is recorded 5 - Edit again, changing cardnumber only 6 - Confirm 2 modifications are recorded, a MODIFY and a MODIFY_CARDNUMBER 7 - Disable BorrowersLog 8 - Edit patron changing something other than cardnumber 9 - Confirm no log generated 10 - Edit borrowers cardnumber 11 - Confirm one MODIFY_CARDNUMBER recorded 12 - Disable CardnumberLog 13 - Edit patrons cardnumber and other fields 14 - Confirm no logs generated Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL Koha/Patron.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/Patron.pm` FAIL installer/data/mysql/atomicupdate/bug_39452_add_cardnumberlog.pl FAIL forbidden patterns forbidden pattern: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) (line 13) FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl installer/data/mysql/atomicupdate/bug_39452_add_cardnumberlog.pl` OK installer/data/mysql/mandatory/sysprefs.sql OK koha-tmpl/intranet-tmpl/prog/en/includes/action-logs.inc OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt OK koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt FAIL t/db_dependent/Koha/Patrons.t FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl t/db_dependent/Koha/Patrons.t` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I also got this error (from the pre-commit hook?) when trying to tidy: Constant subroutine Koha::Patron::ADMINISTRATIVE_LOCKOUT redefined at /usr/lib/x86_64-linux-gnu/perl-base/constant.pm line 171. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #4)
I also got this error (from the pre-commit hook?) when trying to tidy:
Constant subroutine Koha::Patron::ADMINISTRATIVE_LOCKOUT redefined at /usr/lib/x86_64-linux-gnu/perl-base/constant.pm line 171.
Probably you can ignore that one. We have lots of those due to some cyclic dependencies between modules. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #179904|0 |1 is obsolete| | --- Comment #6 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182031&action=edit Bug 39452: Add CardnumberLog to track changes to cardnumbers This patch adds a new preference 'CardnumberLog' which allows libraries to track cardnumebr changes for patrons. While these changes are currently captured in the BorrowersLog, some libraries would like to keep cardnumber chanegs specifically, and for a longer period than other borrower modifications. To test: 1 - Apply patches, update database 2 - Ensure BorrowersLog and CardnumberLog are enabled 3 - Edit a borrower, not thier cardnuber 4 - Confirm in Modification Log only one entry is recorded 5 - Edit again, changing cardnumber only 6 - Confirm 2 modifications are recorded, a MODIFY and a MODIFY_CARDNUMBER 7 - Disable BorrowersLog 8 - Edit patron changing something other than cardnumber 9 - Confirm no log generated 10 - Edit borrowers cardnumber 11 - Confirm one MODIFY_CARDNUMBER recorded 12 - Disable CardnumberLog 13 - Edit patrons cardnumber and other fields 14 - Confirm no logs generated Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #7 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 182032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182032&action=edit Bug 39452: (follow-up) Use INSERT IGNORE for system preference -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182031|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182075&action=edit Bug 39452: Add CardnumberLog to track changes to cardnumbers This patch adds a new preference 'CardnumberLog' which allows libraries to track cardnumebr changes for patrons. While these changes are currently captured in the BorrowersLog, some libraries would like to keep cardnumber chanegs specifically, and for a longer period than other borrower modifications. To test: 1 - Apply patches, update database 2 - Ensure BorrowersLog and CardnumberLog are enabled 3 - Edit a borrower, not thier cardnuber 4 - Confirm in Modification Log only one entry is recorded 5 - Edit again, changing cardnumber only 6 - Confirm 2 modifications are recorded, a MODIFY and a MODIFY_CARDNUMBER 7 - Disable BorrowersLog 8 - Edit patron changing something other than cardnumber 9 - Confirm no log generated 10 - Edit borrowers cardnumber 11 - Confirm one MODIFY_CARDNUMBER recorded 12 - Disable CardnumberLog 13 - Edit patrons cardnumber and other fields 14 - Confirm no logs generated Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182032|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 182076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182076&action=edit Bug 39452: (follow-up) Use INSERT IGNORE for system preference Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@openfifth.c | |o.uk QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Fixed before pushing: Signed-off-by: PhilipOrr <philip.orr@lmscloud.de> + say $out "Added new system preference 'CardnumberLog'"; say_success + description => "Add CardnumberLog Preference", Capitalization + ('CardnumberLog','1',NULL,'If ON, log edit actions on patron cardnumbers','YesNo') Not turning this on by default, updated to 0 in the atomicupdate. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Enhancement not pushed to 24.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41010 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41010 [Bug 41010] Incorrect show_priority condition in opac-detail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Comment on attachment 182075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182075 Bug 39452: Add CardnumberLog to track changes to cardnumbers Review of attachment 182075: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=39452&attachment=182075) ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ +1514,4 @@
<td class="barcode" property="serialNumber">[% ITEM_RESULT.barcode | html %]</td> [% END %]
+ [% IF item_level_holds > 0 || show_priority %]
This change is totally unrelated to the patch. Please see bug 41010. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk Documentation| |Aude Charillon contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1135 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #14 from Aude Charillon <aude.charillon@openfifth.co.uk> --- Added to the Koha Manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Jake Deery <jake.deery@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |27364 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27364 [Bug 27364] Making previous patron cardnumbers searchable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39452 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org