https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patron/Borrower_Discharge.t |Remove legacy "pre-wrap" |generates warnings |versions (was | |Patron/Borrower_Discharge.t | |generates warnings) Depends on| |9210 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> ---

From https://css-tricks.com/snippets/css/make-pre-text-wrap/

/* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9210 [Bug 9210] Automatic carriage return are missing in print letters generated for holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184133&action=edit Bug 40407: Remove legacy "pre-wrap" versions

From https://css-tricks.com/snippets/css/make-pre-text-wrap/

/* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Test plan (from bug 921)0: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184299|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 184363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184363&action=edit Bug 40407: Remove legacy "pre-wrap" versions

From https://css-tricks.com/snippets/css/make-pre-text-wrap/

/* Browser specific (not valid) styles to make preformatted text wrap */ pre { white-space: pre-wrap; /* css-3 */ white-space: -moz-pre-wrap; /* Mozilla, since 1999 */ white-space: -pre-wrap; /* Opera 4-6 */ white-space: -o-pre-wrap; /* Opera 7 */ word-wrap: break-word; /* Internet Explorer 5.5+ */ } ... I think it's now safe to remove the backward compatibility versions and simply keep pre-wrap. Test plan (from bug 921)0: * place a hold on a title with a very very long title or author * mark it as "waiting for pickup" by doing a checkin * go to command line interface, and run * misc/cronjobs/gather_print_notices.pl /tmp * misc/cronjobs/printoverdues.sh /tmp * if your title/author is long enough, it's splitted on 2 lines with this patch (it is not before this patch) It will also remove the warnings from t/db_dependent/Patron/Borrower_Discharge.t WARNING: Ignored `white-space: -moz-pre-wrap` at 6:14, invalid value. WARNING: Ignored `white-space: -o-pre-wrap` at 7:14, invalid value. WARNING: Ignored `word-wrap: break-work` at 8:14, invalid value. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@openfifth.c |y.org |o.uk -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 --- Comment #6 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40444 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40444 [Bug 40444] Add a test to ensure all Perl test files use Test::NoWarnings -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40407 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.