[Bug 40419] New: xt/find-license-problems.t isn't catching all instances of 51 Franklin St/Street
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Bug ID: 40419 Summary: xt/find-license-problems.t isn't catching all instances of 51 Franklin St/Street Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org kohadev-koha@kohadevbox:koha(main)$ git grep '51 Franklin St' Koha/Course.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Instructor.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Instructors.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Item.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Items.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Reserve.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Course/Reserves.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Courses.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/Exceptions/MarcOverlayRule.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. Koha/REST/V1/CirculationRules.pm:# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. etc/zebradb/authorities/etc/dom-config-marc.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/authorities/etc/dom-config.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/biblios/etc/dom-config-marc.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/biblios/etc/dom-config.xml:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, etc/zebradb/xsl/zebra.xsl:Free Software Foundation, 51 Franklin Street, Fifth Floor, Boston, koha-tmpl/intranet-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/intranet-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt: 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/intranet-tmpl/lib/tiny_mce/license.txt: Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/opac-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA koha-tmpl/opac-tmpl/lib/greybox/GreyBox_v5_5/LGPL.txt: Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA xt/find-license-problems.t: $hasfranklinst = 1 if ( $line =~ /51 Franklin Street/ ); Two things here: 1. Sometimes it is 51 Franklin St and other times '51 Franklin Street' 2. Some of these are passing because they do do not contain the string 'Copyright'. We should probably catch all of these instances? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Test Suite |and plumbing | Assignee|koha-bugs@lists.koha-commun |chris@bigballofwax.co.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184164&action=edit Bug 40419: Remove check for Copyright line The Copyright line should not be mandatory. And if missing, is not a reason to skip the GPL-related checks anyway. This 'fix' will highlight existing errors that were skipped until now. To test: 1. Run: $ ktd --shell k$ prove xt/find-license-problems.t => FAIL: Tests pass! Some files should make them fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests fail! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #2 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184165&action=edit Bug 40419: Skip testing-related templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #3 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184166&action=edit Bug 40419: Fix wrong license -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- The correct fix is on bug 40402, I told you on mattermost ;-) *** This bug has been marked as a duplicate of bug 40402 *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Or maybe it's actually related and not duplicated. But bug 40402 is going to fix Jenkins the correct way. If we need more it should be written on top of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|DUPLICATE |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40402 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40402 [Bug 40402] xt/find-license-problems.t is failing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184164|0 |1 is obsolete| | Attachment #184165|0 |1 is obsolete| | Attachment #184166|0 |1 is obsolete| | --- Comment #6 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184175&action=edit Bug 40419: Changes to testing logic This patch makes a couple changes to the tests: * Remove check for Copyright line. The Copyright line should not be mandatory. * Remove dependency of GPL-related checks on the copyrigth line existence. (this highlights several missed checks). * Skip testing-related templates. Koha ships some templates that are not excluded correctly. This 'fix' will highlight existing errors that were skipped until now. To test: 1. Run: $ ktd --shell k$ prove xt/find-license-problems.t => FAIL: Tests pass! Some files should make them fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests fail! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #7 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184176&action=edit Bug 40419: Fix wrong license -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #8 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Lucas: * I think errors in the external libs we include should better be reported upstream. `koha-tmpl/` is explicitly excluded so I wouldn't care. * I don't think the Copyright line check makes sense. Right now it is only being used to skip the GPL check which is incorrect. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #9 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- ... I mistakenly submitted before finishing. That's why I propose to remove the copyright line check. Nice catch! I believe I covered them all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184175|0 |1 is obsolete| | Attachment #184176|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184182&action=edit Bug 40419: Changes to testing logic This patch makes a couple changes to the tests: * Remove check for Copyright line. The Copyright line should not be mandatory. * Remove dependency of GPL-related checks on the copyrigth line existence. (this highlights several missed checks). * Skip testing-related templates. Koha ships some templates that are not excluded correctly. This 'fix' will highlight existing errors that were skipped until now. To test: 1. Run: $ ktd --shell k$ prove xt/find-license-problems.t => FAIL: Tests pass! Some files should make them fail! 2. Apply this patch 3. Repeat 1 => SUCCESS: Tests fail! Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184183&action=edit Bug 40419: Fix wrong license Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #12 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.02 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 --- Comment #13 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.02 |25.11.00,25.05.02,24.11.08 released in| | Status|Pushed to stable |Pushed to oldstable --- Comment #14 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #15 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #16 from David Nind <david@davidnind.com> --- Test suite related, no changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40419 Bug 40419 depends on bug 40402, which changed state. Bug 40402 Summary: xt/find-license-problems.t is failing https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40402 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org