[Bug 42279] New: Tidy all script tags - acqui
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Bug ID: 42279 Summary: Tidy all script tags - acqui Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags (except value_builder) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196777&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196778&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Patch from commit b4c7104 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196777|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196913&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196778|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196914&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Patch from commit 030992a -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196913|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196914|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197156&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 197157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197157&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Patch from commit 3363c50 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197156|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197157|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197567&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197568&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197569&action=edit Bug 42279: (follow-up) Restore numeric compare of quantityrec The port quoted [% quantityrec | html %] into a string const, but the value is used as `$(this).val() < quantityrec` where both sides are now strings and JS does a lexicographic compare ("10" < "5" is true), giving the wrong branch when the user enters a multi-digit quantity. Render quantityrec as a JS number (with a 0 fallback) so the comparison stays numeric, matching the original template output. To test: - Modify an existing order with quantityrec, e.g. 5 items received. - Change quantity to 10 (higher than received): "can't add new item" alert fires, value reverts. - Change quantity to 2 (lower): "don't forget to delete" alert fires. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41604 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41604 [Bug 41604] Impossible to hide Checkin column in issues-table in circ/circulation.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197567|0 |1 is obsolete| | Attachment #197568|0 |1 is obsolete| | Attachment #197569|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199805&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199806&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 199807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199807&action=edit Bug 42279: (follow-up) Restore numeric compare of quantityrec The port quoted [% quantityrec | html %] into a string const, but the value is used as `$(this).val() < quantityrec` where both sides are now strings and JS does a lexicographic compare ("10" < "5" is true), giving the wrong branch when the user enters a multi-digit quantity. Render quantityrec as a JS number (with a 0 fallback) so the comparison stays numeric, matching the original template output. To test: - Modify an existing order with quantityrec, e.g. 5 items received. - Change quantity to 10 (higher than received): "can't add new item" alert fires, value reverts. - Change quantity to 2 (lower): "don't forget to delete" alert fires. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #13 from Jonathan Druart <jonathan.druart@gmail.com> --- Rebased on top of bug 41604, that should go first. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bibliothek@th-wildau.de QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199805|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199807|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #14 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199859&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #15 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199860&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #16 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199861&action=edit Bug 42279: (follow-up) Restore numeric compare of quantityrec The port quoted [% quantityrec | html %] into a string const, but the value is used as `$(this).val() < quantityrec` where both sides are now strings and JS does a lexicographic compare ("10" < "5" is true), giving the wrong branch when the user enters a multi-digit quantity. Render quantityrec as a JS number (with a 0 fallback) so the comparison stays numeric, matching the original template output. To test: - Modify an existing order with quantityrec, e.g. 5 items received. - Change quantity to 10 (higher than received): "can't add new item" alert fires, value reverts. - Change quantity to 2 (lower): "don't forget to delete" alert fires. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #17 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 199862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199862&action=edit Bug 42279: (QA follow-up) Fix straying TT variable, auto tidy Removes a left over TT variable from a JS script block without data-tt-allowed="true" attribute. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Passed QA |Patch doesn't apply --- Comment #18 from David Nind <david@davidnind.com> --- The patches no longer apply 8-(... Bug 42279 - Tidy all script tags - acqui • 199859 - Bug 42279: Tidy all script tags - acqui • 199860 - Bug 42279: Tidy all script tags - acqui (auto tidy) • 199861 - Bug 42279: (follow-up) Restore numeric compare of quantityrec • 199862 - Bug 42279: (QA follow-up) Fix straying TT variable, auto tidy Apply? [(y)es, (n)o, (i)nteractive] y Preparing 4 patch(es): ✓ Prepared 4 patch(es) Applying 4 patch(es): Patch application failed for attachment 199859 - Bug 42279: Tidy all script tags - acqui -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199859|0 |1 is obsolete| | Attachment #199860|0 |1 is obsolete| | Attachment #199861|0 |1 is obsolete| | Attachment #199862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #19 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201146&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #20 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201147&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #21 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201148&action=edit Bug 42279: (follow-up) Restore numeric compare of quantityrec The port quoted [% quantityrec | html %] into a string const, but the value is used as `$(this).val() < quantityrec` where both sides are now strings and JS does a lexicographic compare ("10" < "5" is true), giving the wrong branch when the user enters a multi-digit quantity. Render quantityrec as a JS number (with a 0 fallback) so the comparison stays numeric, matching the original template output. To test: - Modify an existing order with quantityrec, e.g. 5 items received. - Change quantity to 10 (higher than received): "can't add new item" alert fires, value reverts. - Change quantity to 2 (lower): "don't forget to delete" alert fires. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #22 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 201149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201149&action=edit Bug 42279: (QA follow-up) Fix straying TT variable, auto tidy Removes a left over TT variable from a JS script block without data-tt-allowed="true" attribute. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201146|0 |1 is obsolete| | Attachment #201147|0 |1 is obsolete| | Attachment #201148|0 |1 is obsolete| | Attachment #201149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201163&action=edit Bug 42279: Tidy all script tags - acqui In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the acquisition module. The 2 main changes are in the following files: * basket.tt It's mostly about table settings and the visibility of columns depending on syspref: - "supplier report" / EDIFACT - "modify" / if basket is not closed - "cancel" / CancelOrdersInClosedBaskets * neworderempty.tt trivial changes, no error or warning in the console should appear. Confirm than createing a new order works as expected. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201164&action=edit Bug 42279: Tidy all script tags - acqui (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201165&action=edit Bug 42279: (follow-up) Restore numeric compare of quantityrec The port quoted [% quantityrec | html %] into a string const, but the value is used as `$(this).val() < quantityrec` where both sides are now strings and JS does a lexicographic compare ("10" < "5" is true), giving the wrong branch when the user enters a multi-digit quantity. Render quantityrec as a JS number (with a 0 fallback) so the comparison stays numeric, matching the original template output. To test: - Modify an existing order with quantityrec, e.g. 5 items received. - Change quantity to 10 (higher than received): "can't add new item" alert fires, value reverts. - Change quantity to 2 (lower): "don't forget to delete" alert fires. Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 201166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201166&action=edit Bug 42279: (QA follow-up) Fix straying TT variable, auto tidy Removes a left over TT variable from a JS script block without data-tt-allowed="true" attribute. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42279 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Yet another rebase. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org