[Bug 42280] New: Tidy all script tags - admin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Bug ID: 42280 Summary: Tidy all script tags - admin Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Blocks: 42094 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42094 [Bug 42094] Tidy all script tags (except value_builder) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196779&action=edit Bug 42280: Tidy all script tags - admin In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the administration module. The 2 main changes are in the following files: * aqplan.tt "0" should be correctly formatted * categories.tt trivial change about table settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 196780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=196780&action=edit Bug 42280: Tidy all script tags - admin (auto tidy) Patch from commit 237d523 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41653 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41653 [Bug 41653] Stores for permissions and sysprefs should be under the Koha namespace -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196779|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #196780|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #3 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197570&action=edit Bug 42280: Tidy all script tags - admin In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the administration module. The 2 main changes are in the following files: * aqplan.tt "0" should be correctly formatted * categories.tt trivial change about table settings Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #4 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 197571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=197571&action=edit Bug 42280: Tidy all script tags - admin (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197570|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #197571|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198505&action=edit Bug 42280: Tidy all script tags - admin In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the administration module. The 2 main changes are in the following files: * aqplan.tt "0" should be correctly formatted * categories.tt trivial change about table settings Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 198506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198506&action=edit Bug 42280: Tidy all script tags - admin (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41841 [Bug 41841] Update some patron admin templates to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41839 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41839 [Bug 41839] Update MARC framework pages to use grid layout for forms -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |bibliothek@th-wildau.de |y.org | CC| |bibliothek@th-wildau.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 Jan Kissig <bibliothek@th-wildau.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #198505|0 |1 is obsolete| | Attachment #198506|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #8 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200161&action=edit Bug 42280: Tidy all script tags - admin In order to tidy all the script tags of the .tt files we isolate the interpolation of Template::Toolkit variables in a separate script tag. This patch focuses on the administration module. The 2 main changes are in the following files: * aqplan.tt "0" should be correctly formatted * categories.tt trivial change about table settings Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #9 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200162&action=edit Bug 42280: Tidy all script tags - admin (auto tidy) Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> Signed-off-by: Jan Kissig <bibliothek@th-wildau.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #10 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200163&action=edit Bug 42280: (QA follow-up) Split JS in curbside_pickup to TT and non TT block. Auto tidy This splits remaining JS into a block with and without TT interpolation. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #11 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200164&action=edit Bug 42280: (QA follow-up) Split JS in matching-rules to TT and non TT block. Auto tidy This splits remaining JS into a block with and without TT interpolation. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #12 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200165&action=edit Bug 42280: (QA follow-up) Split JS in preferences to TT and non TT block. Auto tidy This splits remaining JS into a block with and without TT interpolation. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #13 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200166&action=edit Bug 42280: (QA follow-up) Split JS in restrictions to TT and non TT block. Auto tidy This splits remaining JS into a block with and without TT interpolation. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #14 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200167&action=edit Bug 42280: (QA follow-up) Split JS in transfer_limits to TT and non TT block. Auto tidy This splits remaining JS into a block with and without TT interpolation. Auto tidy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42280 --- Comment #15 from Jan Kissig <bibliothek@th-wildau.de> --- Created attachment 200168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=200168&action=edit Bug 42280: (QA follow-up) Split JS in uage_statistics to TT and non TT block. Auto tidy This splits remaining JS into a block with and without TT interpolation. Auto tidy Small changes on add_to_map() call: To test: a) go to Administration -> Shar eyour usage statistics b) in dev console check Koha.prefs.UsageStatsGeolocation is [] when no coordinates are set c) add some coordinates to main library (first Geolocation input field) and others d) check that Main and other libraries are drwan on the map when reentering usage statistics page e) No console errors should be shown -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org