[Bug 39043] New: Style improvement to guided reports controls
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Bug ID: 39043 Summary: Style improvement to guided reports controls Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs@lists.koha-community.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org I'd like to make a few improvements to the style of buttons in the various stages of building a guided report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177535&action=edit Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177535|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 177950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=177950&action=edit Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Lauri Hänninen <lauri.hanninen@lahti.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lauri.hanninen@lahti.fi --- Comment #3 from Lauri Hänninen <lauri.hanninen@lahti.fi> --- - Tested guided report before applying patch. - Applied patch and rebuilt CSS. - Confirmed that guided report now has navigation buttons with styled arrows in each step 1-5, and step 3's add and delete buttons are also styled with arrows and are well aligned. - Step 6 finish -button isn't styled with an arrow. - After clicking finish button, Confirm custom report -page has a Next button without an arrow. I don't think the lone Finish button in step 6 or Next button in Confirm custom report -page need the styled arrow, but I'm not sure if they are supposed to have the arrows or not? If not, I'd signoff the patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lauri Hänninen from comment #3)
I don't think the lone Finish button in step 6 or Next button in Confirm custom report -page need the styled arrow
This makes me think that the "Finish" button should probably be relabeled "Next ->" and the button on the next page relabeled "Finish". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez@biblibre.c | |om --- Comment #5 from claire.hernandez@biblibre.com <claire.hernandez@biblibre.com> --- So this patch isn't NSO anymore ? Maybe waiting Lauri's feedback fix ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 --- Comment #6 from Lauri Hänninen <lauri.hanninen@lahti.fi> --- (In reply to Owen Leonard from comment #4)
(In reply to Lauri Hänninen from comment #3)
I don't think the lone Finish button in step 6 or Next button in Confirm custom report -page need the styled arrow
This makes me think that the "Finish" button should probably be relabeled "Next ->" and the button on the next page relabeled "Finish".
I agree here that this would make more sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Another point of confusion is the text "You will need to save the report before you can execute it". That's not true... The report is saved without a title whether or not you update it in the next step. "You may add a title to your report in the next step" ? Should the "Confirm custom report" page be step 7 of 7 rather than the un-numbered step after step 6? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #177950|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180692&action=edit Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 180693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180693&action=edit Bug 39043: (follow-up) Re-number the steps, add back button to more steps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180692|0 |1 is obsolete| | --- Comment #10 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180708&action=edit Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180693|0 |1 is obsolete| | --- Comment #11 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 180709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=180709&action=edit Bug 39043: (follow-up) Re-number the steps, add back button to more steps Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |jonathan.druart@gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #180708|0 |1 is obsolete| | Attachment #180709|0 |1 is obsolete| | --- Comment #13 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188473&action=edit Bug 39043: Style improvement to guided reports controls This patch makes some markup and CSS changes to improve the style of controls in the build guided report process. To test, apply the patch and rebuild the staff interface CSS. - Go to Reports -> Create guided report - In each step of the process, confirm that navigation buttons are styled with Font Awesome arrow icons. - In step 3, confirm that the "Add" and "Delete" buttons are well-styled and aligned well between the two selection boxes. Sponsored-by: Athens County Public Libraries Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188474&action=edit Bug 39043: (follow-up) Re-number the steps, add back button to more steps Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188474|0 |1 is obsolete| | --- Comment #15 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 190680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190680&action=edit Bug 39043: (follow-up) Re-number the steps, add back button to more steps Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 --- Comment #16 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39043 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org