[Bug 38728] New: Add option to automatically trigger cashup summary modal after cashup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Bug ID: 38728 Summary: Add option to automatically trigger cashup summary modal after cashup Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 13985 I actually thought this was already the case... the cashup summary that can be displayed for cashups appearing immediately after a cashup so you can print the transactions. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #1 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 175615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175615&action=edit Bug 38728: Add automatic modal popup for cashups This patch automatically triggers the cashup display modal after a cashup is performed from the Register (singular) details display page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #2 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Our Library would like to be able to view the cashup summary info before actually performing the cashup. Sometimes there are errors and it would be great if we could see those before performing the cashup rather than having to go back and fix something later. We would like to see the data and then have a 'Do you want to proceed' function sort of like a print preview. Could we make this configurable so that libraries could choose what they need? 1. Button to view summary and then proceed with cashup that would then auto display the summary once it was done 2. Existing cashup button that would auto display the summary after cashup as defined in this bug Or should I open a different bug for this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175615|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183071&action=edit Bug 38728: Add automatic modal popup for cashups This patch automatically triggers the cashup display modal after a cashup is performed from the Register (singular) details display page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Just a simple rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183071|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 183275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183275&action=edit Bug 38728: Add automatic modal popup for cashups This patch automatically triggers the cashup display modal after a cashup is performed from the Register (singular) details display page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This enhancement release notes| |automatically displays the | |cash register summary in a | |pop-up window after | |recording a cashup (from | |Point of sale > Cash | |summary for [Library name] | |> select register name > | |Record cashup). --- Comment #6 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Enable the EnablePointOfSale system preference. 2. Enable the UseCashRegisters system preference. 3. Add a debit type that can be sold (Koha administration > Accounting > Debit types). 4. Add a cash register (Koha administration > Accounting > Cash registers > New cash register). 5. Make a sale (Point of sale). 6. Perform a cash up: Point of sale > Cash summary for Centerville > select register name > Record cashup). 7. Note that there is a pop-up window "Confirm cashup of [cash register name]". After pressing "Confirm" you are returned to the transaction history page. 8. Apply the patch. 9. Repeat steps 5 and 6. 10. Note that after pressing the "Confirm" button, a "Cashup summary" pop-up window is shown listing the transactions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183457&action=edit Bug 38728: Add automatic modal popup for cashups on register details page This patch automatically triggers the cashup display modal after a cashup is performed from the individual Register details display page. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Click on a register name to access the individual register page 6. Perform some transactions to create outstanding amounts 7. Click 'Record cashup' button on the register details page 8. Confirm the cashup in the modal dialog 9. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #8 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 183458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183458&action=edit Bug 38728: Add automatic modal popup for cashups in registers summary This patch automatically triggers the cashup display modal after a cashup is performed from the Cash registers summary page when performing a cashup on an individual register. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Perform some transactions to create outstanding amounts 6. Click 'Record cashup' button on an individual register 7. Confirm the cashup in the modal dialog 8. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183275|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement |This enhancement release notes|automatically displays the |automatically displays the |cash register summary in a |cash register summary in a |pop-up window after |pop-up window after |recording a cashup (from |recording a cashup (from |Point of sale > Cash |both the individual cash |summary for [Library name] |register details page and |> select register name > |the cash registers summary |Record cashup). |page). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Unsponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183457|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186668&action=edit Bug 38728: Add automatic modal popup for cashups on register details page This patch automatically triggers the cashup display modal after a cashup is performed from the individual Register details display page. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Click on a register name to access the individual register page 6. Perform some transactions to create outstanding amounts 7. Click 'Record cashup' button on the register details page 8. Confirm the cashup in the modal dialog 9. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183458|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186669&action=edit Bug 38728: Add automatic modal popup for cashups in registers summary This patch automatically triggers the cashup display modal after a cashup is performed from the Cash registers summary page when performing a cashup on an individual register. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Perform some transactions to create outstanding amounts 6. Click 'Record cashup' button on an individual register 7. Confirm the cashup in the modal dialog 8. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Another rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186668|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186670&action=edit Bug 38728: Add automatic modal popup for cashups on register details page This patch automatically triggers the cashup display modal after a cashup is performed from the individual Register details display page. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Click on a register name to access the individual register page 6. Perform some transactions to create outstanding amounts 7. Click 'Record cashup' button on the register details page 8. Confirm the cashup in the modal dialog 9. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186669|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186671&action=edit Bug 38728: Add automatic modal popup for cashups in registers summary This patch automatically triggers the cashup display modal after a cashup is performed from the Cash registers summary page when performing a cashup on an individual register. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Perform some transactions to create outstanding amounts 6. Click 'Record cashup' button on an individual register 7. Confirm the cashup in the modal dialog 8. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|13985 |40625 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] [Omnibus] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40625 [Bug 40625] Cashup re-submissions on page reload -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |nick@bywatersolutions.com --- Comment #14 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- This does not work for me, I tried many times -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40445 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186671|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188867&action=edit Bug 38728: Add automatic modal popup for cashups in registers summary This patch automatically triggers the cashup display modal after a cashup is performed from the Cash registers summary page when performing a cashup on an individual register. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Perform some transactions to create outstanding amounts 6. Click 'Record cashup' button on an individual register 7. Confirm the cashup in the modal dialog 8. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188868&action=edit Bug 38728: (follow-up) Fix cashup modal triggering after POST/REDIRECT/GET implementation The upstream implementation of POST/REDIRECT/GET pattern for cashup operations introduced a regression where the cashup modal would no longer auto-trigger after successful cashup submission. The original approach passed cashup_id as a query parameter in the redirect, but the template variable was not being populated from the URL parameter, causing the JavaScript to receive an empty value. This follow-up implements a more modern and reliable solution using URL hash fragments instead of query parameters: 1. Changed redirect URLs to use hash fragments (e.g., #cashup-123) 2. Updated JavaScript to detect and parse hash fragments on page load 3. Auto-triggers the cashup modal when hash is present 4. Cleans up the URL using history.replaceState() after modal opens Benefits: - Maintains proper POST/REDIRECT/GET pattern - Hash fragments don't trigger server requests or require server-side handling - More reliable than template variable approach - Follows modern web development patterns - Works consistently across both register.pl and registers.pl pages Test plan: 1. Navigate to POS register page (pos/register.pl) 2. Perform a cashup operation 3. Verify the cashup summary modal automatically appears after redirect 4. Verify the URL is clean (no hash fragment visible) 5. Repeat for registers summary page (pos/registers.pl) 6. Perform individual register cashup 7. Verify modal auto-triggers correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186670|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188869&action=edit Bug 38728: Add automatic modal popup for cashups on register details page This patch automatically triggers the cashup display modal after a cashup is performed from the individual Register details display page. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Click on a register name to access the individual register page 6. Perform some transactions to create outstanding amounts 7. Click 'Record cashup' button on the register details page 8. Confirm the cashup in the modal dialog 9. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188867|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188870&action=edit Bug 38728: Add automatic modal popup for cashups in registers summary This patch automatically triggers the cashup display modal after a cashup is performed from the Cash registers summary page when performing a cashup on an individual register. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Perform some transactions to create outstanding amounts 6. Click 'Record cashup' button on an individual register 7. Confirm the cashup in the modal dialog 8. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188868|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 188871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188871&action=edit Bug 38728: (follow-up) Fix cashup modal triggering after POST/REDIRECT/GET implementation The upstream implementation of POST/REDIRECT/GET pattern for cashup operations introduced a regression where the cashup modal would no longer auto-trigger after successful cashup submission. The original approach passed cashup_id as a query parameter in the redirect, but the template variable was not being populated from the URL parameter, causing the JavaScript to receive an empty value. This follow-up implements a more modern and reliable solution using URL hash fragments instead of query parameters: 1. Changed redirect URLs to use hash fragments (e.g., #cashup-123) 2. Updated JavaScript to detect and parse hash fragments on page load 3. Auto-triggers the cashup modal when hash is present 4. Cleans up the URL using history.replaceState() after modal opens Benefits: - Maintains proper POST/REDIRECT/GET pattern - Hash fragments don't trigger server requests or require server-side handling - More reliable than template variable approach - Follows modern web development patterns - Works consistently across both register.pl and registers.pl pages Test plan: 1. Navigate to POS register page (pos/register.pl) 2. Perform a cashup operation 3. Verify the cashup summary modal automatically appears after redirect 4. Verify the URL is clean (no hash fragment visible) 5. Repeat for registers summary page (pos/registers.pl) 6. Perform individual register cashup 7. Verify modal auto-triggers correctly -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- The world shifted beneath us... follow-up gets us working again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188869|0 |1 is obsolete| | --- Comment #21 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190649&action=edit Bug 38728: Add automatic modal popup for cashups on register details page This patch automatically triggers the cashup display modal after a cashup is performed from the individual Register details display page. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Click on a register name to access the individual register page 6. Perform some transactions to create outstanding amounts 7. Click 'Record cashup' button on the register details page 8. Confirm the cashup in the modal dialog 9. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Sally Healey <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188870|0 |1 is obsolete| | --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190650&action=edit Bug 38728: Add automatic modal popup for cashups in registers summary This patch automatically triggers the cashup display modal after a cashup is performed from the Cash registers summary page when performing a cashup on an individual register. Test plan: 1. Enable the point of sale system preference 2. Ensure you have permission for cash_management > cashup 3. Create at least one cash register for your current branch 4. Navigate to More > Point of Sale > Cash registers 5. Perform some transactions to create outstanding amounts 6. Click 'Record cashup' button on an individual register 7. Confirm the cashup in the modal dialog 8. Verify that after page reload, the cashup summary modal automatically opens showing the details of the cashup just performed Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188871|0 |1 is obsolete| | --- Comment #23 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 190651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190651&action=edit Bug 38728: (follow-up) Fix cashup modal triggering after POST/REDIRECT/GET implementation The upstream implementation of POST/REDIRECT/GET pattern for cashup operations introduced a regression where the cashup modal would no longer auto-trigger after successful cashup submission. The original approach passed cashup_id as a query parameter in the redirect, but the template variable was not being populated from the URL parameter, causing the JavaScript to receive an empty value. This follow-up implements a more modern and reliable solution using URL hash fragments instead of query parameters: 1. Changed redirect URLs to use hash fragments (e.g., #cashup-123) 2. Updated JavaScript to detect and parse hash fragments on page load 3. Auto-triggers the cashup modal when hash is present 4. Cleans up the URL using history.replaceState() after modal opens Benefits: - Maintains proper POST/REDIRECT/GET pattern - Hash fragments don't trigger server requests or require server-side handling - More reliable than template variable approach - Follows modern web development patterns - Works consistently across both register.pl and registers.pl pages Test plan: 1. Navigate to POS register page (pos/register.pl) 2. Perform a cashup operation 3. Verify the cashup summary modal automatically appears after redirect 4. Verify the URL is clean (no hash fragment visible) 5. Repeat for registers summary page (pos/registers.pl) 6. Perform individual register cashup 7. Verify modal auto-triggers correctly Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |andrew@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |26.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 --- Comment #24 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38728 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- This bug won't be backported to the 25.11.x branch as it has been deemed an enhancement or new feature. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org