[Bug 20400] New: Add routing list tab to the patron account in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Bug ID: 20400 Summary: Add routing list tab to the patron account in OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: katrin.fischer@bsz-bw.de Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be nice if a patron could see the routing lists he is on in the OPAC. Currently this is only possible from the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72973&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: A list of the routling lists a patron appears on in the OPAC. To test: - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Turn the preference on - the tab should appear now - Add some subscriptions and add your patron to the routing list - Check tab again - it should now show a list of the serials with links to the detail page in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 72974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72974&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Not ready for sign-off yet! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72973|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73115&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72974|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73116&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73117&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73118&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20456 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20456 [Bug 20456] Remove the C4::Serials::GetSubscriptionsFromBorrower -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73115|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73121&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73116|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73122&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73117|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73123&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73118|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73124&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 paxed <pasi.kallinen@joensuu.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen@joensuu.fi --- Comment #13 from paxed <pasi.kallinen@joensuu.fi> --- Comment on attachment 73121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73121 Bug 20400: Add routing list tab in OPAC I'm not quite happy with the title: +<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Your routing lists</title> in Finnish, the word "catalog" could be translated in several different ways, and "Koha online catalog" vs. "$LIBRARY catalog" would use two different words for it to sound more natural ... so perhaps moving the word "catalog" into both parts of the IF - THEN - ELSE block? I know it probably shows up as a single msgid in the po-file, but still -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to paxed from comment #13)
Comment on attachment 73121 [details] [review] Bug 20400: Add routing list tab in OPAC
I'm not quite happy with the title:
+<title>[% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Your routing lists</title>
in Finnish, the word "catalog" could be translated in several different ways, and "Koha online catalog" vs. "$LIBRARY catalog" would use two different words for it to sound more natural ... so perhaps moving the word "catalog" into both parts of the IF - THEN - ELSE block?
I know it probably shows up as a single msgid in the po-file, but still
Hi Pasi, I am using the standard construct here, copied from another page. It's not specific to this patch set. I am not so happy with it either for German translation, but I think this needs a global fix and is outside of scope here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Comment on attachment 73123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73123 Bug 20400: Add unit tests Review of attachment 73123: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20400&attachment=73123) ----------------------------------------------------------------- This + my $patron = $builder->build( { source => 'Borrower' } ); + $patron = Koha::Patrons->find( $patron->{borrowernumber} ); should be replaced by + my $patron = $builder->build_object({ class => 'Koha::Patrons' }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune@bulac.fr --- Comment #16 from Séverine Queune <severine.queune@bulac.fr> --- The new tab correctly appears on opac but when I click on it, I get an Error 500 trying to access this page /cgi-bin/koha/opac-routing-lists.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Séverine Queune from comment #16)
The new tab correctly appears on opac but when I click on it, I get an Error 500 trying to access this page /cgi-bin/koha/opac-routing-lists.pl
Hi Severine, I just retested and don't see the problem. I will fix some tests and maybe you can take another look? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73121|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74291&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73122|0 |1 is obsolete| | --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74292&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73123|0 |1 is obsolete| | --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74293&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73124|0 |1 is obsolete| | --- Comment #21 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74294&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74295&action=edit Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74291|0 |1 is obsolete| | --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74296&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74292|0 |1 is obsolete| | --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74297&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74293|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74298&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74294|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74299&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74295|0 |1 is obsolete| | --- Comment #27 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74300&action=edit Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Dilan Johnpullé <dilan@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74300|0 |1 is obsolete| | --- Comment #28 from Dilan Johnpullé <dilan@calyx.net.au> --- Created attachment 74402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74402&action=edit Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #29 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Dilan Johnpullé from comment #28)
Created attachment 74402 [details] [review] Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt
Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Dilan, it seems you only uploaded the last signed patch. You need to do the same with all the patches. You can try $ cd kohaclone $ git fetch $ git checkout origin/master -b qa_20400 $ git bz apply -s 20400 # then $ git bz attach 20400 HEAD~5.. Ask on IRC if you have trouble doing it. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74296|0 |1 is obsolete| | --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74588&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74297|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74589&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74298|0 |1 is obsolete| | --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74590&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74299|0 |1 is obsolete| | --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74592&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74402|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74593&action=edit Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #29)
(In reply to Dilan Johnpullé from comment #28)
Created attachment 74402 [details] [review] [review] Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt
Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au>
Dilan, it seems you only uploaded the last signed patch. You need to do the same with all the patches. You can try
$ cd kohaclone $ git fetch $ git checkout origin/master -b qa_20400 $ git bz apply -s 20400 # then $ git bz attach 20400 HEAD~5..
Ask on IRC if you have trouble doing it. Thanks!
I've gone ahead and added the sign-off lines on the other Patches. Dilan, I hope that's ok for you and thx a lot for testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74588|0 |1 is obsolete| | Attachment #74589|0 |1 is obsolete| | Attachment #74590|0 |1 is obsolete| | Attachment #74592|0 |1 is obsolete| | Attachment #74593|0 |1 is obsolete| | --- Comment #36 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74632&action=edit Bug 20400: Add routing list tab in OPAC This patch adds the base for the new feature: Show a list of the serial titles a patron is on routing lists for in the OPAC. Test plan applies to the complete patch set: To test: - Apply all patches - Make sure RoutingSerials is not activated - Check patron account in OPAC - no tab should appear - Activate RoutingSerials - Create subscriptions and different routing lists, test with: - Patron with no routing list entries = no tab - Patron with one or more routing list entries = tab appears Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #37 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74633&action=edit Bug 20400: Rewrite using Koha::Objects Adds - Koha::Subscription::Routinglist - Koha::Subscription::Routinglists Adds 2 methods - Koha::Patron::get_routinglists - Koha::Routinglist::subscription Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74634&action=edit Bug 20400: Add unit tests prove t/db_dependent/Koha/Subscription/Routinglists.t prove t/db_dependent/Koha/Patrons.t Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #39 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74635&action=edit Bug 20400: Display new tab in OPAC only for patrons with routing lists The visibility of the routing list tab in the OPAC depends on the system preference RoutingSerials and the existence of routing list entries for the patron. Some libraries only offer routing lists to certain user groups and would not want it generally visible. As there are currently no actions you can perform from the list, this appears to be a reasonable behaviour. See test plan in first patch. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #40 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74636&action=edit Bug 20400: (follow-up) Use Asset TT plugin on opac-routing-lists.tt Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan@calyx.net.au> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #41 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 74637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74637&action=edit Bug 20400: (QA follow-up) Redirect to 404 if routing is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- One minor comment - not entirely sure about testing for routinglists in get_template_and_user - but we don't want to show the tab for all (since only a minority will have them) but this seems to be the easiest method - noting for RM feedback -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_18_05_candidate CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #43 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Few things: 1. get_routinglists should not be get_routing_lists instead? 2. changes to C4::Auth are not needed, since bug 18403 we have a logged_in_user Koha::Patron sent to the template (from C4::Auth, so we have access to it from everywhere). Yes, it's awesome :) So from the template: [% IF logged_in_user && logged_in_user.get_routing_lists.count %] should do the trick. 3. Koha::Patron->get_routing_lists should return the ->search result directly, to let callers use it in scalar or list context. 4. Koha::Subscription::RoutingList->subscription should use DBIC relationship: return Koha::Subscription->_new_from_dbic($self->_result->subscriptionid); 5. "your routing lists" tab is not marked as "active" when needed (routinglistview vs routinglistsview) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #44 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I have pushed a squashed version of these patches by mistake... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #45 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74662&action=edit Bug 20400: (follow-up) Several fixes from RM review - "your routing lists" tab is now highlighted when active - get_routinglists was renamed to get_routing_lists - Koha::Patron->get_routing_lists returns the ->search result directly - Koha::Subscription::RoutingList->subscription uses DBIC relationship -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74662|0 |1 is obsolete| | --- Comment #46 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74664&action=edit Bug 20400: (follow-up) Several fixes from RM review - "your routing lists" tab is now highlighted when active - get_routinglists was renamed to get_routing_lists - Koha::Patron->get_routing_lists returns the ->search result directly - Koha::Subscription::RoutingList->subscription uses DBIC relationship - Undo changes to C4/Auth.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74664|0 |1 is obsolete| | --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 74666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74666&action=edit Bug 20400: (follow-up) Several fixes from RM review - "your routing lists" tab is now highlighted when active - get_routinglists was renamed to get_routing_lists - Koha::Patron->get_routing_lists returns the ->search result directly - Koha::Subscription::RoutingList->subscription uses DBIC relationship - Undo changes to C4/Auth.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #48 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Patches pushed to master for 18.05. Thanks Katrin and sorry again for the confusion :) 6 first patches have been pushed squashed (sorry Nick!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_18_05_candidate |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #49 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Additional notes (for me): there are some stuffs to remove, the BORROWER_INFO and ->unblessed are not needed. We should rewrite patron-title.inc to take a Koha::Patron and adapt the other templates (looks easy to do). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Adds a routing list tab to release notes| |the patron account in the | |OPAC that will be visible | |if RoutingSerials is turned | |on and the user is at least | |on one routing list. Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #50 from Séverine Queune <severine.queune@bulac.fr> --- I'm curious and wanted to see what this new feature looks like but it doesn't work for me (Lewis Caroll was right : it ofter leads to trouble...). I tried with 3 different users with different routing lists configurations (0, 1 and 2 lists) on different browsers (Mozilla, Edge, Chrome) for both my own test instance and Biblibre sandbox#11 (20456 applied), and I always get "Error 500" for my Koha and "Internal Server Error" for Biblibre's. Does someone have an idea of what is going wrong ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #51 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- What's the error in the log? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can't see the error and no way to see it on the sandbox :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20400 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org