[Bug 5511] New: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Summary: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: System Administration AssignedTo: paul.poulain@biblibre.com ReportedBy: amit.gupta@osslabs.biz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Estimated Hours: 0.0 Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #1 from Amit Gupta <amit.gupta@osslabs.biz> 2010-12-16 11:15:58 UTC --- Created attachment 2860 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2860 Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |chris@bigballofwax.co.nz Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Patch Status|Needs Signoff |Does not apply AssignedTo|paul.poulain@biblibre.com |amit.gupta@osslabs.biz --- Comment #2 from Paul Poulain <paul.poulain@biblibre.com> 2011-03-01 21:16:22 UTC --- The patch does not apply anymore -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2860|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-07 23:31:38 UTC --- Created attachment 4585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4585 Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #4 from Chris Cormack <chris@bigballofwax.co.nz> 2011-07-07 23:31:49 UTC --- Created attachment 4586 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4586 Bug 5511 Updating all other language sysprefs -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Frère Sébastien Marie <semarie-koha@latrappe.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |semarie-koha@latrappe.fr --- Comment #5 from Frère Sébastien Marie <semarie-koha@latrappe.fr> 2011-07-08 06:16:38 UTC --- Firstly, if I have understand the default value for the preference in the patch, the security of all koha-based library will downgrade to "Disable by default" ? (The default is set to "0") I will prefer the option "secure by default". For more security information, see http://capec.mitre.org/data/definitions/60.html [CAPEC-60: Reusing Session IDs (aka Session Replay)]. The restrict-by-IP check is a "multifactor authentication". Secondly, does this solution isn't worst than the problem ? I think the problem is a "by session" problem for some roaming users. And this solution is disable globally security check at "site level". An alternation solution is an option at the login page: "restrict session by this IP ? Y/n" (and "Y" by default, of course). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Needs Signoff |Failed QA --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-09-12 13:47:48 UTC --- QA comment(s) Before testing this patch, some QA comments : + remoteipcheck => C4::Context->preference("remoteipcheck"), seems useless to me = there's no need to send this syspref to the templates (and you don't doo anything with it anyway) Also note that this patch won't apply anymore due to the changes in the syspref system that has been pushed recently (see bug 6537) Also note that we have suggested/proposed that updatedatabase are provided in a separate patch, so as you take care of the previous suggestion, can you do this as well ? Could you submit an enhanced patch please, and reset to "need signoff", I set "failed QA" -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- One of our customers ran into this recently. Given the continued existence of things like web proxy farms that can result in REMOTE_ADDR changing from request to request, a general question -- are there any improvements in the state of the art for anti-session-hijacking measures that would reasonably allow us to remove the IP address check (or implement a syspref like Amit's patch tried)? IMO, a "restrict session by this IP ? Y/n" widget on the login form doesn't seem like a friendly UI choice. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #8 from Frère Sébastien Marie <semarie-koha@latrappe.fr> --- (En réponse au commentaire 7)
One of our customers ran into this recently. Given the continued existence of things like web proxy farms that can result in REMOTE_ADDR changing from request to request, a general question -- are there any improvements in the state of the art for anti-session-hijacking measures that would reasonably allow us to remove the IP address check (or implement a syspref like Amit's patch tried)?
If I remember well, the patch disable by default IP restriction. It is bad: hijacking will be easy (just need to steal cookie, with XSS for example).
IMO, a "restrict session by this IP ? Y/n" widget on the login form doesn't seem like a friendly UI choice.
but bugzilla propose the same on logon (and advice that is better to run with). It should be ok with a system with a syspref "session restriction by IP" - always (and no choice at logon) - yes (choice at logon and yes by default) - no (choice at logon and no by default) - never (and no choice at logon) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED CC| |amitddng135@gmail.com Assignee|amit.gupta@osslabs.biz |amitddng135@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4585|0 |1 is obsolete| | Attachment #4586|0 |1 is obsolete| | --- Comment #9 from Amit <amitddng135@gmail.com> --- Created attachment 21864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21864&action=edit Check for Change in Remote IP address for Session Security. Disable when remote IP address changes frequently To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #10 from Amit <amitddng135@gmail.com> --- Created attachment 21865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21865&action=edit Added new system preference: SessionRestrictionByIP Added new system preference: SessionRestrictionByIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit Gupta <kohapatch@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohapatch@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org When did the bot| |2013-10-30 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug -5511- Added new system preference: SessionRestrictionByIP Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Patch failed at 0001 Bug -5511- Added new system preference: SessionRestrictionByIP The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21864|0 |1 is patch| | Attachment #21864|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21865|0 |1 is patch| | Attachment #21865|application/mbox |text/plain mime type| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21865|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 22533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22533&action=edit Bug -5511- Added new system preference: SessionRestrictionByIP -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- This patch set adds a new syspref, which disables session restrict by IP, by default. Which is dangerous, this should be a conscious decision made by someone knowing that they are reducing security. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Pablo AB <pablo.bianchi@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi@gmail.com --- Comment #14 from Pablo AB <pablo.bianchi@gmail.com> --- As Paul and Galen talk here http://koha.1045719.n5.nabble.com/quot-IP-address-has-changed-Please-log-in-... this sometimes is really annoying, getting a logout with a "IP address has changed. Please log in again" every 15'. A workaround sometimes include setting up well Firefox, not using proxy for the IP for IPs where it is Koha. This is not an option if Koha is hosted on Amazon Cloud or somewhere else. Is very common error of users playing with Koha Demos. Deeper look is necessary, since this IP changes doesn't look a problem with other accounts login, so probably are other strategies friendlier but secure. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #15 from Marc Véron <veron@veron.ch> --- (In reply to Chris Cormack from comment #13)
This patch set adds a new syspref, which disables session restrict by IP, by default.
Which is dangerous, this should be a conscious decision made by someone knowing that they are reducing security.
Is still an issue, see "[Koha] IP Address Changed" on mailing list today. Maybe we should think about sysprefs that are only avallable to the database user. Marc -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #16 from Chris Cormack <chris@bigballofwax.co.nz> --- (In reply to Marc Véron from comment #15)
(In reply to Chris Cormack from comment #13)
This patch set adds a new syspref, which disables session restrict by IP, by default.
Which is dangerous, this should be a conscious decision made by someone knowing that they are reducing security.
Is still an issue, see "[Koha] IP Address Changed" on mailing list today.
Maybe we should think about sysprefs that are only avallable to the database user.
Marc
The problem is just that the patch sets the ip restriction off by default, instead of on by default, and having to make a decision to potentially reduce security. It would have been a simple change, but the patch author has left it to languish as Failed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Amit <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #17 from Amit <amitddng135@gmail.com> --- Hi Chris, I will recreate this patch. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- *** Bug 3578 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Any further movement on this Amit? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21864|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34216&action=edit [SIGNED OFF] Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22533|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34218 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34218&action=edit [SIGNED OFF] Bug -5511- Added new system preference: SessionRestrictionByIP Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #22 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34219 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34219&action=edit Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #23 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I gave up on waiting for Amit here. I agree with, and have implemented as a followup, the reversal of defaults that Chris suggests. I've also signed off on the first two patches. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34219|0 |1 is obsolete| | --- Comment #24 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34252&action=edit Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #25 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34320 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34320&action=edit Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This aptch adds in the relevant statement. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #26 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- That last followup still needs a signoff.. not sure how I missed it when testing first time around. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34320|0 |1 is obsolete| | --- Comment #27 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34616&action=edit Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This patch adds in the relevant statement. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34709 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34709&action=edit [PASSED QA] Bug - 5511: Check for Change in Remote IP address for Session Security. Disable when remote ip address changes frequently. To Test: 1) Enable the system preference SessionRestrictionByIP 2) Change your system IP. It will not checkout your system IP or signout. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34710 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34710&action=edit [PASSED QA] Bug -5511- Added new system preference: SessionRestrictionByIP Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34711 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34711&action=edit [PASSED QA] Bug - 5511 [Followup]: Switched defults Agree with Chris that the defualt should maintain the higher security and not reduce it. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34712 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34712&action=edit [PASSED QA] Bug - 5511 [Followup]: Missed Instance There was an instance of the pragma missed which meant the the original patch set didn't actually solve the problem in a large number of cases This patch adds in the relevant statement. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 34713 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34713&action=edit Bug 5511: QA follow up - several fixes - Move database update entry to correct spot - Fix version number in database update - Fix capitalization in sys pref description - Fix sequence in sysprefs.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34216|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34616|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34218|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34252|0 |1 is obsolete| | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Maybe we could phrase the system preference description a bit stronger. I added a follow up with some fixes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34713|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 34824 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34824&action=edit [PASSED QA] Bug - 5511: [Followup]: QA Fixes - Move database update entry to correct spot - Fix version number in database update - Fix capitalization in sys pref description - Fix sequence in sysprefs.sql Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to Module Maintainers Branch - https://github.com/mrenvoize/Koha/tree/authentication -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Pushed by Module Maintainer |Pushed to Master --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Amit! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #37 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5511 --- Comment #38 from Mason James <mtj@kohaaloha.com> --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org