http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #1 from David Cook <dcook@prosentient.com.au> --- (In reply to Mason James from comment #0)

Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks

Do you have a specific example that can be tested? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #3 from Mason James <mtj@kohaaloha.com> --- Created attachment 33891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33891&action=edit 245b visibile -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #5 from Mason James <mtj@kohaaloha.com> --- Created attachment 33893 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33893&action=edit 245b now hidden in editor?! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #6 from Mason James <mtj@kohaaloha.com> --- Created attachment 33928 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33928&action=edit fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #8 from Mason James <mtj@kohaaloha.com> --- i should add a bit more info about 'hidden' values, for the record if you look in the add_biblio.tt template file, you can see the logic for the values.. based on this code, it seems to me that any subfield that's 'hidden' value is <= -4 or >= 5 should be hidden in the editor, yes? --------------------------------- if ( flagged_checked ) { hidden_value='-8'; } else if ( opac_checked && ! intranet_checked && ! editor_checked && collapsed_checked ) { hidden_value='-7'; } else if ( opac_checked && intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='-6'; } else if ( opac_checked && intranet_checked && ! editor_checked && collapsed_checked) { hidden_value='-5'; } else if ( opac_checked && ! intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='-4'; } else if ( opac_checked && ! intranet_checked && editor_checked && collapsed_checked) { hidden_value='-3'; } else if ( opac_checked && ! intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='-2'; } else if ( opac_checked && intranet_checked && editor_checked && collapsed_checked) { hidden_value='-1'; } else if ( opac_checked && intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='0'; } else if ( ! opac_checked && intranet_checked && editor_checked && collapsed_checked) { hidden_value='1'; } else if ( ! opac_checked && ! intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='2'; } else if ( ! opac_checked && ! intranet_checked && editor_checked && collapsed_checked) { hidden_value='3'; } else if ( ! opac_checked && intranet_checked && editor_checked && ! collapsed_checked) { hidden_value='4'; } else if ( ! opac_checked && ! intranet_checked && ! editor_checked && collapsed_checked) { hidden_value='5'; } else if ( ! opac_checked && intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='6'; } else if ( ! opac_checked && intranet_checked && ! editor_checked && collapsed_checked) { hidden_value='7'; } else if ( ! opac_checked && ! intranet_checked && ! editor_checked && ! collapsed_checked) { hidden_value='8'; } --------------------------------- -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 wajasu <matted-34813@mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33928|0 |1 is obsolete| | CC| |matted-34813@mypacks.net --- Comment #10 from wajasu <matted-34813@mypacks.net> --- Created attachment 34007 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34007&action=edit SIGNED-OFF-fix-for-13331-Bug-13331-Subfield-does-not Followed steps for 245b (see breadcrumb in 33892) Once selecting default framework MARCStructure link, searched for 245, "Subfields" link, then "b" -> advanced. Above test plan worked. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Irma Birchall <irma@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |irma@calyx.net.au --- Comment #11 from Irma Birchall <irma@calyx.net.au> --- (In reply to wajasu from comment #10)

Created attachment 34007 [details] [review] SIGNED-OFF-fix-for-13331-Bug-13331-Subfield-does-not

Followed steps for 245b (see breadcrumb in 33892) Once selecting default framework MARCStructure link, searched for 245, "Subfields" link, then "b" -> advanced.

Above test plan worked.

I have also tested using a biblibre sandbox and found the patch works as expected. I tested several conditions with no error. Thank you Mason! Adding a sign-off. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34007|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34151 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34151&action=edit [PASSED QA] fix for 13331 [Bug 13331] Subfield does not show in cataloging editor - if subfield is disabled in OPAC/enabled in Staff, via frameworks to test... 1/ attempt to add a new bib in the cataloguing editor, default framewok - observe 245b subfield is visible in the editor, for tab 2 2/ uncheck the OPAC visibility for 245b, within the framework editor - then save 3/ repeat step 1/ - observe that the 245b subfield has disappeared from the cataloguing editor! 4/ apply patch, 5/ repeat step 1/ - observe that the 245b subfield now displays correctly in the cataloguing editor note: this looks looks like a typo bug, that has been in koha for years Signed-off-by: wajasu <matted@34813.mypacks.net> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #14 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x, will be in 3.18.2 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 --- Comment #17 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Mason James from comment #15)

(In reply to Tomás Cohen Arazi from comment #13)

...

Patch pushed to master.

Thanks Mason!

PS. try to tidy your commit messages a bit next time :-D

can you show me an example of an untidy commit message from me?

Sorry, I meant the subject! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13331 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_3_16_candidate | -- You are receiving this mail because: You are watching all bug changes.