http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433 --- Comment #1 from Galen Charlton <gmcharlt@gmail.com> --- After some grepping, I've turned up one other example of a colspan value being calculated in the script, not the template: members/statistics.pl: length_keys => scalar( @statistic_column_names), koha-tmpl/intranet-tmpl/prog/en/modules/members/statistics.tt: <td colspan="[% length_keys %]">TOTAL</td> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch Depends on| |12233 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> ---

members/statistics.pl: length_keys => scalar( @statistic_column_names),

I have moved this issue to Bug 12693 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30650|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30802&action=edit [PASSED QA] Bug 10433 - colspan calculation done by opac/opac-reserve.pl should be moved to template Since the bootstrap OPAC's place hold interface doesn't use tables there is no use for the colspan calculation being done in the script. This patch removes it. To test, place one or more holds in the OPAC and confirm that there are no display problems. The OPAC error logs should show no associated error. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No display problems, no related errors on log, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes tests and QA script, no regressions found. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10433 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.