[Bug 12494] New: Remove yuipath system preference
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Bug ID: 12494 Summary: Remove yuipath system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: System Administration Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In future versions of Koha the OPAC prog template and its YUI dependencies will not exist. This leaves only the basketgroups page in the staff client which uses any YUI assets. For the sake of simplicity I think the yuipath preference should be removed and the path to local YUI assets be hard-coded in the basketgroups template. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12233 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29330&action=edit Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #2 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #3 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 29391 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29391&action=edit Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29391|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 29514 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29514&action=edit [PASSED QA] Bug 12494 - Remove yuipath system preference With the OPAC prog template going away, the only remaining use of the yuipath preference is on the basketgroups template. The yuipath preference should be removed and the local path hard-coded. This patch: - removes yuipath handling from C4/Templates.pm - removes the preference from sysprefs.sql - deletes the preference via updatedatabase.pl - removes the preference from the staff client preferences file - removes unused references to the YUI assets from the help file header include - adds the local YUI asset path to acqui/basketgroup.tt To test, apply the patch and run the database update. View some online help pages and confirm that they function correctly. View the basketgroups page (Acquisition -> Vendor -> Basket groups), edit a basket group, and confirm that basket drag and drop operations work correctly. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Online help and basket group drag&drop functionality still work correctly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- In my opinion, this patch should not be pushed before bug 12233. It will break ccsr and prog themes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Oh, what did I miss? I had tested a few pages in staff, are we still using yui in OPAC? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- git grep yuipath returns: koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/utilities/utilities.js"></script> koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/container/container-min.js"></script> koha-tmpl/opac-tmpl/ccsr/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/menu/menu-min.js"></script> koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/utilities/utilities.js"></script> koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/container/container-min.js"></script> koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc:<script type="text/javascript" src="[% yuipath %]/menu/menu-min.js"></script> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:<script type="text/javascript" src="[% yuipath %]/utilities/utilities.js"></script> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:<script type="text/javascript" src="[% yuipath %]/container/container-min.js"></script> koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:<script type="text/javascript" src="[% yuipath %]/menu/menu-min.js"></script> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I need to get better with grep - thx for catching this! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- This patch doesn't touch the prog and ccsr templates because it is dependent on their removal. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Blocks| |11346 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Bug 12494 depends on bug 12233, which changed state. Bug 12233 Summary: remove prog and CCSR OPAC themes http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12233 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12494 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org