[Bug 37818] New: XXX trick in installer code is not longer needed
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Bug ID: 37818 Summary: XXX trick in installer code is not longer needed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org CC: tomascohen@gmail.com We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=34088 Depends on| |13068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13068 [Bug 13068] New feature for DB update and sandbox -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 170964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170964&action=edit Bug 37818: Remove 'XXX' from the installer code We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170964|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 170976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170976&action=edit Bug 37818: Remove 'XXX' from the installer code We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Read the diff for the patch - looks OK to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170976|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 171129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171129&action=edit Bug 37818: Remove 'XXX' from the installer code We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). We do no longer need this code. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |julian.maurice@biblibre.com |y.org | CC| |julian.maurice@biblibre.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Unfortunately, this broke tests: # Subtest: get_atomic_updates method 1..1 ok 1 - get_atomic_updates returns correct files ok 4 - get_atomic_updates method # Failed test 'TransformToNum('18.05.02.XXX') = '18.0502999'' # at t/db_dependent/Koha/Installer.t line 116. # got: '18.0502XXX' # expected: '18.0502999' # Failed test 'TransformToNum('19.11.02.XXX') = '19.1102999'' # at t/db_dependent/Koha/Installer.t line 116. # got: '19.1102XXX' # expected: '19.1102999' # Looks like you failed 2 tests of 5. # Failed test 'TransformToNum' # at t/db_dependent/Koha/Installer.t line 119. I guess we can just remove these now? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 171468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171468&action=edit Bug 37818: (follow-up) Remove failing XXX tests from Installer.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I've removed the failing XXX related tests and reset the test counter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37818 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Doesn't apply clean to 24.05, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org