https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 --- Comment #1 from Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 170928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170928&action=edit Bug 37797: Change cancel button to a link styled as a button On the confirmation page for deleting a budget, change "Do not delete" from a form submission to a link (styled to look like a button) in order to avoid errors from POSTing with no op. To test: 1. Go to Acquisitions > Budgets 2. Create a test budget 3. Attempt to delete the test budget 4. On the confirmation page, click "No, don't delete" --> An error appears saying that the form was POSTed with no op! 5. Apply patch 6. Repeat steps 3-4 --> You are linked back to the Budgets page. The budget was not deleted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org --- Comment #2 from Phil Ringnalda <phil@chetcolibrary.org> --- Interesting bustage, that the before state, which is supposed to be a POST without an op, was actually a POST with the wrong op. We have templates that set $template->param(script_name=> to a string containing their actual path, but this one doesn't, so the template var script_name was apparently getting the path from the page's URL through some magic. Bet that's a whole new class of bug 36192 bustage we haven't yet noticed, where a script that was only getting POSTs now also gets GETs, and doesn't set script_name, and has a template that uses script_name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 Chloe Zermatten <chloe.zermatten@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170928|0 |1 is obsolete| | --- Comment #4 from Chloe Zermatten <chloe.zermatten@ptfs-europe.com> --- Created attachment 170977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170977&action=edit Bug 37797: Change cancel button to a link styled as a button On the confirmation page for deleting a budget, change "Do not delete" from a form submission to a link (styled to look like a button) in order to avoid errors from POSTing with no op. To test: 1. Go to Acquisitions > Budgets 2. Create a test budget 3. Attempt to delete the test budget 4. On the confirmation page, click "No, don't delete" --> An error appears saying that the form was POSTed with no op! 5. Apply patch 6. Repeat steps 3-4 --> You are linked back to the Budgets page. The budget was not deleted. Signed-off-by: Chloe Zermatten <chloe.zermatten@ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Filed bug 37826 for the unset script_name problem. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37797 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.