[Bug 31758] New: Add 'page-section' to system preferences page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Bug ID: 31758 Summary: Add 'page-section' to system preferences page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com We need the page-section divs adding to the system preferences page to ensure proper contrast for even/odd rows on the tables. See https://github.com/jajm/koha-staff-interface-redesign/issues/55 for discusion. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |30952 Blocks| |31757 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 [Bug 30952] New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31757 [Bug 31757] Add 'page-section' where it's missing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141769&action=edit Bug 31758: OPTION 1 - Add page-section to prefs-tab div This patch simply adds the new page-section class to the existing prefs-tab div encasing the whole tab content inside a 'card' display. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141770&action=edit Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Needs some input.. calling Owen :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com, | |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Option 1 just works.. Option 2 splits the content up more and 'might' be nicer.. but needs a little refinement still if people like it.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 141793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141793&action=edit Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- My preference is option 2, with some padding between the sections. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Excellent follow-up Owen, thanks.. I think I prefer option 2 too... However, what do you think to what it does to the look of search results when you search for a system preference?.. It's not terrible, but also doesn't look quite right to me yet either... contemplating. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Also... if I do a search for a preference, say 'UserJS'.. if I then click through using the 'View all X preferences' link on the right of the section.. I end up with a larger top margin on the section I'm looking at.. seems to come from custom styling on 'h3:target'.. not sure how/what it was/is trying to achieve and whether we're safe to remove it now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #7)
Excellent follow-up Owen, thanks.. I think I prefer option 2 too...
However, what do you think to what it does to the look of search results when you search for a system preference?.. It's not terrible, but also doesn't look quite right to me yet either... contemplating.
I also prefer option #2. When you search for system preferences and return more than 1 in a single category they look a bit "smushed" together. If there was just a tiny margin between the two I think it looks more organized. IMHO. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #9)
(In reply to Martin Renvoize from comment #7)
Excellent follow-up Owen, thanks.. I think I prefer option 2 too...
However, what do you think to what it does to the look of search results when you search for a system preference?.. It's not terrible, but also doesn't look quite right to me yet either... contemplating.
I also prefer option #2.
When you search for system preferences and return more than 1 in a single category they look a bit "smushed" together. If there was just a tiny margin between the two I think it looks more organized. IMHO.
Ignore my comment, this does create a nice margin. I didn't 'yarn build'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141770|0 |1 is obsolete| | --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141830&action=edit Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141793|0 |1 is obsolete| | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 141831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141831&action=edit Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 141834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141834&action=edit Bug 31758: (follow-up) Remove fat margin-top This removes the increased top margin appearing on subsection headings after clicking through from search.. I'm not sure if we need it or not now.. the original feature it appeared to help with doesn't work for me.. scroll to section doesn't happen. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Martin Renvoize from comment #13)
Created attachment 141834 [details] [review] Bug 31758: (follow-up) Remove fat margin-top
This removes the increased top margin appearing on subsection headings after clicking through from search..
The purpose of the extra margin can be seen if you click one of the sidebar subheadings to jump down. Without the extra margin, when you jump to that section the heading is obscured by the floating toolbar. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Owen Leonard from comment #14)
(In reply to Martin Renvoize from comment #13)
Created attachment 141834 [details] [review] [review] Bug 31758: (follow-up) Remove fat margin-top
This removes the increased top margin appearing on subsection headings after clicking through from search..
The purpose of the extra margin can be seen if you click one of the sidebar subheadings to jump down. Without the extra margin, when you jump to that section the heading is obscured by the floating toolbar.
I suggest we leave the last patch off for now, and then we could figure this one out still on a separate bug if we want. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141830|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141915&action=edit Bug 31758: OPTION 2 - Add page-section div around subsections An alternative that puts adds a new page-section div around each preference subsection rather than around the whole tab section. Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141831|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 141916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141916&action=edit Bug 31758: OPTION 2 (follow-up) Add padding between adjacent sections Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141834|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call obsoleting the third patch.. we probably should have a big for it though ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #18)
Good call obsoleting the third patch.. we probably should have a big for it though ;)
I left it open, because after Owen's explanation I was ok with the current behaviour. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31758 Bug 31758 depends on bug 30952, which changed state. Bug 30952 Summary: New design for staff interface https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30952 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org