http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |fridolyn.somers@biblibre.co | |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- I confirm. The Bug 6488 introduced to hide a record with only hidden items. This concerns only records managed in result page (depends on offset and results per page). But this causes several problems : - search hints (total number of results) returned by Zebra seems false when there are hidden records. That's what reports D Ruth Bavousett. - offset and results per page does not correspond to results displayed when there are hidden records. There can be only 2 results displayed in first page with a 20 results per page and clicking on next page will be offset=20. - when there is only one result and this one is hidden, leads to a 404 error page. (Because test is based on zebra total hints). Note that hiding records in OPAC can be managed with OpacSuppress syspref. In this case Zebra does not return hidden records, so everything is correct. So can we keep this feature ? I seems very difficult to correct. I had the idea to perform hidden test during Zebra indexing to set OPAC suppress flag but this will cause a longer indexing (due to database queries). -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7690 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12004|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 12042 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12042&action=edit Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com QA Contact| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)

Created attachment 12042 [details] Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

patch looks good, passing QA... $ koha-qa.pl testing 1 commit(s) (applied to commit 60790d0) * 82c74b0 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query C4/Search.pm * C4/Search.pm OK -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |nengard@gmail.com --- Comment #7 from Nicole C. Engard <nengard@gmail.com> --- I would like to sign off on this because this is confusing. But the patch doesn't apply: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging C4/Search.pm CONFLICT (content): Merge conflict in C4/Search.pm Failed to merge in the changes. Patch failed at 0001 Bug 8462: OpacHiddenItems and hidelostitems hide items, but query result count is off When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Nicole C. Engard <nengard@gmail.com> --- I think this works to avoid confusion for now and we should come up with a way to hide bib records later on. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think hiding the record with the last item being hidden has been in Koha for a while now. While it's not good that the result count is off, I don't think we can just revert this behaviour that has been advertised and that library have been using in their collections. More so as the records being hidden now will just quietly reappear after the update (if I understand the change made here correctly). I think we need a way to control this - yes, maybe a new system preference. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no --- Comment #14 from Magnus Enger <magnus@enger.priv.no> --- (In reply to comment #12)

I don't think we can just revert this behaviour that has been advertised and that library have been using in their collections.

+1 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #16 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- But what about the several bugs and strange behaviors due to this feature ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #18 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #17)

If you want this in, I would suggest adding a systempreference to turn the hiding biblio feature off. I agree, a syspref is a good idea. Maybe 'OpacHideRecordHiddenItems'. A suggestion on the name ?

-- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #20 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #19)

Hm, maybe it can be grouped together for display with the OpacHidenItems pref. So that people find the new option easily.

OpacHiddenItemsRecord maybe?

+1 OpacHiddenItemsHidesRecord ? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #22 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- What about using zebra "Suppress" index to allow librarians to hide propely and automatically records when all items are hidden by OpacHiddenItems or Hidelostitems, without generating 404 error? When all items are hidden by OpacHiddenItems or Hidelostitems, Koha will put a "1" in a field of the record mapped with Suppress index. I see 2 possibilties : 1. We can use the field indexed in "Suppress" in the current record.abs of the library Drawback : if one item is added again to this record, or if the library change the value of OpacHiddenItems (to show again all items), librarians will have to change manually the value of this field => not good for me. 2. We can use an other field, so that 2 fields in zebra will be index in "Suppress". For example, lets say 099$f and 099$k. 099$f will be used to change manually the visibiliy of record, 099$k to change it automatically if and only if all items are hidden by OpacHiddenItems or Hidelostitems. So a record could have 0-1, 1-1, 1-0, 0-0. I suppose we will need to store the value of this new field in a syspref (as it could be different in each library). Drawback : better, but need to rebuild zebra. Your opinion? (I had the begining of an other idea, with a new field in biblio table, but to complicated, and it is to fuzzy in my mind...) M. Saby Rennes 2 University -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, I am not sure I understand how the suppress index would work here, so I have a question. :) We regularly import records from our union catalog. It's an automatic process, so everytime a record is updated in the union catalog by any participating library the record will be overlayed in Koha during the next night. If a library chooses to suppress records by certain criteria (opachiddenitems) - would that be overwritten too or can it be preserved by setting the flag automatically pre-indexing? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #26 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- (In reply to comment #23)

(In reply to comment #22) +1 for solution 2.

I think indeed the best solution is to use Suppress index. The automatic suppress field could be updated in rebuild_zebra.pl. An idea for syspref : OpacAutoSuppressField.

A better solution is to add a new column to biblio or bilioitems table, mapped with opacsuppress subfield. This can be used to forbid access to a biblio via URL direct edition. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=9778 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Kyle M Hall <kyle@bywatersolutions.com> --- Well that didn't work out ; ) Patch no longer solves the problem. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #12590|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27038 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27038&action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles "test 1" through "test 5" with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for "test" 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27038|0 |1 is obsolete| | --- Comment #31 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 27039 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27039&action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles "test 1" through "test 5" with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for "test" 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |paola.rossi@cineca.it --- Comment #32 from Paola Rossi <paola.rossi@cineca.it> --- I test against master 3.15.00.051 Applying: Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Failed to merge in the changes. Patch failed at 0001 Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27039|0 |1 is obsolete| | --- Comment #33 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 28791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28791&action=edit Bug 8462 - OpacHiddenItems and hidelostitems hide items, but query result count is off Both OpacHiddenItems and hidelostitems work, and Dobrica's recent patch to remove the numbering if OpacHiddenItems is used is a swell idea (hidelostitems needs that, too!), but in either event, the hit count at the top of the result list is off. Test Plan: 1) Create 5 records with the titles "test 1" through "test 5" with one item each 2) enable hidelostitems 3) Mark one of the items as lost 4) Rebuild your zebra index 5) Search for "test" 6) Note the results count is off 7) Apply this patch 8) Re-run the search 9) Note the results count is now correct -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #35 from Paola Rossi <paola.rossi@cineca.it> --- I've applied against master 3.17.00.007 I set pref OpacHiddenItems to itemlost: [1] On OPAC the results count is 4 instead of 5, correct as required. So I pass the patch to "Signed Off" status. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|mtj@kohaaloha.com |testopia@bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Mark, should this be reset to 'needs signoff' then? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11909 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8462 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |MOVED --- Comment #41 from Paola Rossi <paola.rossi@cineca.it> --- I pass this bug to a "Resolved - Moved" status because this solution is a dead end. See bug 11909. -- You are receiving this mail because: You are watching all bug changes.