[Bug 12376] New: blinking cursor not clear in larger resolutions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Bug ID: 12376 Summary: blinking cursor not clear in larger resolutions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 28684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28684&action=edit easy to see on higher resolution This is one that I'm not sure we can fix, but users have noticed that the cursor isn't easy to see on higher resolutions. See my screenshots for examples - is there a way to add some padding or something on the boxes in Koha? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #1 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 28685 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28685&action=edit cursor right on the edge of the box and hard to see -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- The problem is easy to fix with jQuery, but introduces other issues due to unconventional uses of text boxes. For example, I can add padding to the text boxes with this: $("input[type='text']").css("padding","2px"); But unfortunately Koha has started adding graphics inside the text boxes, such as a padlock in some of the marc fields in cataloging. If these images were on the outside of the textbox rather than inside, this would be fixed. However, additional code would have to be used to detect and exclude these instances. I agree that in general, the text boxes need some padding inside. Not being able to see the cursor when it is right on top of the textbox border has been an ongoing nuisance. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- For a temp workaround, this seems to work better, and ignores boxes with the readonly class for the graphic in the marc fields: $("input[type='text']").not(".readonly").css("padding","2px"); Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- If you want to globally set custom CSS in the staff client, the IntranetUserCSS preference is what you want: input[type='text'] { padding : 2px; } input[type='text'].readonly { padding-left : 15px; } There's no reason to make JavaScript do that work on every page load if plain CSS can do it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Thank you, Owen. I do so much in jQuery, I tend to forget I can alter the CSS directly. You smart - me working on it ;) In either case, I did notice that the check in textbox is lacking the type attribute. I will file a separate bug on that. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 33622 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33622&action=edit Bug 12376 - blinking cursor not clear in larger resolutions This patch slightly alters the padding on <input> and <textarea> so that the cursor is more visible. To test, apply the patch and clear your browser cache. View a variety of pages in the staff client and confirm that the change does not adversely affect the display of forms. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33622|0 |1 is obsolete| | --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 33627 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33627&action=edit Bug 12376 - blinking cursor not clear in larger resolutions This patch slightly alters the padding on <input> and <textarea> so that the cursor is more visible. To test, apply the patch and clear your browser cache. View a variety of pages in the staff client and confirm that the change does not adversely affect the display of forms. Small change that enhances user experience. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33629 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33629&action=edit [PASSED QA] Bug 12376 - blinking cursor not clear in larger resolutions This patch slightly alters the padding on <input> and <textarea> so that the cursor is more visible. To test, apply the patch and clear your browser cache. View a variety of pages in the staff client and confirm that the change does not adversely affect the display of forms. Small change that enhances user experience. Patch behaves as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, small CSS change. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33627|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12376 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13370 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org