[Bug 33410] New: Use template wrapper for breadcrumbs: Patron card creator
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Bug ID: 33410 Summary: Use template wrapper for breadcrumbs: Patron card creator Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update patron card creator templates so that they use the new template wrapper for breadcrumbs. - patroncards/edit-batch.tt - patroncards/edit-layout.tt - patroncards/edit-profile.tt - patroncards/edit-template.tt - patroncards/home.tt - patroncards/image-manage.tt - patroncards/manage.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149138&action=edit Bug 33410: Use template wrapper for breadcrumbs: Patron card creator This patch updates several patron card creator templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added <span> around a few other strings in edit-profile.tt and edit-template.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron card creator - New -> - Card batch - Image - Layout - Card template - Printer profile - Manage -> - Card batches - Images - Layouts - Card templates - Printer profiles -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149138|0 |1 is obsolete| | --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 149191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149191&action=edit Bug 33410: Use template wrapper for breadcrumbs: Patron card creator This patch updates several patron card creator templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added <span> around a few other strings in edit-profile.tt and edit-template.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron card creator - New -> - Card batch - Image - Layout - Card template - Printer profile - Manage -> - Card batches - Images - Layouts - Card templates - Printer profiles Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149191|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149302&action=edit Bug 33410: Use template wrapper for breadcrumbs: Patron card creator This patch updates several patron card creator templates so that they use the new WRAPPER for displaying breadcrumbs. Unrelated minor change: I added <span> around a few other strings in edit-profile.tt and edit-template.tt in order to improve translatability. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - Tools -> - Patron card creator - New -> - Card batch - Image - Layout - Card template - Printer profile - Manage -> - Card batches - Images - Layouts - Card templates - Printer profiles Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.05 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33410 --- Comment #5 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org