[Bug 33429] New: Use template wrapper for breadcrumbs: Plugins
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Bug ID: 33429 Summary: Use template wrapper for breadcrumbs: Plugins Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 32507 To continue the process started by Bug 32507, this patch will update plugins templates so that they use the new template wrapper for breadcrumbs. - plugins-disabled.tt - plugins-home.tt - plugins-upload.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32507 [Bug 32507] Use template wrapper to build breadcrumb navigation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 149230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149230&action=edit Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: <enable_plugins>0</enable_plugins> - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): <enable_plugins>1</enable_plugins> - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com --- Comment #2 from Andrew Auld <andrew.auld@ptfs-europe.com> --- I notice that on the plugins-home page (page title Plugins > Tools > Koha), the breadcrumb is: home > Tools > Plugins But on the plugins-upload page (page title Upload plugin > Plugins > Tools > Koha), the breadcrumb is: home > Plugins > Upload plugins Is this what you intended? I wasn't able to test the 'plugins-disabled' page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- There are some existing inconsistencies in the plugins breadcrumbs which stem from the conflict between Koha's division of "tool plugin" from "other plugin." My patch doesn't attempt to resolve this, it just replaces the markup around what is there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149230|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 149288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149288&action=edit Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: <enable_plugins>0</enable_plugins> - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): <enable_plugins>1</enable_plugins> - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149288|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 149301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149301&action=edit Bug 33429: Use template wrapper for breadcrumbs: Plugins This patch updates plugin management templates so that they use the new WRAPPER for displaying breadcrumbs. To test, apply the patch and test each page and its variations. Breadcrumbs should look correct, and each link should be correct. - In koha-conf.xml, look for "enable_plugins" - If this is set to 0, plugins are disabled: <enable_plugins>0</enable_plugins> - Navigate directly to /cgi-bin/koha/plugins/plugins-home.pl, which should say "Plugins disabled." Check the breadcrumbs on this page. - Enable plugins by changing the settimg in koha-conf.xml to 1 (a restart of services is required): <enable_plugins>1</enable_plugins> - Go to Administration -> Manage plugins - Test this page and the "Upload plugin" page. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00,22.11.05 released in| | Status|Pushed to master |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33429 --- Comment #7 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org