[Bug 16532] New: Libraries and groups showing empty tables if nothing defined
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Bug ID: 16532 Summary: Libraries and groups showing empty tables if nothing defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 51558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51558&action=edit Empty groups tables -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 51560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51560&action=edit Bug 16523: Groups showing empty tables if no groups defined To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51560|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 51561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51561&action=edit Bug 16532: Groups showing empty tables if no groups defined To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|koha-bugs@lists.koha-commun |aleishaamohia@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Can we do the same for libraries? Even with no libraries defined, "[% IF libraries.size %]" always evaluates as true. Why? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> ---
Even with no libraries defined, "[% IF libraries.size %]" always evaluates as true. Why?
Jonathan explained to me in IRC that because "libraries" is an object (from Koha::Libraries) we should use "count" instead: [% IF libraries.count %]... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51561|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 51730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51730&action=edit Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51730|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51767&action=edit [SIGNED-OFF] Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51767|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51803&action=edit Bug 16532: Groups showing empty tables if no groups defined EDIT: Same change for libraries To test: 1) Go to Admin -> Libraries and Groups 2) Notice empty tables if nothing defined 3) Apply patch and refresh page 4) Empty tables should not show 5) Add a new group 6) Confirm table shows correctly Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.01. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16532 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Not needed in 3.22.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org